* [PATCH] dt-bindings: ata: imx: Add a reference to ahci-common.yaml
@ 2025-08-22 17:58 Fabio Estevam
2025-08-23 13:55 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2025-08-22 17:58 UTC (permalink / raw)
To: cassel
Cc: dlemoal, robh, krzk+dt, conor+dt, linux-ide, devicetree, imx,
Fabio Estevam
The 'target-supply' property is documented in ahci-common.yaml.
Add a reference to ahci-common.yaml to fix the following dt-schema
warning:
'target-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Documentation/devicetree/bindings/ata/imx-sata.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ata/imx-sata.yaml b/Documentation/devicetree/bindings/ata/imx-sata.yaml
index f4eb3550a096..c60866544a53 100644
--- a/Documentation/devicetree/bindings/ata/imx-sata.yaml
+++ b/Documentation/devicetree/bindings/ata/imx-sata.yaml
@@ -88,6 +88,8 @@ required:
- clock-names
allOf:
+ - $ref: ahci-common.yaml#
+
- if:
properties:
compatible:
@@ -112,7 +114,7 @@ allOf:
clock-names:
minItems: 2
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ata: imx: Add a reference to ahci-common.yaml
2025-08-22 17:58 [PATCH] dt-bindings: ata: imx: Add a reference to ahci-common.yaml Fabio Estevam
@ 2025-08-23 13:55 ` Conor Dooley
2025-08-23 19:51 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Conor Dooley @ 2025-08-23 13:55 UTC (permalink / raw)
To: Fabio Estevam
Cc: cassel, dlemoal, robh, krzk+dt, conor+dt, linux-ide, devicetree,
imx
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
On Fri, Aug 22, 2025 at 02:58:30PM -0300, Fabio Estevam wrote:
> The 'target-supply' property is documented in ahci-common.yaml.
>
> Add a reference to ahci-common.yaml to fix the following dt-schema
> warning:
Same here I guess, you're allowing a bunch of other properties now, what
of those are actually permitted ones for this device?
>
> 'target-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Documentation/devicetree/bindings/ata/imx-sata.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/imx-sata.yaml b/Documentation/devicetree/bindings/ata/imx-sata.yaml
> index f4eb3550a096..c60866544a53 100644
> --- a/Documentation/devicetree/bindings/ata/imx-sata.yaml
> +++ b/Documentation/devicetree/bindings/ata/imx-sata.yaml
> @@ -88,6 +88,8 @@ required:
> - clock-names
>
> allOf:
> + - $ref: ahci-common.yaml#
> +
> - if:
> properties:
> compatible:
> @@ -112,7 +114,7 @@ allOf:
> clock-names:
> minItems: 2
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ata: imx: Add a reference to ahci-common.yaml
2025-08-23 13:55 ` Conor Dooley
@ 2025-08-23 19:51 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2025-08-23 19:51 UTC (permalink / raw)
To: Conor Dooley
Cc: cassel, dlemoal, robh, krzk+dt, conor+dt, linux-ide, devicetree,
imx
On Sat, Aug 23, 2025 at 10:55 AM Conor Dooley <conor@kernel.org> wrote:
> Same here I guess, you're allowing a bunch of other properties now, what
> of those are actually permitted ones for this device?
Only 'target-supply' is actually needed.
I sent v2 documenting 'target-supply'.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-23 19:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 17:58 [PATCH] dt-bindings: ata: imx: Add a reference to ahci-common.yaml Fabio Estevam
2025-08-23 13:55 ` Conor Dooley
2025-08-23 19:51 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).