From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2BE72BEFEA; Mon, 25 Aug 2025 08:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756111305; cv=none; b=nSY493xyrr/7N18Ls5i4xkfaPvBwY0hazhAC7/7kLQkF3lj/e63s1uMvR7cieCP+h1b52wsmjRLupFhdsvZi6MOUZ/QCDgFQ88iHmCKiQQbPsRPfQFnOEucHRZPar5DUk2YnWZujqT9zW4K4E5BbAHaiEBqeEkzivZkj+wbuRM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756111305; c=relaxed/simple; bh=K2j4Xg82+Ip2/lcscGXYAAN0FTOLzSOwafKLqgXQ6dA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iLr9raEOsGGqCZ4EY8xhDvwCwgs48nK4ba90RNpdtGswlXId2sqKB62u8AVOf1O0hqwDd3WGqTqcmH7+My923NNKbIwkXNG1dILJhj2PqTEN2ebmcEo4EUqa0LT+bjNfA10lx8MWVCqtsNiibht1uFNjIMFUbKVT3Q6dyliOH5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZBAHoObe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZBAHoObe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E789C4CEED; Mon, 25 Aug 2025 08:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756111304; bh=K2j4Xg82+Ip2/lcscGXYAAN0FTOLzSOwafKLqgXQ6dA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZBAHoObexxJACm0CyT3rWXmTuEE3szQxoY+ur1d3YdWHQaypq84Bs3bw170XTdiJs Fbkj+dLEIluoQjMCiePR3+JYeu2vjM/kZ5FUo4gmjOAVjqhrIrxUIsYMfm0z55V5z/ fs4QYjZqJi7rxJ5VxWWchq/yTvwSj7xStzfihEv9Y/SsfJc5slYpJUGrOf93HPIvFL a0e7q75do94CVIMGHOgJ/VpMIDC2D7nFQOtpeEnLr/Hwr8tUNlSMSo5UrwGktdFcu5 gPtDrlIV1iPA+gG1UmsY6pAtRTF1+7Jm+owKUNZpYQ3OlNR15vKbyaHqY2irS2NWEi 81EoJrJwx/hEw== Date: Mon, 25 Aug 2025 09:41:28 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Xichao Zhao , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Andreas Klinger , Haibo Chen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Marius Cristea , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Heiko Stuebner , Francesco Dolcini , =?UTF-8?B?Sm/Do28=?= Paulo =?UTF-8?B?R29uw6dhbHZlcw==?= , Hugo Villeneuve , Gustavo Silva , Tomasz Duszynski , Jagath Jog J , Crt Mori , Per-Daniel Olsson , Waqar Hameed , Yasin Lee , Julien Stephan , "open list:IIO SUBSYSTEM AND DRIVERS" , open list , "open list:NXP i.MX 7D/6SX/6UL/93 AND VF610 ADC DRIVER" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:ARM/Amlogic Meson SoC support" , "open list:ARM/Rockchip SoC support" Subject: Re: [PATCH 0/7] iio: Remove dev_err_probe() if error is -ENOMEM Message-ID: <20250825094128.7d2834fa@jic23-huawei> In-Reply-To: References: <20250821080723.525379-1-zhao.xichao@vivo.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 21 Aug 2025 11:13:00 +0300 Andy Shevchenko wrote: > On Thu, Aug 21, 2025 at 11:07=E2=80=AFAM Xichao Zhao wrote: > > > > The dev_err_probe() doesn't do anything when error is '-ENOMEM'. =20 >=20 > when the error >=20 Tweaked and applied. > > Therefore, remove the useless call to dev_err_probe(), and just > > return the value instead. =20 >=20 > In favour of this series, > Reviewed-by: Andy Shevchenko > (yes, I indeed looked at all patches in this one :-) >=20