From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC802EAB6A; Mon, 25 Aug 2025 11:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756121970; cv=none; b=jptS9MF9BKkDH0LL2OTRZuCFMjkxwme+hb/KvXwpXTiYRM+acsyPKzGQVozSA5X8sycJ5VzTNT06z8vhakOb6MUalYTJOtI7ZYVr3yWaT2+U7QVVxLWM6ZQebjAcG/trJnnMJHLNkxcgAXO7DIt3kEfNXgv63bHo4XBfHoNi1zM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756121970; c=relaxed/simple; bh=7GO8Jac/WHBeZjLJm6fIwvfWXASWj8xYr2ROiPzF9aw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fK/y0HpCGkdx88TdwbvQtZed8vLcvPpxj2rmuIG/cfScbPN8TNbuLfSyrS/5aCXnH8gkeL/MeOP+BvCqxslTfeS5djU1dyf83zJ5k1VMAxEjUNtZV+iF1tXad026fsBw8AhAeBiGeNQsjIYRg6NdeYK5N7NJZAar6uZxcUVrrO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iwfu8tca; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iwfu8tca" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0328DC4CEED; Mon, 25 Aug 2025 11:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756121970; bh=7GO8Jac/WHBeZjLJm6fIwvfWXASWj8xYr2ROiPzF9aw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iwfu8tcaJGUohZ1xHZUMJowvML3G8NY+bdjH9VfIzuIhdm5y42l5Ande4p8TWQ1Lx gmEgz/P9aAafKnlQrJlUWyXYAcAqj+I4CwQxT5qle6VRvEQQRxr0+RgQm0NHLhQo+s Df9HLsaYXPKqsW2AdXzaD9NpxoM4DA2QAgFzLpaOMDBsX6yuwpDpi+OjdaQDCPhNri HgkWVFk67uDHuGhqaclhyjdCY9mCxc93vBEI75XUrAlrJS0oIyFvBfwM06WakAkS4Q XzpIrftTP3tJJwESpsBNigK4l0dfZoHYX7RcTRyN5KZ04FBbC5d2mwlPahqF+W9ZUU xnUQcc7EWJuFA== Date: Mon, 25 Aug 2025 12:39:19 +0100 From: Jonathan Cameron To: Dixit Parmar Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Ray Jui , Scott Branden , Broadcom internal kernel review list , Support Opensource , Krzysztof Kozlowski , Alim Akhtar , Haibo Chen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Cai Huoqing , Maxime Coquelin , Alexandre Torgue , Andreas Klinger , Crt Mori , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 00/10] iio: Drop unnecessary -ENOMEM messages Message-ID: <20250825123919.3c228ef7@jic23-huawei> In-Reply-To: <20250825093150.3ba23f2a@jic23-huawei> References: <20250822-enomam_logs-v1-0-db87f2974552@gmail.com> <20250825093150.3ba23f2a@jic23-huawei> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 25 Aug 2025 09:31:50 +0100 Jonathan Cameron wrote: > On Fri, 22 Aug 2025 09:19:48 +0530 > Dixit Parmar wrote: > > > The drivers do not require their own error messages for error > > -ENOMEM, memory allocation failures. So remove the dev_err > > messages from the probe(). > > With these patches, all the iio drivers now has uniform handling > > of the -ENOMEM while device_allocation and trigger_allocation > > calls. > > > > Signed-off-by: Dixit Parmar > Series looks fine to me, after the minor tweaks to commit messages > that Andy requested. However as it touches a lot of drivers > I'd like to leave it on list a little longer. I changed my mind after taking the dev_err_probe() series earlier. I'm rather too busy at the moment, so clearing this out now will reduce what I need to keep track of. Fixed up the () that Andy asked for in commit messages and applied to the togreg branch of iio.git, pushed out initially as testing. There is still the rest of the week (probably) in which I can add tags etc if anyone wants to give them before I push that out as a non rebasing tree. Thanks, Jonathan > > Thanks, > > Jonathan > > > --- > > Dixit Parmar (10): > > iio: accel: Drop unnecessary -ENOMEM messages > > iio: adc: Drop unnecessary -ENOMEM messages > > iio: dac: Drop unnecessary -ENOMEM messages > > iio: health: Drop unnecessary -ENOMEM messages > > iio: humidity: Drop unnecessary -ENOMEM messages > > iio: light: Drop unnecessary -ENOMEM messages > > iio: potentiostat: Drop unnecessary -ENOMEM messages > > iio: pressure: Drop unnecessary -ENOMEM messages > > iio: proximity: Drop unnecessary -ENOMEM messages > > iio: temperature: Drop unnecessary -ENOMEM messages > > > > drivers/iio/accel/bma220_spi.c | 4 +--- > > drivers/iio/accel/dmard06.c | 4 +--- > > drivers/iio/accel/dmard09.c | 4 +--- > > drivers/iio/accel/dmard10.c | 4 +--- > > drivers/iio/accel/mc3230.c | 4 +--- > > drivers/iio/accel/mma7660.c | 4 +--- > > drivers/iio/accel/stk8312.c | 4 +--- > > drivers/iio/accel/stk8ba50.c | 4 +--- > > drivers/iio/adc/ad7949.c | 4 +--- > > drivers/iio/adc/bcm_iproc_adc.c | 4 +--- > > drivers/iio/adc/cpcap-adc.c | 6 ++---- > > drivers/iio/adc/da9150-gpadc.c | 5 ++--- > > drivers/iio/adc/dln2-adc.c | 9 +++------ > > drivers/iio/adc/exynos_adc.c | 4 +--- > > drivers/iio/adc/imx7d_adc.c | 4 +--- > > drivers/iio/adc/imx8qxp-adc.c | 4 +--- > > drivers/iio/adc/mxs-lradc-adc.c | 4 +--- > > drivers/iio/adc/palmas_gpadc.c | 4 +--- > > drivers/iio/adc/rn5t618-adc.c | 4 +--- > > drivers/iio/adc/stm32-dfsdm-adc.c | 4 +--- > > drivers/iio/adc/stmpe-adc.c | 4 +--- > > drivers/iio/adc/ti-adc084s021.c | 4 +--- > > drivers/iio/adc/ti-ads131e08.c | 8 ++------ > > drivers/iio/adc/ti_am335x_adc.c | 5 ++--- > > drivers/iio/adc/twl4030-madc.c | 4 +--- > > drivers/iio/adc/viperboard_adc.c | 4 +--- > > drivers/iio/dac/ad5380.c | 4 +--- > > drivers/iio/dac/ad5764.c | 4 +--- > > drivers/iio/dac/ds4424.c | 4 +--- > > drivers/iio/dac/ti-dac7311.c | 4 +--- > > drivers/iio/dac/vf610_dac.c | 4 +--- > > drivers/iio/health/afe4403.c | 4 +--- > > drivers/iio/health/afe4404.c | 4 +--- > > drivers/iio/humidity/am2315.c | 4 +--- > > drivers/iio/humidity/dht11.c | 4 +--- > > drivers/iio/light/stk3310.c | 4 +--- > > drivers/iio/potentiostat/lmp91000.c | 4 +--- > > drivers/iio/pressure/dlhl60d.c | 4 +--- > > drivers/iio/proximity/ping.c | 4 +--- > > drivers/iio/proximity/srf04.c | 4 +--- > > drivers/iio/temperature/mlx90632.c | 4 +--- > > 41 files changed, 47 insertions(+), 130 deletions(-) > > --- > > base-commit: d7b8f8e20813f0179d8ef519541a3527e7661d3a > > change-id: 20250822-enomam_logs-f66642957fb3 > > > > Best regards, > >