From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 011992AE6A for ; Sun, 21 Sep 2025 22:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758493263; cv=none; b=nnxR7Wglz1U2ILvrFSMgANv60c50Kx6N2Y4LsJ4ts0X9+NJZiw9IwH03F7ghpP3soUqeB/QxZw5ssZTZJ74mdR2g9ZA/XU2byRCgA4+rwn8drT+3sSgx9oUcsT5ZGdFhYW4akH/ugpSrkuSNGoV1UgQfGRpfQBsHy3y/A0w2Cuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758493263; c=relaxed/simple; bh=+eOD1GcoHBO726C3msHiBvYXNdElq3AA2TEiC9gvtBE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lWd0TQStdlEP8Hy4rzk6RNgR8ZEdXGTxTN2ugHvcSGPGMWDvas+SFLZiysvh/qry33JbAV0KrEJV4t8Np8FO0alIJKV71iGuDEiG5ZgkfRTKSasL31pR1w+WnxGyh8Bu4d2EGuaP39qXK0MLKP7QrzCVirRef/jb3U0pdJud570= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=urhkteUg; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="urhkteUg" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 551D710C4; Mon, 22 Sep 2025 00:19:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1758493178; bh=+eOD1GcoHBO726C3msHiBvYXNdElq3AA2TEiC9gvtBE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=urhkteUgoEr0pBFx5ZznC9R2+mPCnkVmCYz5NI8vXmF1bE1E22cMMjRdVmF1KKKRD UTiO7k4R30B2fyZLEg2IeT4PCGYPuyY41r3RrPWsSGbYimiIWaV0/+bCl0BdU1zgQv Pb+jYlPU7F6tTtayG/H3hMsVuUvw2m/gLF5P8x9w= Date: Mon, 22 Sep 2025 01:20:29 +0300 From: Laurent Pinchart To: Guoniu Zhou Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] media: nxp: imx8-isi: Reorder the platform data Message-ID: <20250921222029.GD10540@pendragon.ideasonboard.com> References: <20250905-isi_imx93-v2-0-37db5f768c57@nxp.com> <20250905-isi_imx93-v2-4-37db5f768c57@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250905-isi_imx93-v2-4-37db5f768c57@nxp.com> Hi Guoniu, Thank you for the patch. On Fri, Sep 05, 2025 at 02:56:01PM +0800, Guoniu Zhou wrote: > Sort platform data in the order of compatible strings in of_match table > to make it more convenient to read. > > No functions changed. > > Reviewed-by: Frank Li > Signed-off-by: Guoniu Zhou Reviewed-by: Laurent Pinchart > --- > .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 44 +++++++++++----------- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c > index adc8d9960bf0df87d4e475661a3439beaf5ce9f6..0155c75983f02f33f7f0669e73188222ebb5e816 100644 > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c > @@ -314,6 +314,28 @@ static const struct mxc_isi_plat_data mxc_imx8mp_data = { > .has_36bit_dma = true, > }; > > +static const struct mxc_isi_plat_data mxc_imx8qm_data = { > + .model = MXC_ISI_IMX8QM, > + .num_ports = 5, > + .num_channels = 8, > + .reg_offset = 0x10000, > + .ier_reg = &mxc_imx8_isi_ier_qm, > + .set_thd = &mxc_imx8_isi_thd_v1, > + .buf_active_reverse = true, > + .has_36bit_dma = false, > +}; > + > +static const struct mxc_isi_plat_data mxc_imx8qxp_data = { > + .model = MXC_ISI_IMX8QXP, > + .num_ports = 5, > + .num_channels = 6, > + .reg_offset = 0x10000, > + .ier_reg = &mxc_imx8_isi_ier_v2, > + .set_thd = &mxc_imx8_isi_thd_v1, > + .buf_active_reverse = true, > + .has_36bit_dma = false, > +}; > + > static const struct mxc_isi_plat_data mxc_imx8ulp_data = { > .model = MXC_ISI_IMX8ULP, > .num_ports = 1, > @@ -337,28 +359,6 @@ static const struct mxc_isi_plat_data mxc_imx93_data = { > .has_36bit_dma = false, > }; > > -static const struct mxc_isi_plat_data mxc_imx8qm_data = { > - .model = MXC_ISI_IMX8QM, > - .num_ports = 5, > - .num_channels = 8, > - .reg_offset = 0x10000, > - .ier_reg = &mxc_imx8_isi_ier_qm, > - .set_thd = &mxc_imx8_isi_thd_v1, > - .buf_active_reverse = true, > - .has_36bit_dma = false, > -}; > - > -static const struct mxc_isi_plat_data mxc_imx8qxp_data = { > - .model = MXC_ISI_IMX8QXP, > - .num_ports = 5, > - .num_channels = 6, > - .reg_offset = 0x10000, > - .ier_reg = &mxc_imx8_isi_ier_v2, > - .set_thd = &mxc_imx8_isi_thd_v1, > - .buf_active_reverse = true, > - .has_36bit_dma = false, > -}; > - > /* ----------------------------------------------------------------------------- > * Power management > */ -- Regards, Laurent Pinchart