* [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional
@ 2025-09-28 9:03 Rain Yang
2025-09-28 9:03 ` [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop Rain Yang
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Rain Yang @ 2025-09-28 9:03 UTC (permalink / raw)
To: imx, dri-devel, devicetree, linux-kernel
Cc: boris.brezillon, steven.price, liviu.dudau, maarten.lankhorst,
mripard, tzimmermann, airlied, simona, marek.vasut, robh, krzk+dt,
conor+dt, Rain Yang
From: Rain Yang <jiyu.yang@nxp.com>
Not all platforms require the mali-supply regulator. This change removes
it from the required list in the binding schema, and make mali-supply
required for rk3588 only.
Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
---
.../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
index b220cbd5362f..ef9791d8ed95 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
@@ -92,7 +92,6 @@ required:
- interrupts
- interrupt-names
- clocks
- - mali-supply
additionalProperties: false
@@ -109,6 +108,8 @@ allOf:
power-domains:
maxItems: 1
power-domain-names: false
+ required:
+ - mali-supply
examples:
- |
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop
2025-09-28 9:03 [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rain Yang
@ 2025-09-28 9:03 ` Rain Yang
2025-10-02 6:38 ` Boris Brezillon
2025-10-02 8:21 ` Steven Price
2025-10-02 3:37 ` [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rob Herring (Arm)
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Rain Yang @ 2025-09-28 9:03 UTC (permalink / raw)
To: imx, dri-devel, devicetree, linux-kernel
Cc: boris.brezillon, steven.price, liviu.dudau, maarten.lankhorst,
mripard, tzimmermann, airlied, simona, marek.vasut, robh, krzk+dt,
conor+dt, Rain Yang
From: Rain Yang <jiyu.yang@nxp.com>
The regulator is optional, skip the setup instead of returning an
error if it is not present
Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
---
drivers/gpu/drm/panthor/panthor_devfreq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c
index 3686515d368d..2df1d76d84a0 100644
--- a/drivers/gpu/drm/panthor/panthor_devfreq.c
+++ b/drivers/gpu/drm/panthor/panthor_devfreq.c
@@ -146,10 +146,9 @@ int panthor_devfreq_init(struct panthor_device *ptdev)
ptdev->devfreq = pdevfreq;
ret = devm_pm_opp_set_regulators(dev, reg_names);
- if (ret) {
+ if (ret && ret != -ENODEV) {
if (ret != -EPROBE_DEFER)
DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n");
-
return ret;
}
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional
2025-09-28 9:03 [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rain Yang
2025-09-28 9:03 ` [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop Rain Yang
@ 2025-10-02 3:37 ` Rob Herring (Arm)
2025-10-02 6:38 ` Boris Brezillon
2025-10-09 13:00 ` Steven Price
3 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-10-02 3:37 UTC (permalink / raw)
To: Rain Yang
Cc: steven.price, devicetree, tzimmermann, marek.vasut, krzk+dt,
maarten.lankhorst, mripard, imx, dri-devel, liviu.dudau, conor+dt,
Rain Yang, simona, airlied, boris.brezillon, linux-kernel
On Sun, 28 Sep 2025 17:03:33 +0800, Rain Yang wrote:
> From: Rain Yang <jiyu.yang@nxp.com>
>
> Not all platforms require the mali-supply regulator. This change removes
> it from the required list in the binding schema, and make mali-supply
> required for rk3588 only.
>
> Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
> ---
> .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop
2025-09-28 9:03 ` [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop Rain Yang
@ 2025-10-02 6:38 ` Boris Brezillon
2025-10-02 8:21 ` Steven Price
1 sibling, 0 replies; 9+ messages in thread
From: Boris Brezillon @ 2025-10-02 6:38 UTC (permalink / raw)
To: Rain Yang
Cc: imx, dri-devel, devicetree, linux-kernel, steven.price,
liviu.dudau, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, marek.vasut, robh, krzk+dt, conor+dt, Rain Yang
On Sun, 28 Sep 2025 17:03:34 +0800
Rain Yang <jiyu.yang@oss.nxp.com> wrote:
> From: Rain Yang <jiyu.yang@nxp.com>
>
> The regulator is optional, skip the setup instead of returning an
> error if it is not present
>
> Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/panthor/panthor_devfreq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c
> index 3686515d368d..2df1d76d84a0 100644
> --- a/drivers/gpu/drm/panthor/panthor_devfreq.c
> +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c
> @@ -146,10 +146,9 @@ int panthor_devfreq_init(struct panthor_device *ptdev)
> ptdev->devfreq = pdevfreq;
>
> ret = devm_pm_opp_set_regulators(dev, reg_names);
> - if (ret) {
> + if (ret && ret != -ENODEV) {
> if (ret != -EPROBE_DEFER)
> DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n");
> -
> return ret;
> }
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional
2025-09-28 9:03 [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rain Yang
2025-09-28 9:03 ` [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop Rain Yang
2025-10-02 3:37 ` [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rob Herring (Arm)
@ 2025-10-02 6:38 ` Boris Brezillon
2025-10-09 13:00 ` Steven Price
3 siblings, 0 replies; 9+ messages in thread
From: Boris Brezillon @ 2025-10-02 6:38 UTC (permalink / raw)
To: Rain Yang
Cc: imx, dri-devel, devicetree, linux-kernel, steven.price,
liviu.dudau, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, marek.vasut, robh, krzk+dt, conor+dt, Rain Yang
On Sun, 28 Sep 2025 17:03:33 +0800
Rain Yang <jiyu.yang@oss.nxp.com> wrote:
> From: Rain Yang <jiyu.yang@nxp.com>
>
> Not all platforms require the mali-supply regulator. This change removes
> it from the required list in the binding schema, and make mali-supply
> required for rk3588 only.
>
> Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> index b220cbd5362f..ef9791d8ed95 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> @@ -92,7 +92,6 @@ required:
> - interrupts
> - interrupt-names
> - clocks
> - - mali-supply
>
> additionalProperties: false
>
> @@ -109,6 +108,8 @@ allOf:
> power-domains:
> maxItems: 1
> power-domain-names: false
> + required:
> + - mali-supply
>
> examples:
> - |
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop
2025-09-28 9:03 ` [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop Rain Yang
2025-10-02 6:38 ` Boris Brezillon
@ 2025-10-02 8:21 ` Steven Price
1 sibling, 0 replies; 9+ messages in thread
From: Steven Price @ 2025-10-02 8:21 UTC (permalink / raw)
To: Rain Yang, imx, dri-devel, devicetree, linux-kernel
Cc: boris.brezillon, liviu.dudau, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, marek.vasut, robh, krzk+dt,
conor+dt, Rain Yang
On 28/09/2025 10:03, Rain Yang wrote:
> From: Rain Yang <jiyu.yang@nxp.com>
>
> The regulator is optional, skip the setup instead of returning an
> error if it is not present
>
> Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panthor/panthor_devfreq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c
> index 3686515d368d..2df1d76d84a0 100644
> --- a/drivers/gpu/drm/panthor/panthor_devfreq.c
> +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c
> @@ -146,10 +146,9 @@ int panthor_devfreq_init(struct panthor_device *ptdev)
> ptdev->devfreq = pdevfreq;
>
> ret = devm_pm_opp_set_regulators(dev, reg_names);
> - if (ret) {
> + if (ret && ret != -ENODEV) {
> if (ret != -EPROBE_DEFER)
> DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n");
> -
> return ret;
> }
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional
2025-09-28 9:03 [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rain Yang
` (2 preceding siblings ...)
2025-10-02 6:38 ` Boris Brezillon
@ 2025-10-09 13:00 ` Steven Price
2025-10-09 14:43 ` Frank Li
3 siblings, 1 reply; 9+ messages in thread
From: Steven Price @ 2025-10-09 13:00 UTC (permalink / raw)
To: Rain Yang, imx, dri-devel, devicetree, linux-kernel
Cc: boris.brezillon, liviu.dudau, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, marek.vasut, robh, krzk+dt,
conor+dt, Rain Yang
Series applied to drm-misc-next.
Thanks,
Steve
On 28/09/2025 10:03, Rain Yang wrote:
> From: Rain Yang <jiyu.yang@nxp.com>
>
> Not all platforms require the mali-supply regulator. This change removes
> it from the required list in the binding schema, and make mali-supply
> required for rk3588 only.
>
> Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
> ---
> .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> index b220cbd5362f..ef9791d8ed95 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> @@ -92,7 +92,6 @@ required:
> - interrupts
> - interrupt-names
> - clocks
> - - mali-supply
>
> additionalProperties: false
>
> @@ -109,6 +108,8 @@ allOf:
> power-domains:
> maxItems: 1
> power-domain-names: false
> + required:
> + - mali-supply
>
> examples:
> - |
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional
2025-10-09 13:00 ` Steven Price
@ 2025-10-09 14:43 ` Frank Li
2025-10-09 14:52 ` Boris Brezillon
0 siblings, 1 reply; 9+ messages in thread
From: Frank Li @ 2025-10-09 14:43 UTC (permalink / raw)
To: Steven Price
Cc: Rain Yang, imx, dri-devel, devicetree, linux-kernel,
boris.brezillon, liviu.dudau, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, marek.vasut, robh, krzk+dt,
conor+dt, Rain Yang
On Thu, Oct 09, 2025 at 02:00:43PM +0100, Steven Price wrote:
> Series applied to drm-misc-next.
I have not seen DT team's acked tag for binding.
Frank
>
> Thanks,
> Steve
>
> On 28/09/2025 10:03, Rain Yang wrote:
> > From: Rain Yang <jiyu.yang@nxp.com>
> >
> > Not all platforms require the mali-supply regulator. This change removes
> > it from the required list in the binding schema, and make mali-supply
> > required for rk3588 only.
> >
> > Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
> > ---
> > .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> > index b220cbd5362f..ef9791d8ed95 100644
> > --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> > @@ -92,7 +92,6 @@ required:
> > - interrupts
> > - interrupt-names
> > - clocks
> > - - mali-supply
> >
> > additionalProperties: false
> >
> > @@ -109,6 +108,8 @@ allOf:
> > power-domains:
> > maxItems: 1
> > power-domain-names: false
> > + required:
> > + - mali-supply
> >
> > examples:
> > - |
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional
2025-10-09 14:43 ` Frank Li
@ 2025-10-09 14:52 ` Boris Brezillon
0 siblings, 0 replies; 9+ messages in thread
From: Boris Brezillon @ 2025-10-09 14:52 UTC (permalink / raw)
To: Frank Li
Cc: Steven Price, Rain Yang, imx, dri-devel, devicetree, linux-kernel,
liviu.dudau, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, marek.vasut, robh, krzk+dt, conor+dt, Rain Yang
On Thu, 9 Oct 2025 10:43:25 -0400
Frank Li <Frank.li@nxp.com> wrote:
> On Thu, Oct 09, 2025 at 02:00:43PM +0100, Steven Price wrote:
> > Series applied to drm-misc-next.
>
> I have not seen DT team's acked tag for binding.
Rob acked it.
>
> Frank
>
> >
> > Thanks,
> > Steve
> >
> > On 28/09/2025 10:03, Rain Yang wrote:
> > > From: Rain Yang <jiyu.yang@nxp.com>
> > >
> > > Not all platforms require the mali-supply regulator. This change removes
> > > it from the required list in the binding schema, and make mali-supply
> > > required for rk3588 only.
> > >
> > > Signed-off-by: Rain Yang <jiyu.yang@nxp.com>
> > > ---
> > > .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> > > index b220cbd5362f..ef9791d8ed95 100644
> > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> > > @@ -92,7 +92,6 @@ required:
> > > - interrupts
> > > - interrupt-names
> > > - clocks
> > > - - mali-supply
> > >
> > > additionalProperties: false
> > >
> > > @@ -109,6 +108,8 @@ allOf:
> > > power-domains:
> > > maxItems: 1
> > > power-domain-names: false
> > > + required:
> > > + - mali-supply
> > >
> > > examples:
> > > - |
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-10-09 14:52 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-28 9:03 [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rain Yang
2025-09-28 9:03 ` [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop Rain Yang
2025-10-02 6:38 ` Boris Brezillon
2025-10-02 8:21 ` Steven Price
2025-10-02 3:37 ` [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rob Herring (Arm)
2025-10-02 6:38 ` Boris Brezillon
2025-10-09 13:00 ` Steven Price
2025-10-09 14:43 ` Frank Li
2025-10-09 14:52 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).