From: Jonathan Cameron <jic23@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-iio@vger.kernel.org,
joshua.yeong@starfivetech.com, devicetree@vger.kernel.org,
"Carlos Song" <carlos.song@nxp.com>,
"Adrian Fluturel" <fluturel.adrian@gmail.com>
Subject: Re: [PATCH v5 0/5] i3c: Add basic HDR mode support
Date: Sun, 12 Oct 2025 18:03:27 +0100 [thread overview]
Message-ID: <20251012180327.5d94dda2@jic23-huawei> (raw)
In-Reply-To: <20251007-i3c_ddr-v5-0-444184f7725e@nxp.com>
On Tue, 07 Oct 2025 16:06:12 -0400
Frank Li <Frank.Li@nxp.com> wrote:
> Add basic HDR mode support, only support private transfer, not support
> CCC command.
>
> Update i3c framework API to allow pass down mode and extend driver callback
> function.
>
> Implement HDR transfer in svc i3c master driver.
>
> Simplifed HDR flow is (ref i3c spec line 5514) Figure 129
>
> <-- SDR ---> | <--- HDR
> START 0x7E RnW(0) ACK CCC(ENTHDR0) T HDR-CMD(00-7f write, 80--ff read)
>
> ----> |
> HDR-DATA HDR-CRC HDR-RESTART .... HDR-EXIT
>
> Note: HDR-CMD is 16bit data, which included 7bit slave address and 8bit
> read/write command.
>
> svc hardware can auto issue SDR part.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Whilst there will probably have to be a v6 for the ACPI ID issue in patch 5,
I'd like to ask the question of how are we planning to merge this?
Maybe an immutable branch either in IIO or I3C trees that the other one picks up?
It's a new driver so could gamble on taking the IIO driver the I3C tree but even
then I'd like a topic / immutable branch in case any IIO wide refactors or similar
hit this cycle.
Thanks,
Jonathan
> ---
> Changes in v5:
> - Just realized missed CC mail list devicetree@vger.kernel.org and resend
> - Link to v4: https://lore.kernel.org/r/20251007-i3c_ddr-v4-0-3afea5105775@nxp.com
>
> Changes in v4:
> - use master's hdr_cap to check HDR cap.
> - add mmc5603 support.
> - Link to v3: https://lore.kernel.org/r/20250930-i3c_ddr-v3-0-b627dc2ef172@nxp.com
>
> Changes in v3:
> - Add new patch for change rnw to union for svc.
> - Detial changes see each patch's change log.
> - Link to v2: https://lore.kernel.org/r/20250924-i3c_ddr-v2-0-682a0eb32572@nxp.com
>
> Changes in v2:
> - Add sensor driver, which use HDR mode read/write data.
> - change priv_xfer to i3c_xfer.
> - Link to v1: https://lore.kernel.org/r/20250129-i3c_ddr-v1-0-028a7a5d4324@nxp.com
>
> ---
> Frank Li (5):
> i3c: Add HDR API support
> i3c: master: svc: Replace bool rnw with union for HDR support
> i3c: master: svc: Add basic HDR mode support
> dt-bindings: trivial-devices: add MEMSIC 3-axis magnetometer
> iio: magnetometer: Add mmc5633 sensor
>
> .../devicetree/bindings/trivial-devices.yaml | 4 +
> drivers/i3c/device.c | 27 +-
> drivers/i3c/internals.h | 6 +-
> drivers/i3c/master.c | 19 +-
> drivers/i3c/master/svc-i3c-master.c | 96 +++-
> drivers/iio/magnetometer/Kconfig | 12 +
> drivers/iio/magnetometer/Makefile | 1 +
> drivers/iio/magnetometer/mmc5633.c | 579 +++++++++++++++++++++
> include/linux/i3c/device.h | 34 +-
> include/linux/i3c/master.h | 4 +
> 10 files changed, 745 insertions(+), 37 deletions(-)
> ---
> base-commit: 5248ab97a6dd1dc6856422f6b1595baaf4fa85ce
> change-id: 20250129-i3c_ddr-b15488901eb8
>
> Best regards,
> --
> Frank Li <Frank.Li@nxp.com>
>
next prev parent reply other threads:[~2025-10-12 17:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 20:06 [PATCH v5 0/5] i3c: Add basic HDR mode support Frank Li
2025-10-07 20:06 ` [PATCH v5 1/5] i3c: Add HDR API support Frank Li
2025-10-07 20:06 ` [PATCH v5 2/5] i3c: master: svc: Replace bool rnw with union for HDR support Frank Li
2025-10-07 20:06 ` [PATCH v5 3/5] i3c: master: svc: Add basic HDR mode support Frank Li
2025-10-07 20:06 ` [PATCH v5 4/5] dt-bindings: trivial-devices: add MEMSIC 3-axis magnetometer Frank Li
2025-10-08 20:18 ` Conor Dooley
2025-10-07 20:06 ` [PATCH v5 5/5] iio: magnetometer: Add mmc5633 sensor Frank Li
2025-10-12 17:01 ` Jonathan Cameron
2025-10-13 19:44 ` Frank Li
2025-10-12 17:03 ` Jonathan Cameron [this message]
2025-10-13 19:38 ` [PATCH v5 0/5] i3c: Add basic HDR mode support Frank Li
2025-10-13 19:54 ` Alexandre Belloni
2025-10-18 13:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251012180327.5d94dda2@jic23-huawei \
--to=jic23@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andy@kernel.org \
--cc=carlos.song@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=fluturel.adrian@gmail.com \
--cc=imx@lists.linux.dev \
--cc=joshua.yeong@starfivetech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).