From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D64B308F1B for ; Mon, 13 Oct 2025 14:15:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364907; cv=none; b=Q5hsyY1rPs/iZMzyV+BiOMKPc2ldHKT/B177JOPTyaX6biLgdzDpIHBThzRqc0ryDpl7ojWvfD4tf1fDqDQ24eINuhukF9XlRo72NIFjM/dFrKiAWT50Ze29gC+4gCMIs1Z6Udz9SH20ixY6RQg/Kp2h8BBXK0F5ErLoiI9XGNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364907; c=relaxed/simple; bh=I7TGAr67/gQzv/N2orW4jc5CGXZ/k6/Zdc8d4ItKKFs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cGYE55jE1Mjp4QGDqOTDbh4qiAEJK2zQGxkTlDCG65RkFhj3ToEZqAGeVO8N7Ukop1k7sJ1h7pe7RvGQkJGt2Q9T0ldOyipU/Q53iSfcJ/09ySFWV18KmmGsiczGK7tfLDKkRLfo6aj947VaFfVTbelBfzRcGFsbTLpcwY4ZFtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=if+8EG/0; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="if+8EG/0" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-57a292a3a4bso5390292e87.3 for ; Mon, 13 Oct 2025 07:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364899; x=1760969699; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Kj07cX9dfdog7qE3ITvyCUHudwQ7Qr1GriLN3ezW2JQ=; b=if+8EG/0J0nufayC6q6dE2srw4w5BWKoY9Wpbg1A/x9VIj5gacOzm6FSOjypPvYUxb SqWIeFozjtL97psZyL3N193ghScc0y120Cn0u1ZcO5J6+MUo0T4Iyml32pm9/t9ZIPWR V4WLCr4j7HO2JoJ0+gf6Zv5p3pUlfyADu/gq4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364899; x=1760969699; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kj07cX9dfdog7qE3ITvyCUHudwQ7Qr1GriLN3ezW2JQ=; b=VUJbj5JzCwpfAsAwkFSUcM7Sx+yXtN30YL7Cai2cTiQWBlhM2YyqUpT/PuT0WC4PS6 FPgFr2VrPPAyNQHIGpThrq16kz6hjuFYWtxktWoJ8zDbNYDjLkpo3wk59seiNxCOzoFM uCdHCGCBo5Pjsm3TgBYXdVBOu1Jvhs1FyM9+vUU2iJUGwuMpit6910MBL7adVHBAU+tX cigmYOBF64jTu2QPMYUhZzOY2WviIR0Vxavg9upKWdEwHzR5W/QsQ41MM5IN7S1tTShM E7uwycWc+88iyRH0aqkxXd1EFn2Po6UgIr1fgm1ydPxNWGlTz5d3kDb+UFvNkeXDRHYM RErA== X-Forwarded-Encrypted: i=1; AJvYcCVCMUt6UuyAaP1X4rLBTCkNbmBMK7f7y/z3+51B2kYtU4uiIHU72In1lgS2Qx7wYVQwDGo=@lists.linux.dev X-Gm-Message-State: AOJu0Ywt9bamFj5jEbxFwlYaCMrMc0gBIYjGP3p7jr5h52D9HnAv5rj/ Ds3b0f44sjhs6MsU30BFw3+JiFOMm8w7y+JeO77gRXQroBP4kQnb0l2EN6TCQnZ1Cw== X-Gm-Gg: ASbGncvbMyU2ngP2jwCAN4nl24zxjt+qSYrGiMLjJMIjWkrsPlL+hv5HcOUzTy5QckR 2DR5idm1u4zzNMv7IzFazI+V4xGv03kPD8ZAkV4C6T7PE7U073qvu3TsOcHcTr4zTSdlUO78u++ 90cjtWVf66bFdhyEstt2AbxpyLIDQ4VKOwGHCxgih+/Kp/UsM6asrxOfjbhsvLys1iz6cWgjoGT 5/5ye4HSFGoaRqm7wIVxh6+k74705iR3jUJ1h4rKKznPSdDi8R5RAGCmD9QFvdDk8ymS5Ir4wnB 4Lxs58F9vcU0X2ZCe1SDaQ9Ndl/PN0xojNIV5N/lhMyHBxlsbMDsCIw8aejM2oAKDJRKOhQX0oW mXDntUkvmSY4RUMiXI41PZR5SohJDj8lMpTwZOsOZZPt4FJwnZgDdnsl/ONUJ1HbxEhYdSbNxIA d9ivwgsrJYkC8agvlwnA== X-Google-Smtp-Source: AGHT+IE2HB4PNnNNZPoJgrmm/zoBzzLugjubCTHQBbs/Uafloy4/vUsHxeeEoDk1I+UDuJlRtAHv9Q== X-Received: by 2002:a05:6512:3dac:b0:586:7f:a141 with SMTP id 2adb3069b0e04-5906d88e732mr5437316e87.18.1760364899093; Mon, 13 Oct 2025 07:14:59 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:14:58 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:14:56 +0000 Subject: [PATCH 16/32] media: i2c: ov5675: Use %pe format specifier Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-ptr_err-v1-16-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./i2c/ov5675.c:1188:9-16: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/media/i2c/ov5675.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov5675.c b/drivers/media/i2c/ov5675.c index 30e27d39ee445c2603b8fecf7a1107969eb97df3..ea26df328189eef449ce121c0f62a4ef02631830 100644 --- a/drivers/media/i2c/ov5675.c +++ b/drivers/media/i2c/ov5675.c @@ -1184,8 +1184,8 @@ static int ov5675_get_hwcfg(struct ov5675 *ov5675) ov5675->xvclk = devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(ov5675->xvclk)) return dev_err_probe(dev, PTR_ERR(ov5675->xvclk), - "failed to get xvclk: %ld\n", - PTR_ERR(ov5675->xvclk)); + "failed to get xvclk: %pe\n", + ov5675->xvclk); xvclk_rate = clk_get_rate(ov5675->xvclk); if (xvclk_rate != OV5675_XVCLK_19_2) { -- 2.51.0.760.g7b8bcc2412-goog