From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD1B30AAAD for ; Mon, 13 Oct 2025 14:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364928; cv=none; b=V4QKuNRec5In8WzW3vbzHZ4iiOHyE8c2B4bG0OuaqF5qdEjgK4csAxIXHpmK1FuZIVSCOJ7zjVL3UsZ5SeZBbVj1y3vqZqsujt+nCW+QfV4ntlyciXTU6rFzMNQrGiQHCPDVQ1o+antiSdjJsBWP2seblkGOxP560q85axL/hlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364928; c=relaxed/simple; bh=5KNyjJbgRQNGFLo6ZpLtI2lNcxP1iC+T2TtMMI7Vg6Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H3ALdyna6FKNBnOLm+CY+2ZFM90A0fUiHjiImrDZ/IR3WqoAtpto4bHbSRseEHou2s7ARFDhYGwlefN8Bpk60Qwu4vU0bl+TzDqkESADWHjljNkyr+3wFveuZun3k2bfQ76ugGEL7L+xuJesEPs1/TT1h4p8O2g9vij6kVCQL6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dvCqoiLJ; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dvCqoiLJ" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-57a292a3a4bso5390575e87.3 for ; Mon, 13 Oct 2025 07:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364908; x=1760969708; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LGG/+lvAfLoFYTFsHBbdKee0g975J4ynYIjn3miRvz8=; b=dvCqoiLJBf6DG3qUA2rSV72cDJyjWceIVVnnv97NANVwnczp1nmtGnbFzb4DJzgvVs 7WsgWqky+a+U8YXdLRKeJdeHlGH6g83I7HXlxI23scDhiEx8xqYGGjGHW2tPfH1/xVDX Vn9DrvOPoUK3ZuFHGoQoC8OArj1hryav6RqYs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364908; x=1760969708; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LGG/+lvAfLoFYTFsHBbdKee0g975J4ynYIjn3miRvz8=; b=bVejbNeK5siAs+aKySt2gydemmROaVkSY+RsNVEeOmHf7ca8MVWG2yB4zCVynvmojB phT6w+UXv+s4vMXaDSY4OancJoCi3a3kanK1GxbnHLmomhq/nuOm97a9zg0Rs1V35T2q ouF+t3gglivsQMJ4S37Dc15p9Hpu4KFRQ2LC4GO8eoovsJ3m++lmVc8ey6WQ8g6OiPDn z8VphtR5CE8XitilpxFq6Zk/zbeNKG8AlTbhd0v6aVfC/6ak9BMarxMSG9xRM7A0fVAr uCisb5AuPoFGlmF+NuGI85Wx5y4nWJIaipwPCKsXbEg5P/mzP/7bnKvuG9cjSfuZKhUa 3AEw== X-Forwarded-Encrypted: i=1; AJvYcCW2Ay6UXofAqUrj1dSP1GtYcpFX8+UJyV+WhTz191WZx30RcoVFhbIBky5oGjQFPtlWn5s=@lists.linux.dev X-Gm-Message-State: AOJu0YwWKju+tWh1JX8mQJB3nYcKNJFedjunfj7yOaRmpeUL/1az/B9p y939crK4hkP8dpsCtoBz8+EV+rPYQ+oFiFeBG0nTCL4vMyDcWaJhXGG1Y68nF9WA2A== X-Gm-Gg: ASbGncv04HTrnfI8qXz0HRiMsBMGj/dLVpuUijTCkVzvdsg9gJmuBM3qnFEZbshQHqi yctSOSJJkuz8mhWEarCfi7WBEiXmvgo69UQejga51Pd3nXSrZ5St8Vlw4rHDCPFNgsqNav5+mP/ CfHJB81eR76b6BQMBwkvvcFDi1PttiWZ8+RU0HRkEEPob3Gq32MIb6eEKJ6z0pNGhjhAa36bjOZ Bo160+BEcunyByfycW8DMZHVGgTkU9rtwV2re+gEXclyxBBJ0RHpw9cECaVypAXqp2D5TaeqZhT KK4yVbCl8d6sXZ09r/HUe0Z3nPpITVuH06YdqJ76JNXLihZ6tFX3hSWfmipvGVzOFQP35IxaEjd zRjWEMDRyuyTNkIwvv9B4qrertdb3OIkm75KB//GxQstqsrH1cKyIZk65I3j+9B7eDi2T6oPzLN rAwQ2bbWR5x94d01uUczRRkoGiOnInBffcRS9ur6A= X-Google-Smtp-Source: AGHT+IHonGCa8by4IRlUhFwqne0G+xChLaB77A4Elu7KHX/ytkwCKxhNDSfo6zsqaOoV+Q8fGGx9SA== X-Received: by 2002:a05:6512:1093:b0:587:a4fa:1e50 with SMTP id 2adb3069b0e04-5906dae5b56mr5886844e87.41.1760364908274; Mon, 13 Oct 2025 07:15:08 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:15:07 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:15:12 +0000 Subject: [PATCH 32/32] media: staging/ipu7: Use %pe format specifier Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-ptr_err-v1-32-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./ipu7/ipu7-isys-csi-phy.c:311:23-30: WARNING: Consider using %pe to print PTR_ERR() ./ipu7/ipu7-isys-csi2.c:59:22-29: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/staging/media/ipu7/ipu7-isys-csi-phy.c | 4 ++-- drivers/staging/media/ipu7/ipu7-isys-csi2.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c index b8c5db7ae3009e16264d7aaca6d4d237c1402ab7..2d57178835188a44b002b38712437cbd551751a5 100644 --- a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c +++ b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c @@ -307,8 +307,8 @@ static int ipu7_isys_csi_ctrl_dids_config(struct ipu7_isys_csi2 *csi2, u32 id) pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity); if (IS_ERR(pad)) { - dev_warn(dev, "can't get remote source pad of %s (%ld)\n", - csi2->asd.sd.name, PTR_ERR(pad)); + dev_warn(dev, "can't get remote source pad of %s (%pe)\n", + csi2->asd.sd.name, pad); return PTR_ERR(pad); } diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi2.c b/drivers/staging/media/ipu7/ipu7-isys-csi2.c index 4023db4a6466dd57f0ac007847bdd74bcdf394f7..f34eabfe8a985f29fa48b4a8896a058fde2f2b2f 100644 --- a/drivers/staging/media/ipu7/ipu7-isys-csi2.c +++ b/drivers/staging/media/ipu7/ipu7-isys-csi2.c @@ -55,8 +55,8 @@ s64 ipu7_isys_csi2_get_link_freq(struct ipu7_isys_csi2 *csi2) src_pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity); if (IS_ERR(src_pad)) { dev_err(&csi2->isys->adev->auxdev.dev, - "can't get source pad of %s (%ld)\n", - csi2->asd.sd.name, PTR_ERR(src_pad)); + "can't get source pad of %s (%pe)\n", + csi2->asd.sd.name, src_pad); return PTR_ERR(src_pad); } -- 2.51.0.760.g7b8bcc2412-goog