imx.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Frank Li" <Frank.Li@nxp.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Antoni Pokusinski" <apokusinski01@gmail.com>,
	"Vasileios Amoiridis" <vassilisamir@gmail.com>,
	"Justin Weiss" <justin@justinweiss.com>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list
Date: Thu, 23 Oct 2025 18:17:38 +0100	[thread overview]
Message-ID: <20251023181738.00004253@huawei.com> (raw)
In-Reply-To: <0e00bb14-19c7-493a-9629-354bac3a273e@baylibre.com>

On Wed, 22 Oct 2025 12:03:27 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 10/22/25 11:41 AM, Frank Li wrote:
> > Some board designs connect vdd and vddio to the system power supply. Remove
> > these properties from the required list and make them optional, since
> > drivers/iio/pressure/mpl3115.c does not use them.
> > 
> > Fix below CHECK_DTBS warnings:
> > arch/arm64/boot/dts/freescale/imx8qm-mek.dtb: pressure-sensor@60 (fsl,mpl3115): 'vdd-supply' is a required property
> >         from schema $id: http://devicetree.org/schemas/iio/pressure/fsl,mpl3115.yaml#
> >   
> 
> Why not just add the required properties to the .dts file?

That would be the ideal. 

We had a long discussion a few years back around whether supplies like this
should be optional or not in dt-bindings. Conclusion (I think at Mark Brown's
suggestion) was that the rule should be if power is needed for the chip to
function they aren't optional in DT.

The driver doesn't necessarily do anything with them, though it probably
should and adding simple support is trivial. 

In a given downstream dts if people are happy to have the checks fail
then fallback regulators can be used but the binding shouldn't reflect
that bit of papering over missing supplies.

So no to this change. 

Jonathan

> 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> > index 2933c2e10695e..04703a01cf7af 100644
> > --- a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> > +++ b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> > @@ -47,8 +47,6 @@ properties:
> >  required:
> >    - compatible
> >    - reg
> > -  - vdd-supply
> > -  - vddio-supply
> >  
> >  additionalProperties: false
> >    
> 
> 


      reply	other threads:[~2025-10-23 17:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 16:41 [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list Frank Li
2025-10-22 17:00 ` Conor Dooley
2025-10-22 17:03 ` David Lechner
2025-10-23 17:17   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023181738.00004253@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=Frank.Li@nxp.com \
    --cc=andy@kernel.org \
    --cc=apokusinski01@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=imx@lists.linux.dev \
    --cc=jic23@kernel.org \
    --cc=justin@justinweiss.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=vassilisamir@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).