* [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list
@ 2025-10-22 16:41 Frank Li
2025-10-22 17:00 ` Conor Dooley
2025-10-22 17:03 ` David Lechner
0 siblings, 2 replies; 4+ messages in thread
From: Frank Li @ 2025-10-22 16:41 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Antoni Pokusinski,
Vasileios Amoiridis, Justin Weiss,
open list:IIO SUBSYSTEM AND DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Some board designs connect vdd and vddio to the system power supply. Remove
these properties from the required list and make them optional, since
drivers/iio/pressure/mpl3115.c does not use them.
Fix below CHECK_DTBS warnings:
arch/arm64/boot/dts/freescale/imx8qm-mek.dtb: pressure-sensor@60 (fsl,mpl3115): 'vdd-supply' is a required property
from schema $id: http://devicetree.org/schemas/iio/pressure/fsl,mpl3115.yaml#
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
index 2933c2e10695e..04703a01cf7af 100644
--- a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
+++ b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
@@ -47,8 +47,6 @@ properties:
required:
- compatible
- reg
- - vdd-supply
- - vddio-supply
additionalProperties: false
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list
2025-10-22 16:41 [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list Frank Li
@ 2025-10-22 17:00 ` Conor Dooley
2025-10-22 17:03 ` David Lechner
1 sibling, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2025-10-22 17:00 UTC (permalink / raw)
To: Frank Li
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Antoni Pokusinski,
Vasileios Amoiridis, Justin Weiss,
open list:IIO SUBSYSTEM AND DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
On Wed, Oct 22, 2025 at 12:41:51PM -0400, Frank Li wrote:
> Some board designs connect vdd and vddio to the system power supply. Remove
> these properties from the required list and make them optional, since
> drivers/iio/pressure/mpl3115.c does not use them.
That just reads as if the supplies are still required, just the source
of the power has changed.
>
> Fix below CHECK_DTBS warnings:
> arch/arm64/boot/dts/freescale/imx8qm-mek.dtb: pressure-sensor@60 (fsl,mpl3115): 'vdd-supply' is a required property
> from schema $id: http://devicetree.org/schemas/iio/pressure/fsl,mpl3115.yaml#
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> index 2933c2e10695e..04703a01cf7af 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> @@ -47,8 +47,6 @@ properties:
> required:
> - compatible
> - reg
> - - vdd-supply
> - - vddio-supply
>
> additionalProperties: false
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list
2025-10-22 16:41 [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list Frank Li
2025-10-22 17:00 ` Conor Dooley
@ 2025-10-22 17:03 ` David Lechner
2025-10-23 17:17 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: David Lechner @ 2025-10-22 17:03 UTC (permalink / raw)
To: Frank Li, Jonathan Cameron, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Antoni Pokusinski,
Vasileios Amoiridis, Justin Weiss,
open list:IIO SUBSYSTEM AND DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 10/22/25 11:41 AM, Frank Li wrote:
> Some board designs connect vdd and vddio to the system power supply. Remove
> these properties from the required list and make them optional, since
> drivers/iio/pressure/mpl3115.c does not use them.
>
> Fix below CHECK_DTBS warnings:
> arch/arm64/boot/dts/freescale/imx8qm-mek.dtb: pressure-sensor@60 (fsl,mpl3115): 'vdd-supply' is a required property
> from schema $id: http://devicetree.org/schemas/iio/pressure/fsl,mpl3115.yaml#
>
Why not just add the required properties to the .dts file?
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> index 2933c2e10695e..04703a01cf7af 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> @@ -47,8 +47,6 @@ properties:
> required:
> - compatible
> - reg
> - - vdd-supply
> - - vddio-supply
>
> additionalProperties: false
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list
2025-10-22 17:03 ` David Lechner
@ 2025-10-23 17:17 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2025-10-23 17:17 UTC (permalink / raw)
To: David Lechner
Cc: Frank Li, Jonathan Cameron, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Antoni Pokusinski,
Vasileios Amoiridis, Justin Weiss,
open list:IIO SUBSYSTEM AND DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Wed, 22 Oct 2025 12:03:27 -0500
David Lechner <dlechner@baylibre.com> wrote:
> On 10/22/25 11:41 AM, Frank Li wrote:
> > Some board designs connect vdd and vddio to the system power supply. Remove
> > these properties from the required list and make them optional, since
> > drivers/iio/pressure/mpl3115.c does not use them.
> >
> > Fix below CHECK_DTBS warnings:
> > arch/arm64/boot/dts/freescale/imx8qm-mek.dtb: pressure-sensor@60 (fsl,mpl3115): 'vdd-supply' is a required property
> > from schema $id: http://devicetree.org/schemas/iio/pressure/fsl,mpl3115.yaml#
> >
>
> Why not just add the required properties to the .dts file?
That would be the ideal.
We had a long discussion a few years back around whether supplies like this
should be optional or not in dt-bindings. Conclusion (I think at Mark Brown's
suggestion) was that the rule should be if power is needed for the chip to
function they aren't optional in DT.
The driver doesn't necessarily do anything with them, though it probably
should and adding simple support is trivial.
In a given downstream dts if people are happy to have the checks fail
then fallback regulators can be used but the binding shouldn't reflect
that bit of papering over missing supplies.
So no to this change.
Jonathan
>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> > index 2933c2e10695e..04703a01cf7af 100644
> > --- a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> > +++ b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml
> > @@ -47,8 +47,6 @@ properties:
> > required:
> > - compatible
> > - reg
> > - - vdd-supply
> > - - vddio-supply
> >
> > additionalProperties: false
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-23 17:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 16:41 [PATCH 1/1] dt-bindings: iio: pressure: Remove vdd-supply and vddio-supply from required list Frank Li
2025-10-22 17:00 ` Conor Dooley
2025-10-22 17:03 ` David Lechner
2025-10-23 17:17 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).