From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD5BF1DF738 for ; Sun, 26 Oct 2025 18:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761504592; cv=none; b=iHjc1KOGU9QS/SbVqaoBzvQJSo1FExI7Bt1ZUxiKf1Qmx8geYMBq+RwNDjrRLqxOUczd8VC+rlXHrqOJiqIc7fOSuRQHgF23Up1ZxZD7dWHZ6E1RsJfQYEevuNRc5XxFQ/E4vdbcfLky409/UOE/u3Y9x2k2RtCFvwcqGE/o23k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761504592; c=relaxed/simple; bh=SBAlHQr01XhpEUC4KPUxRR+yFK/fqz9GLMF8BAiidW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qyPz5kHIv4SstnxFAOZe3/N/xSPUdzrqTo+0JVU9MxaJvLmJ4gMQnvta4NQ+I0dKSM3ao8LsvIxCme0S3tGvOMIiHBL7X5AvhktccR9AiBAEWhP92eEVpnNWFYXD+fVPlEExGDwPma4ybp1glLFC9PsPF6tgEgS+3nRDxmARxvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=KAEKu/pz; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KAEKu/pz" Received: from pendragon.ideasonboard.com (82-203-161-16.bb.dnainternet.fi [82.203.161.16]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9F9C51BA0; Sun, 26 Oct 2025 19:48:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761504480; bh=SBAlHQr01XhpEUC4KPUxRR+yFK/fqz9GLMF8BAiidW0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KAEKu/pzrR2WdA3jwWhEjVL5n1ck+bdI13daW2T+hf2IXSz4lp7mK6bjk87D95lTY ojJ51hPyK2y5agMIOYGPVh3hZZYDdsKJZXbwSbvFUSECqEWIJpbHKYKhM8SQHlzmEP mTa3Ie507Yen15YtA1S2ELcEXk7ASSQn0EhXFrZM= Date: Sun, 26 Oct 2025 20:49:33 +0200 From: Laurent Pinchart To: Frank Li Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , imx@lists.linux.dev Subject: Re: [PATCH v2 1/1] media: dt-bindings: video-interfaces: add video-interfaces.h information Message-ID: <20251026184933.GB1025@pendragon.ideasonboard.com> References: <20251021154922.2874390-1-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251021154922.2874390-1-Frank.Li@nxp.com> Hi Frank, Thank you for the patch. On Tue, Oct 21, 2025 at 11:49:22AM -0400, Frank Li wrote: > Mention include/dt-bindings/media/video-interfaces.h in descriptions to > help avoid use hardcode in dts. > > Signed-off-by: Frank Li > --- > changes in v2 > - update commit message "mention ..." > - use full path include/dt-bindings/media/video-interfaces.h > --- > Documentation/devicetree/bindings/media/video-interfaces.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml > index 038e85b45befa..6ed4695cacf7e 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.yaml > +++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml > @@ -95,7 +95,7 @@ properties: > - 6 # BT.656 > - 7 # DPI I wondered if we should reference the macros here as well: enum: - 1 # MEDIA_BUS_TYPE_CSI2_CPHY - 2 # MEDIA_BUS_TYPE_CSI1 - 3 # MEDIA_BUS_TYPE_CCP2 - 4 # MEDIA_BUS_TYPE_CSI2_DPHY - 5 # MEDIA_BUS_TYPE_PARALLEL - 6 # MEDIA_BUS_TYPE_BT656 - 7 # DPI (Annoyingly we don't have a macro for DPI.) This can be done separately if desired, so Reviewed-by: Laurent Pinchart > description: > - Data bus type. > + Data bus type. See include/dt-bindings/media/video-interfaces.h. > > bus-width: > $ref: /schemas/types.yaml#/definitions/uint32 > @@ -229,7 +229,7 @@ properties: > Imaging. The length of the array must be the same length as the > data-lanes property. If the line-orders property is omitted, the value > shall be interpreted as 0 (ABC). This property is valid for CSI-2 C-PHY > - busses only. > + busses only. See include/dt-bindings/media/video-interfaces.h. > > strobe: > $ref: /schemas/types.yaml#/definitions/uint32 -- Regards, Laurent Pinchart