From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFEFE1D514B for ; Sun, 26 Oct 2025 21:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761512862; cv=none; b=ndNsAZwp3ySjt6YoxThDXGcNlFjVW9XjZ3f3Nozm/wGrEAIHO836BiNeElnZyturVa5xCzfHkIAcZMyt5R7Opz1SUlRwcGIQRl2IndtsN34l9dhq82wA7uottjCRK6ErHKjTW7P7b+fM8+ppz3CY5GvmZWnn/2Jq1KQEmovS8tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761512862; c=relaxed/simple; bh=FX3PJZ4Zx7AunoIvtIIT5LbQdAgzbExv6kJ6VBmjW8M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OZDfY9jtopMc/OOfcqWxvvAw0dR5Ym0zZON1o/g7ckuHTg0jYr7NnksAMuDRsJeVhSPzOrtASozLOvObCYM4Yat0JABmc+oO38VnCN9yRK68PQfs6eTl75/A9OSn658DER/wba5gdBQLGtlfxxBotMj0lPJ8oNo7s13jPhIoAas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=OcSMQaL2; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OcSMQaL2" Received: from pendragon.ideasonboard.com (82-203-161-16.bb.dnainternet.fi [82.203.161.16]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 96811129; Sun, 26 Oct 2025 22:05:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761512751; bh=FX3PJZ4Zx7AunoIvtIIT5LbQdAgzbExv6kJ6VBmjW8M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OcSMQaL2aTruoSuT8i+ItTMMlx5+YuMA01qolWkx56SEliWHlNkl2R0pUC2imvG7m HF5VieJN/VQqu0Jv9+qJcgVdeK07SgxVcaRYUG2k7qlpzucdyV8Dzy5s8rvO1mWFuy 8trOxSaexrIuaxpwQ+bwHlUD61vKOimvBvz6F2x8= Date: Sun, 26 Oct 2025 23:07:24 +0200 From: Laurent Pinchart To: Isaac Scott Cc: mchehab@kernel.org, rmfrfs@gmail.com, martink@posteo.de, kernel@puri.sm, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Frank.Li@nxp.com Subject: Re: [PATCH v5 3/4] media: imx-mipi-csis: Add num_data_lanes to mipi_csis_device Message-ID: <20251026210724.GE1025@pendragon.ideasonboard.com> References: <20251022102228.275627-1-isaac.scott@ideasonboard.com> <20251022102228.275627-4-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251022102228.275627-4-isaac.scott@ideasonboard.com> Hi Isaac, Thank you for the patch. On Wed, Oct 22, 2025 at 11:22:27AM +0100, Isaac Scott wrote: > Add the num_data_lanes field to the mipi_csis_device struct, and set it > equal to csis->bus.num_data_lanes. This is in preparation to support > cases when the data lanes actively used differs from the maximum > supported data lanes. > > No functional changes intended by this commit. > > Signed-off-by: Isaac Scott Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-mipi-csis.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c > index 7c2a679dca2e..838a1ad123b5 100644 > --- a/drivers/media/platform/nxp/imx-mipi-csis.c > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c > @@ -351,6 +351,8 @@ struct mipi_csis_device { > u32 hs_settle; > u32 clk_settle; > > + unsigned int num_data_lanes; > + > spinlock_t slock; /* Protect events */ > struct mipi_csis_event events[MIPI_CSIS_NUM_EVENTS]; > struct dentry *debugfs_root; > @@ -573,7 +575,7 @@ static void mipi_csis_system_enable(struct mipi_csis_device *csis, int on) > val = mipi_csis_read(csis, MIPI_CSIS_DPHY_CMN_CTRL); > val &= ~MIPI_CSIS_DPHY_CMN_CTRL_ENABLE; > if (on) { > - mask = (1 << (csis->bus.num_data_lanes + 1)) - 1; > + mask = (1 << (csis->num_data_lanes + 1)) - 1; > val |= (mask & MIPI_CSIS_DPHY_CMN_CTRL_ENABLE); > } > mipi_csis_write(csis, MIPI_CSIS_DPHY_CMN_CTRL, val); > @@ -623,7 +625,7 @@ static int mipi_csis_calculate_params(struct mipi_csis_device *csis, > > /* Calculate the line rate from the pixel rate. */ > link_freq = v4l2_get_link_freq(csis->source.pad, csis_fmt->width, > - csis->bus.num_data_lanes * 2); > + csis->num_data_lanes * 2); > if (link_freq < 0) { > dev_err(csis->dev, "Unable to obtain link frequency: %d\n", > (int)link_freq); > @@ -668,7 +670,7 @@ static void mipi_csis_set_params(struct mipi_csis_device *csis, > const struct v4l2_mbus_framefmt *format, > const struct csis_pix_format *csis_fmt) > { > - int lanes = csis->bus.num_data_lanes; > + int lanes = csis->num_data_lanes; > u32 val; > > val = mipi_csis_read(csis, MIPI_CSIS_CMN_CTRL); > @@ -1366,8 +1368,9 @@ static int mipi_csis_async_register(struct mipi_csis_device *csis) > } > > csis->bus = vep.bus.mipi_csi2; > + csis->num_data_lanes = csis->bus.num_data_lanes; > > - dev_dbg(csis->dev, "data lanes: %d\n", csis->bus.num_data_lanes); > + dev_dbg(csis->dev, "max data lanes: %d\n", csis->bus.num_data_lanes); > dev_dbg(csis->dev, "flags: 0x%08x\n", csis->bus.flags); > > asd = v4l2_async_nf_add_fwnode_remote(&csis->notifier, ep, -- Regards, Laurent Pinchart