From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 624EF224FA for ; Sun, 26 Oct 2025 22:04:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761516296; cv=none; b=HiAf4a3HpnctIZBwVuKT/FmeqnAIJOFtpb8++HEpLubben6Y3cTrSs0D4AOlpU1trtw+YuIWpm9QdP6xhCXCXzaLSfNZNy03y8GFJK7trJdi9d9Mz/H/Sern5BmOfbV4KbTqwtxz8Z6qykJfuvfOzoxe1XQkfoT/GcY2jorvbOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761516296; c=relaxed/simple; bh=QXwwajsozN6n52An7A1QJ6FAATGmuWpgmNPS6tMrYos=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sMXk5Qmy3tu0hQPh/kDE7UzObHxHvDXPxf0p34Dnt4yRJyHKg8QTWlOfq01dFvZCJ16FYCfA61h81k1VSwz+v246VvOEY4e9ZPQ+GPK3MrMq4Fq+D+6B2uDVICiA3VaLL1oxXQ2Hk7Gdx4D6nCbiTh+MRuVXWK2D/T3Fgz1dSQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=a8Qszwq0; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="a8Qszwq0" Received: from pendragon.ideasonboard.com (82-203-161-16.bb.dnainternet.fi [82.203.161.16]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 16FBA1F0E; Sun, 26 Oct 2025 23:03:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761516185; bh=QXwwajsozN6n52An7A1QJ6FAATGmuWpgmNPS6tMrYos=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a8Qszwq0/C+49obn6G7bQx8qm/+xz2LGOKY9U/QnB1L6FDKfytKEXDR0wZ5c+qhEv bATLGKhxcL1J2VWMrE0BL8CMEVOtJyg3+yDEQVDxhTGj5/FyAuxWgE+97i1Q+NqsD/ UC7aqdd2YoMRsNlevHl5e+otCs5ovLhCfNZpoycw= Date: Mon, 27 Oct 2025 00:04:38 +0200 From: Laurent Pinchart To: Frank Li Cc: Guoniu Zhou , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Guoniu Zhou Subject: Re: [PATCH 1/3] media: dt-bindings: nxp,imx8-isi: Add i.MX95 ISI compatible string Message-ID: <20251026220438.GG13023@pendragon.ideasonboard.com> References: <20251024-isi_imx95-v1-0-3ad1af7c3d61@nxp.com> <20251024-isi_imx95-v1-1-3ad1af7c3d61@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Oct 24, 2025 at 09:34:14AM -0400, Frank Li wrote: > On Fri, Oct 24, 2025 at 05:46:52PM +0800, Guoniu Zhou wrote: > > From: Guoniu Zhou > > > > The ISI module on i.MX95 supports up to eight channels and four link > > sources to obtain the image data for processing in its pipelines. It > > can process up to eight image sources at the same time. > > > > Signed-off-by: Guoniu Zhou > > --- > > .../devicetree/bindings/media/nxp,imx8-isi.yaml | 26 +++++++++++++++++++++- > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > > index f43b91984f0152fbbcf80db3b3bbad7e8ad6c11e..eaab98ecf343a2cd3620f7469c016c3955d37406 100644 > > --- a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > > @@ -23,6 +23,7 @@ properties: > > - fsl,imx8mp-isi > > - fsl,imx8ulp-isi > > - fsl,imx93-isi > > + - fsl,imx95-isi > > > > reg: > > maxItems: 1 > > @@ -49,7 +50,7 @@ properties: > > interrupts: > > description: Processing pipeline interrupts, one per pipeline > > minItems: 1 > > - maxItems: 2 > > + maxItems: 8 > > > > power-domains: > > maxItems: 1 > > @@ -109,6 +110,29 @@ allOf: > > - port@0 > > - port@1 > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: fsl,imx95-isi > > + then: > > + properties: > > + interrupts: > > + maxItems: 8 > > should minItems: 8 because you already limit maxItems at top; As far as I understand, when no "items" are specified, minItems defaults to 1, and maxItems defaults to minItems (if specified) or 0 (if minItems is not specified). This is implemented in dtschema/lib.py of https://github.com/devicetree-org/dt-schema.git. Then, in dtschema/fixups.py, if only one of minItems or maxItems is specified, the other one is set to the same value. I believe relying on this is frowned upon by the DT maintainers. We could specify minItems only here, as the top-level constraint will ensure we don't go over 8. That's not very future-proof though, so I think specifying both minItems and maxItems would be best. Confirmation from a DT maintainer would be appreciated. The fsl,imx8mp-isi block above should then be fixed. It currently only has maxItems set, minItems should be set to 2 as well. > > + ports: > > + properties: > > + port@0: > > + description: Pixel Link Slave 0 > > + port@1: > > + description: Pixel Link Slave 1 > > + port@2: > > + description: MIPI CSI-2 RX 0 > > + port@3: > > + description: MIPI CSI-2 RX 1 > > + required: > > + - port@2 > > + - port@3 > > + > > else > properties: > interrupts: > maxItem: 2 > > to keep the same restriction for existed compatible string. We already specify the number of interrupts in two separate conditional blocks above, with any else statement (for all but fsl,imx8mp-isi first, and then for fsl,imx8mp-isi). Both specify maxItems, so I think we're fine. > > additionalProperties: false > > > > examples: -- Regards, Laurent Pinchart