From: Liu Ying <victor.liu@nxp.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Dmitry Baryshkov <lumag@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut@mailbox.org>,
Liu Ying <victor.liu@nxp.com>, Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v5 11/13] drm/imx: dc-lb: Drop initial primary and secondary input selections
Date: Mon, 27 Oct 2025 16:47:01 +0800 [thread overview]
Message-ID: <20251027-imx8-dc-prefetch-v5-11-4ecb6c6d4941@nxp.com> (raw)
In-Reply-To: <20251027-imx8-dc-prefetch-v5-0-4ecb6c6d4941@nxp.com>
It's unnecessary to set initial primary and secondary input selections
because KMS driver would do that when doing atomic commits. Drop the
selections. This is needed as a preparation for reading LayerBlend
secondary input selection when trying to disable CRTC at boot in an
upcoming commit.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v2:
- Collect Frank's R-b tag.
---
drivers/gpu/drm/imx/dc/dc-lb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/imx/dc/dc-lb.c b/drivers/gpu/drm/imx/dc/dc-lb.c
index 8622efac3f3d566ee6eeef33d90e2e26899f6502..4776e54439fb3df42075667d6fc2971da590662a 100644
--- a/drivers/gpu/drm/imx/dc/dc-lb.c
+++ b/drivers/gpu/drm/imx/dc/dc-lb.c
@@ -254,8 +254,6 @@ int dc_lb_get_id(struct dc_lb *lb)
void dc_lb_init(struct dc_lb *lb)
{
- dc_lb_pec_dynamic_prim_sel(lb, LINK_ID_NONE);
- dc_lb_pec_dynamic_sec_sel(lb, LINK_ID_NONE);
dc_lb_pec_clken(lb, CLKEN_DISABLE);
dc_lb_shdldsel(lb, BOTH);
dc_lb_shdtoksel(lb, BOTH);
--
2.34.1
next prev parent reply other threads:[~2025-10-27 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 8:46 [PATCH v5 00/13] drm/imx: dc: Use prefetch engine Liu Ying
2025-10-27 8:46 ` [PATCH v5 01/13] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding Liu Ying
2025-10-27 8:46 ` [PATCH v5 02/13] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding Liu Ying
2025-10-27 8:46 ` [PATCH v5 03/13] drm/imx: dc-fu: Fix dimensions Liu Ying
2025-10-27 8:46 ` [PATCH v5 04/13] drm/imx: dc-crtc: Disable at boot Liu Ying
2025-10-27 8:46 ` [PATCH v5 05/13] drm/imx: dc: Add PRG support Liu Ying
2025-10-27 8:46 ` [PATCH v5 06/13] drm/imx: dc: Add DPR channel support Liu Ying
2025-10-27 8:46 ` [PATCH v5 07/13] drm/imx: dc: Use TCON operation mode Liu Ying
2025-10-27 8:46 ` [PATCH v5 08/13] drm/imx: dc-ed: Support getting source selection Liu Ying
2025-10-27 8:46 ` [PATCH v5 09/13] drm/imx: dc-lb: Support getting secondary input selection Liu Ying
2025-10-27 8:47 ` [PATCH v5 10/13] drm/imx: dc-ed: Drop initial source selection Liu Ying
2025-10-27 8:47 ` Liu Ying [this message]
2025-10-27 8:47 ` [PATCH v5 12/13] drm/imx: dc-fu: Get DPR channel Liu Ying
2025-10-27 8:47 ` [PATCH v5 13/13] drm/imx: dc: Use prefetch engine Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027-imx8-dc-prefetch-v5-11-4ecb6c6d4941@nxp.com \
--to=victor.liu@nxp.com \
--cc=Frank.Li@nxp.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marek.vasut@mailbox.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).