From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F29E26463A for ; Mon, 27 Oct 2025 09:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761558936; cv=none; b=ZYuDVB9Fgs0ZYWuYXiZ/9L3CbJGGtjuwwH4obdPqUYMxROMA+0IkgD3BMh941FJ7mHQNSPoaxa5DKHLNgcQ6vH72w8E33mFMBhli7W9y+rlmrv7bqAwkF2ijiWKuT11y1m/KHew1VIFa4YAzpUXKho77ITW79T90ETXLcYZs+ss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761558936; c=relaxed/simple; bh=8RzIiPz9xOCm407auoA7e2dNUBBDbF25UtoP0pWX+Dk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SlwNbqZzIsIpyAN6WAo77uULAGA1w4wiGWsLPT6vcJMMFexCowclspsV8F5aDmJl+UCGViYLlTQ6lFfimOsRsUgyilbBTBBhUU+d4YagrqoQ5ajx9imqm5HaG1y6jwDuphaGrAkwPBxqo6h2pvL6QiOTKuW5yxhjjJH/3VC37rU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=PDLKMdYt; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PDLKMdYt" Received: from pendragon.ideasonboard.com (unknown [193.209.96.36]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 57AE31661; Mon, 27 Oct 2025 10:53:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761558824; bh=8RzIiPz9xOCm407auoA7e2dNUBBDbF25UtoP0pWX+Dk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PDLKMdYt1C/3C4fcJR8kOHsTcT3x9RdIFNrLPubQoDvb5jspOjsaXCyXDMkl9oYiF Apy10haJGbrecedgzqXqZH2QCk+6E1oerm4n4vHSxUBkPnj0xobXjGOD5MOFa5NQVt pQnS6YsUD9wfpyJWtR4/O4dQE9mODOUWaJwQSoQ4= Date: Mon, 27 Oct 2025 11:55:18 +0200 From: Laurent Pinchart To: "Russell King (Oracle)" Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Daniel Scally , Kieran Bingham , Stefan Klug , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , Emanuele Ghidoli Subject: Re: [PATCH] arm64: dts: imx8mp-debix-model-a: Disable EEE for 1000T Message-ID: <20251027095518.GD1544@pendragon.ideasonboard.com> References: <20251026122905.29028-1-laurent.pinchart@ideasonboard.com> <20251027093346.GB1544@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Mon, Oct 27, 2025 at 09:45:54AM +0000, Russell King (Oracle) wrote: > On Mon, Oct 27, 2025 at 11:33:46AM +0200, Laurent Pinchart wrote: > > On Mon, Oct 27, 2025 at 09:07:32AM +0000, Russell King (Oracle) wrote: > > > On Sun, Oct 26, 2025 at 02:29:04PM +0200, Laurent Pinchart wrote: > > > > Energy Efficient Ethernet (EEE) is broken at least for 1000T on the EQOS > > > > (DWMAC) interface. When connected to an EEE-enabled peer, the ethernet > > > > devices produces an interrupts storm. Disable EEE support to fix it. > > > > > > As this is the second problem that has been reported recently, please > > > bisect the conversion of stmmac to phylink managed EEE support and see > > > whether there is anything in that which is causing this. > > > > Emanuele Ghidoli has bisected this to commit 2c81f3357136 ("net: stmmac: > > convert to phylink PCS support"), as reported in [1]. I can test that > > commit and the commit just before tonight. > > > > [1] https://lore.kernel.org/all/341f56de-9dde-4c44-9542-b523e1917dcb@gmail.com/ > > As you will notice in that thread, I have responded to it last week, so > I am well aware of it. I am also well aware of the claims Emanuele made > in his commit description are demonstrably false. > > That's not to say the commit isn't a problem, but the explanation of > why it's a problem doesn't make sense right now, and thus what needs to > be done to fix it is unknown. > > I don't think going around disabling EEE on individual platforms is the > right approach. I fully agree with you, seeing how eee-broken-1000t spread on many i.MX8MP DT sources raised a red cargo-cult flag. I didn't have the knowledge to properly diagnose and fix this myself, hence this patch, hoping someone more knowledgeable than me could help. Based on the replies received so far, it seems I was right to be hopeful :-) I'll perform more tests tonight, printing the interrupt status values as you requested in a separate e-mail. -- Regards, Laurent Pinchart