From: Maud Spierings via B4 Relay <devnull+maudspierings.gocontroll.com@kernel.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Maud Spierings <maudspierings@gocontroll.com>
Subject: [PATCH v3 2/6] regulator: bd718x7: Fix voltages scaled by resistor divider
Date: Thu, 30 Oct 2025 07:35:38 +0100 [thread overview]
Message-ID: <20251030-mini_iv-v3-2-ef56c4d9f219@gocontroll.com> (raw)
In-Reply-To: <20251030-mini_iv-v3-0-ef56c4d9f219@gocontroll.com>
From: Maud Spierings <maudspierings@gocontroll.com>
The .min_sel and .max_sel fields remained uninitialized in the new
linear_range, causing an error further down the line. Copy the old
values of these fields to the new one as they represent the range of
register values, which does not change.
Fixes: d2ad981151b3a ("regulator: bd718x7: Support external connection to scale voltages")
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
drivers/regulator/bd718x7-regulator.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/regulator/bd718x7-regulator.c b/drivers/regulator/bd718x7-regulator.c
index 022d98f3c32a2..ea9c4058ee6a5 100644
--- a/drivers/regulator/bd718x7-regulator.c
+++ b/drivers/regulator/bd718x7-regulator.c
@@ -1613,6 +1613,8 @@ static int setup_feedback_loop(struct device *dev, struct device_node *np,
step /= r1;
new[j].min = min;
+ new[j].min_sel = desc->linear_ranges[j].min_sel;
+ new[j].max_sel = desc->linear_ranges[j].max_sel;
new[j].step = step;
dev_dbg(dev, "%s: old range min %d, step %d\n",
--
2.51.2
next prev parent reply other threads:[~2025-10-30 6:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 6:35 [PATCH v3 0/6] arm64: dts: freescale: add support for the GOcontroll Moduline IV/Mini Maud Spierings via B4 Relay
2025-10-30 6:35 ` [PATCH v3 1/6] dt-bindings: arm: fsl: Add " Maud Spierings via B4 Relay
2025-10-30 18:34 ` Conor Dooley
2025-10-31 6:46 ` Maud Spierings
2025-10-30 6:35 ` Maud Spierings via B4 Relay [this message]
2025-10-30 8:55 ` [PATCH v3 2/6] regulator: bd718x7: Fix voltages scaled by resistor divider Matti Vaittinen
2025-10-30 6:35 ` [PATCH v3 3/6] arm64: dts: imx8mm: Add pinctrl config definitions Maud Spierings via B4 Relay
2025-10-30 6:35 ` [PATCH v3 4/6] arm64: dts: freescale: add Ka-Ro Electronics tx8m-1610 COM Maud Spierings via B4 Relay
2025-10-30 10:04 ` Matti Vaittinen
2025-10-30 6:35 ` [PATCH v3 5/6] arm64: dts: freescale: Add the GOcontroll Moduline IV Maud Spierings via B4 Relay
2025-10-30 6:35 ` [PATCH v3 6/6] arm64: dts: freescale: Add the GOcontroll Moduline Mini Maud Spierings via B4 Relay
2025-10-30 14:20 ` (subset) [PATCH v3 0/6] arm64: dts: freescale: add support for the GOcontroll Moduline IV/Mini Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030-mini_iv-v3-2-ef56c4d9f219@gocontroll.com \
--to=devnull+maudspierings.gocontroll.com@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maudspierings@gocontroll.com \
--cc=mazziesaccount@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox