From: Michael Tretter <m.tretter@pengutronix.de>
To: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Frank Li <Frank.Li@nxp.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Fabio Estevam <festevam@gmail.com>
Cc: linux-media@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 3/3] media: imx-csi: use media_pad_is_streaming helper
Date: Fri, 07 Nov 2025 11:16:35 +0100 [thread overview]
Message-ID: <20251107-media-imx-cleanup-v1-3-f82a693c28f4@pengutronix.de> (raw)
In-Reply-To: <20251107-media-imx-cleanup-v1-0-f82a693c28f4@pengutronix.de>
The media_pad_is_streaming helper is explicitly for checking, if a pad
has been started with media_pipeline_start. Use it instead of relying on
the implicit knowledge, that a pad that has a pipeline is streaming.
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
drivers/staging/media/imx/imx-media-utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
index 6d69f69c16c1..4ea9b3fc59d0 100644
--- a/drivers/staging/media/imx/imx-media-utils.c
+++ b/drivers/staging/media/imx/imx-media-utils.c
@@ -774,7 +774,7 @@ int imx_media_pipeline_set_stream(struct imx_media_dev *imxmd,
__media_pipeline_stop(pad);
} else {
v4l2_subdev_call(sd, video, s_stream, 0);
- if (media_pad_pipeline(pad))
+ if (media_pad_is_streaming(pad))
__media_pipeline_stop(pad);
}
--
2.47.3
next prev parent reply other threads:[~2025-11-07 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 10:16 [PATCH 0/3] media: imx-csi: cleanup media pipeline start Michael Tretter
2025-11-07 10:16 ` [PATCH 1/3] media: imx-csi: move media_pipeline to video device Michael Tretter
2025-11-07 10:27 ` Philipp Zabel
2025-11-07 16:10 ` Frank Li
2025-11-07 10:16 ` [PATCH 2/3] media: imx-csi: explicitly start media pipeline on pad 0 Michael Tretter
2025-11-07 10:28 ` Philipp Zabel
2025-11-07 16:12 ` Frank Li
2025-11-07 10:16 ` Michael Tretter [this message]
2025-11-07 10:28 ` [PATCH 3/3] media: imx-csi: use media_pad_is_streaming helper Philipp Zabel
2025-11-07 16:14 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107-media-imx-cleanup-v1-3-f82a693c28f4@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).