Re: [PATCH v1 1/6] media: imx-mipi-csis: Add VC-related register fields

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Fri, Nov 07, 2025 at 11:19:53AM -0500, Frank Li wrote:
> On Fri, Nov 07, 2025 at 03:58:08AM +0200, Laurent Pinchart wrote:
> > The CMN_CTRL and ISPCFG registers have fiels related to virtual channel
> > handling. In CMN_CTRL, the INTERLEAVE_MODE field is 2 bits wide, and
> > controls filtering by DT, VC or both. The VC number is then set in the
> > ISPCFG.VIRTUAL_CHANNEL field.
> >
> > Expand the definition of the register macros to support those features,
> > and set the VC ID to 0 explicitly instead of relying on the default
> > register value. This prepares for VC filtering but does not modify the
> > driver's behaviour.
> >
> > While at it, use GENMASK in the last few register mask macros that don't
> > use it.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  drivers/media/platform/nxp/imx-mipi-csis.c | 19 ++++++++++++++++---
> >  1 file changed, 16 insertions(+), 3 deletions(-)
> >
> ...
> >
> >  	val = mipi_csis_read(csis, MIPI_CSIS_CMN_CTRL);
> > -	val &= ~MIPI_CSIS_CMN_CTRL_LANE_NUMBER_MASK;
> > +	val &= ~(MIPI_CSIS_CMN_CTRL_LANE_NUMBER_MASK |
> > +		 MIPI_CSIS_CMN_CTRL_INTERLEAVE_MODE_MASK);
> > +
> >  	val |= MIPI_CSIS_CMN_CTRL_LANE_NUMBER(lanes - 1);
> > +
> >  	if (csis->info->version == MIPI_CSIS_V3_3)
> >  		val |= MIPI_CSIS_CMN_CTRL_INTERLEAVE_MODE_DT;
> > +
> 
> above two empty line is not related this patch

It's just a matter of giving the code more room to breathe. I can move
them to patch 6/6 if you prefer.

> >  	mipi_csis_write(csis, MIPI_CSIS_CMN_CTRL, val);
> >
> >  	__mipi_csis_set_format(csis, format, csis_fmt);

-- 
Regards,

Laurent Pinchart