From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C33F52F5A1A for ; Wed, 19 Nov 2025 04:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526207; cv=none; b=DW0nzBCzooI4/ZNqQ81QYtyp2FSgoovvDonW4LDAlpvmzkpWNAlLt15jxtIlhDTMuAiBYB409vG1T+n0Z2mrHDH9EvoSCoe31yf+ln82KNfZII7e/k8XVtvLEKYKNYy2dgu8QOkIBDguUhNFpcBsS+jfEaCBmRvxfmu9Klsl2ZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526207; c=relaxed/simple; bh=9Ebh3zjHTAH1FvI3YKXROgZAf1jvykzloaAHjJr46O8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XPog4ialWhkTyQy8fleKz3838G+VrcBQpL1ggJ7O1EEXstlUfWC2DXV4FPQocNquhFy1mV2/2VqibjsryBQAJzuWLSUlaOsxiJ7RaLRQBJ/QOOhEuQiPwv1XYdX/6S1xArX3nNkuwPvC1N6trDYod3UuzyZboNSyQ7OezNXFO3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=qusI2sob; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qusI2sob" Received: from pendragon.ideasonboard.com (unknown [205.220.129.225]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 201FBDD9; Wed, 19 Nov 2025 05:21:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763526080; bh=9Ebh3zjHTAH1FvI3YKXROgZAf1jvykzloaAHjJr46O8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qusI2sobNHdWWnh8sMcryOCL2C4GuA7ZNMA2V4K3VjcSQcoFvxFBu9oQY2TC+XV4p 6vGPlNhJfqF7H7ylrC/s2/o9ZxtC8bwD6guU4F9fPa3m4WCejvFGQnhLAqOTJXRW4Z p0k9A0maYxCmvwAHu198LboCfncOSkS1UvOwWU8E= Date: Wed, 19 Nov 2025 13:22:47 +0900 From: Laurent Pinchart To: Frank Li Cc: Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Martin Kepplinger-Novakovic , Purism Kernel Team , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] media: nxp: use devm_mutex_init() simple code Message-ID: <20251119042247.GL10711@pendragon.ideasonboard.com> References: <20251117-cam_cleanup-v1-0-6cd42872db79@nxp.com> <20251117-cam_cleanup-v1-1-6cd42872db79@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251117-cam_cleanup-v1-1-6cd42872db79@nxp.com> Hi Frank, Thank you for the patch. On Mon, Nov 17, 2025 at 01:58:11PM -0500, Frank Li wrote: > Use devm_mutex_init() simple code. No functional change. > > Signed-off-by: Frank Li > --- > drivers/media/platform/nxp/imx-pxp.c | 5 ++++- > drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 11 +++++------ > drivers/media/platform/nxp/mx2_emmaprp.c | 7 +++---- > 3 files changed, 12 insertions(+), 11 deletions(-) Given the diffstat, and the fact that devm_mutex_init() performs dynamic memory allocation, I'm not convinced by this change. I won't block it though, as I don't maintain the above drivers. > > diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c > index 3f9a67a6bd4d268841f85f9b69af03138300d188..32d39c8013c7eef1f9629f971cc74afecd463ac7 100644 > --- a/drivers/media/platform/nxp/imx-pxp.c > +++ b/drivers/media/platform/nxp/imx-pxp.c > @@ -1805,6 +1805,10 @@ static int pxp_probe(struct platform_device *pdev) > > spin_lock_init(&dev->irqlock); > > + ret = devm_mutex_init(&pdev->dev, &dev->dev_mutex); > + if (ret) > + return ret; > + > ret = devm_request_irq(&pdev->dev, irq, pxp_irq_handler, 0, > dev_name(&pdev->dev), dev); > if (ret < 0) { > @@ -1831,7 +1835,6 @@ static int pxp_probe(struct platform_device *pdev) > goto err_clk; > > atomic_set(&dev->num_inst, 0); > - mutex_init(&dev->dev_mutex); > > dev->vfd = pxp_videodev; > vfd = &dev->vfd; > diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > index 371b4e81328c107269f89da23818ab0abd0179da..0851f4a9ae52d3096f454da643cfdc5017e000b1 100644 > --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > @@ -1033,15 +1033,17 @@ static int imx8mq_mipi_csi_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, &state->sd); > > - mutex_init(&state->lock); > + ret = devm_mutex_init(dev, &state->lock); > + if (ret) > + return ret; > > ret = imx8mq_mipi_csi_subdev_init(state); > if (ret < 0) > - goto mutex; > + return ret; > > ret = imx8mq_mipi_csi_init_icc(pdev); > if (ret) > - goto mutex; > + return ret; > > /* Enable runtime PM. */ > pm_runtime_enable(dev); > @@ -1068,8 +1070,6 @@ static int imx8mq_mipi_csi_probe(struct platform_device *pdev) > v4l2_async_unregister_subdev(&state->sd); > icc: > imx8mq_mipi_csi_release_icc(pdev); > -mutex: > - mutex_destroy(&state->lock); > > return ret; > } > @@ -1087,7 +1087,6 @@ static void imx8mq_mipi_csi_remove(struct platform_device *pdev) > imx8mq_mipi_csi_runtime_suspend(&pdev->dev); > media_entity_cleanup(&state->sd.entity); > v4l2_subdev_cleanup(&state->sd); > - mutex_destroy(&state->lock); > pm_runtime_set_suspended(&pdev->dev); > imx8mq_mipi_csi_release_icc(pdev); > } > diff --git a/drivers/media/platform/nxp/mx2_emmaprp.c b/drivers/media/platform/nxp/mx2_emmaprp.c > index 02d57229b9b3a600303cc0429e102139385071d6..384a2672884e96d17cca542ef51fbef62328b66a 100644 > --- a/drivers/media/platform/nxp/mx2_emmaprp.c > +++ b/drivers/media/platform/nxp/mx2_emmaprp.c > @@ -824,7 +824,9 @@ static int emmaprp_probe(struct platform_device *pdev) > if (ret) > return ret; > > - mutex_init(&pcdev->dev_mutex); > + ret = devm_mutex_init(&pdev->dev, &pcdev->dev_mutex); > + if (ret) > + return ret; > > vfd = video_device_alloc(); > if (!vfd) { > @@ -878,8 +880,6 @@ static int emmaprp_probe(struct platform_device *pdev) > unreg_dev: > v4l2_device_unregister(&pcdev->v4l2_dev); > > - mutex_destroy(&pcdev->dev_mutex); > - > return ret; > } > > @@ -892,7 +892,6 @@ static void emmaprp_remove(struct platform_device *pdev) > video_unregister_device(pcdev->vfd); > v4l2_m2m_release(pcdev->m2m_dev); > v4l2_device_unregister(&pcdev->v4l2_dev); > - mutex_destroy(&pcdev->dev_mutex); > } > > static struct platform_driver emmaprp_pdrv = { -- Regards, Laurent Pinchart