From: Daniel Baluta <daniel.baluta@nxp.com>
To: andersson@kernel.org, mathieu.poirier@linaro.org
Cc: m.szyprowski@samsung.com, shawnguo@kernel.org,
kernel@pengutronix.de, festevam@gmail.com,
arnaud.pouliquen@foss.st.com, robh@kernel.org,
geert+renesas@glider.be, linux-remoteproc@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Daniel Baluta <daniel.baluta@nxp.com>
Subject: [RFC PATCH] remoteproc: imx_dsp_rproc: Fix multiple start/stop commands
Date: Tue, 9 Dec 2025 16:04:25 +0200 [thread overview]
Message-ID: <20251209140425.766742-1-daniel.baluta@nxp.com> (raw)
After commit 67a7bc7f0358 ("remoteproc: Use of reserved_mem_region_*
functions for "memory-region"") following commands with
imx-dsp-rproc started to fail:
$ echo zephyr.elf > /sys/class/remoteproc/remoteproc0/firmware
$ echo start > /sys/class/remoteproc/remoteproc0/state
$ echo stop > /sys/class/remoteproc/remoteproc0/state
$ echo start > /sys/class/remoteproc/remoteproc0/state #! This fails
-sh: echo: write error: Device or resource busy
This happens because aforementioned commit replaced devm_ioremap_wc with
devm_ioremap_resource_wc which will "reserve" the memory region with the
first start and then will fail at the second start if the memory
region is already reserved.
So prefer using devm_ioremap_wc as there is no easy way to undo
devm_iormep_resource_wc manually.
Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
drivers/remoteproc/imx_dsp_rproc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
index 5130a35214c9..79d5c15319f3 100644
--- a/drivers/remoteproc/imx_dsp_rproc.c
+++ b/drivers/remoteproc/imx_dsp_rproc.c
@@ -709,10 +709,10 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv)
if (imx_dsp_rproc_sys_to_da(priv, res.start, resource_size(&res), &da))
return -EINVAL;
- cpu_addr = devm_ioremap_resource_wc(dev, &res);
- if (IS_ERR(cpu_addr)) {
+ cpu_addr = devm_ioremap_wc(dev, res.start, resource_size(&res));
+ if (!cpu_addr) {
dev_err(dev, "failed to map memory %pR\n", &res);
- return PTR_ERR(cpu_addr);
+ return -ENOMEM;
}
/* Register memory region */
--
2.45.2
next reply other threads:[~2025-12-09 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 14:04 Daniel Baluta [this message]
2025-12-09 15:27 ` [RFC PATCH] remoteproc: imx_dsp_rproc: Fix multiple start/stop commands Rob Herring
2025-12-10 12:56 ` Daniel Baluta
2025-12-10 0:24 ` Iuliana Prodan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251209140425.766742-1-daniel.baluta@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox