From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34B872AEF5 for ; Tue, 9 Dec 2025 08:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765267692; cv=none; b=H/mFjW4arSLMGw29dgaqazg80IEc0FNMwKHWquqg8pwO5D5q0JYJaOyu0MLqp7ZBOWv00Kfd8Z8ZFir0M2HRYEdQIc6IryaA3WMXLQSez9sx3Ss9Xvgbdc+X+2I1AnBrcAhIZyQlD0nLYBVubIdFf65djuN32JWDn7by7qKW6u0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765267692; c=relaxed/simple; bh=MJimUWyWCQryzeXq/CylmXxVGK1UyUx3ivCgZyvep+w=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=p7dkvAb7Z/fXYdy1ih1IGRcgMuLwzyzm3nwfk/zfa9fxUAin4a7dhJDEunXTY49sE3Q7HyveJaYYyZwLgwZrEaC6F0zcVUMgRCV+mooVUmz/LWK/2YBLwn4qYi2Yas+KHtrNc5xkna4RWB6Y+dheoLChtuFMwqQpGWyw/1PlE1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JK0RYzGI; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JK0RYzGI" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47774d3536dso49945925e9.0 for ; Tue, 09 Dec 2025 00:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765267688; x=1765872488; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i3HS3UZvHWNoRI4tSC4tCLlGjmvQB2LsBSbcqGJUth8=; b=JK0RYzGIvRz7m66mQkDOKLQrt1tn3j8leCvcAfY/j9yp8GZM5BebT/mXzqwOQX5EW+ rj01VRVBmgqErBg5yi6j7Ic77ZYw9AnxEX7YHMr0cj44a6bee64PLjCDBWblMkj1AXCT uoyUItixgljSNxPSitjLLh7wIjsWHVuJdxgBWsNmAW6oBK35BXj2i+nHMJCLXTOKJ5e9 +5M6hRAqZ8+/ahRZ1cpNxP21piABDFxMnjP/PwGMqyHkVtnF822rJOq/59KmXwNCY3Hb FaPAjglF2f5XVTgkS82xEm9+eDO3qOUAvTkabyFP4A94fByh1mptmEdnBcdboq4g2TXX neVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765267688; x=1765872488; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i3HS3UZvHWNoRI4tSC4tCLlGjmvQB2LsBSbcqGJUth8=; b=ZkFf/rLhMrqvXkWwFONY+/57IxR3Z0CEPRURXr60BttGry3y+9E8d42n3vm8aJt2Cl xQUBeBD+ebedMQlLa4VJe2jeTsLuarOlTOkYAlOH57NQmFPUfaJQ98HsNk35jDhNbibg GfcxnZjSzBwNAX1SajQrLZInT/UleH2eueb7ojLPi0KK/xLZ9an7hMQT+FMM/pi+Zi9x D/X2Kz3N14IURv2qzoS0QNqR5QI37l1QZy1ILiOuDknL/OTaEPEIxmogPt01zF2TmOUo 1URParzjevwGweSQVZWJ13HaLg3qyXIe99XyXFzI1X+s62EK2rSx/rn2WYmLYxO/SgnH U8MA== X-Forwarded-Encrypted: i=1; AJvYcCXz++57KS3vfJ4cuTzRPtBjj1Cm5udMuEjME4Csp57086K9hsoh+n7w2axmLkWj9iyemxY=@lists.linux.dev X-Gm-Message-State: AOJu0YxcAtGwvYWnFpIU8FKletZNlpk/vYdirbK/hlzBrZNWV2DqW6CR E6XtFKZlOsTe9EoJ7eWorFNokd6LQgZ+NWlbkCSzUITYhi9Egorhshvh49DklTt2ja8= X-Gm-Gg: ASbGnctMWM+74nc9Q0eXhPcBBR5d5Q1kERd/k4GN1Af8xeQj2YEAjELL42S7pZwJYo2 FkgD1z9TVpRY66Z6rv8Lnu2Fb7+Bb/+rN5VgPOOuT5citwIjwQkUiqRd1yooSNJAESr1J0MPear b1r9/ryGWrGaHtcLHEARbLFI+1zbNfOJ2N8GrbKwjLnjgugF3/IWB1rnCIikeg1vXwhWY0tmr+W N/1Gw9FssCy0ilnieCEqziEGVPYa6K0zXRo1ocJufjvYWR/vdd6gBlDGpwbTRajjezQopn0wSr4 zjv3ZXB4gzmTCegEIadjDcPz9JXX0Sn5BXN7G4JdXZDJb053RxBUfGE9L57yctjhpGdnd22obQT kbFylsdIB6bf04MgOuiL1qQRqZahtUgcmLo15weztJoBfSsNBEB8Ktyc8cTefCZ3jOLMUxUNQqr UvuPE8LAXZbPS25v3V X-Google-Smtp-Source: AGHT+IGscc+SJZEm/TRqQYoD0TdId9MDDNWX4FpzSAzC9aFu5AY3yWeeq7XQ4gq/1MUrF2INsOS4mA== X-Received: by 2002:a05:600d:844f:10b0:477:9d88:2da6 with SMTP id 5b1f17b1804b1-47a7f987e56mr5630745e9.0.1765267688376; Tue, 09 Dec 2025 00:08:08 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7d397a2fsm12719515e9.5.2025.12.09.00.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 00:08:07 -0800 (PST) Date: Tue, 9 Dec 2025 11:08:04 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Pankaj Gupta , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Frank Li Subject: Re: [PATCH v20 3/7] firmware: imx: add driver for NXP EdgeLock Enclave Message-ID: <202512091557.d5dOvFff-lkp@intel.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251203-imx-se-if-v20-3-a04a25c4255f@nxp.com> Hi Pankaj, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Pankaj-Gupta/Documentation-firmware-add-imx-se-to-other_interfaces/20251203-145202 base: 4a26e7032d7d57c998598c08a034872d6f0d3945 patch link: https://lore.kernel.org/r/20251203-imx-se-if-v20-3-a04a25c4255f%40nxp.com patch subject: [PATCH v20 3/7] firmware: imx: add driver for NXP EdgeLock Enclave config: arm64-randconfig-r072-20251207 (https://download.01.org/0day-ci/archive/20251209/202512091557.d5dOvFff-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project a805147ac1ba123916de182babb0831fbb148756) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512091557.d5dOvFff-lkp@intel.com/ smatch warnings: drivers/firmware/imx/ele_common.c:264 se_save_imem_state() warn: missing error code? 'ret' drivers/firmware/imx/ele_common.c:302 se_restore_imem_state() warn: missing error code? 'ret' vim +/ret +264 drivers/firmware/imx/ele_common.c a9e23a74789346 Pankaj Gupta 2025-12-03 251 int se_save_imem_state(struct se_if_priv *priv, struct se_imem_buf *imem) a9e23a74789346 Pankaj Gupta 2025-12-03 252 { a9e23a74789346 Pankaj Gupta 2025-12-03 253 struct ele_dev_info s_info = {0}; a9e23a74789346 Pankaj Gupta 2025-12-03 254 int ret; a9e23a74789346 Pankaj Gupta 2025-12-03 255 a9e23a74789346 Pankaj Gupta 2025-12-03 256 ret = ele_get_info(priv, &s_info); a9e23a74789346 Pankaj Gupta 2025-12-03 257 if (ret) { a9e23a74789346 Pankaj Gupta 2025-12-03 258 dev_err(priv->dev, "Failed to get info from ELE.\n"); a9e23a74789346 Pankaj Gupta 2025-12-03 259 return ret; a9e23a74789346 Pankaj Gupta 2025-12-03 260 } a9e23a74789346 Pankaj Gupta 2025-12-03 261 a9e23a74789346 Pankaj Gupta 2025-12-03 262 /* Do not save the IMEM buffer, if the current IMEM state is BAD. */ a9e23a74789346 Pankaj Gupta 2025-12-03 263 if (s_info.d_addn_info.imem_state == ELE_IMEM_STATE_BAD) a9e23a74789346 Pankaj Gupta 2025-12-03 @264 return ret; This returns success if the state is _BAD. a9e23a74789346 Pankaj Gupta 2025-12-03 265 a9e23a74789346 Pankaj Gupta 2025-12-03 266 /* a9e23a74789346 Pankaj Gupta 2025-12-03 267 * EXPORT command will save encrypted IMEM to given address, a9e23a74789346 Pankaj Gupta 2025-12-03 268 * so later in resume, IMEM can be restored from the given a9e23a74789346 Pankaj Gupta 2025-12-03 269 * address. a9e23a74789346 Pankaj Gupta 2025-12-03 270 * a9e23a74789346 Pankaj Gupta 2025-12-03 271 * Size must be at least 64 kB. a9e23a74789346 Pankaj Gupta 2025-12-03 272 */ a9e23a74789346 Pankaj Gupta 2025-12-03 273 ret = ele_service_swap(priv, imem->phyaddr, ELE_IMEM_SIZE, ELE_IMEM_EXPORT); a9e23a74789346 Pankaj Gupta 2025-12-03 274 if (ret < 0) { a9e23a74789346 Pankaj Gupta 2025-12-03 275 dev_err(priv->dev, "Failed to export IMEM."); a9e23a74789346 Pankaj Gupta 2025-12-03 276 imem->size = 0; a9e23a74789346 Pankaj Gupta 2025-12-03 277 } else { a9e23a74789346 Pankaj Gupta 2025-12-03 278 dev_dbg(priv->dev, a9e23a74789346 Pankaj Gupta 2025-12-03 279 "Exported %d bytes of encrypted IMEM.", a9e23a74789346 Pankaj Gupta 2025-12-03 280 ret); a9e23a74789346 Pankaj Gupta 2025-12-03 281 imem->size = ret; a9e23a74789346 Pankaj Gupta 2025-12-03 282 } a9e23a74789346 Pankaj Gupta 2025-12-03 283 a9e23a74789346 Pankaj Gupta 2025-12-03 284 return ret > 0 ? 0 : ret; a9e23a74789346 Pankaj Gupta 2025-12-03 285 } a9e23a74789346 Pankaj Gupta 2025-12-03 286 a9e23a74789346 Pankaj Gupta 2025-12-03 287 int se_restore_imem_state(struct se_if_priv *priv, struct se_imem_buf *imem) a9e23a74789346 Pankaj Gupta 2025-12-03 288 { a9e23a74789346 Pankaj Gupta 2025-12-03 289 struct ele_dev_info s_info; a9e23a74789346 Pankaj Gupta 2025-12-03 290 int ret; a9e23a74789346 Pankaj Gupta 2025-12-03 291 a9e23a74789346 Pankaj Gupta 2025-12-03 292 /* get info from ELE */ a9e23a74789346 Pankaj Gupta 2025-12-03 293 ret = ele_get_info(priv, &s_info); a9e23a74789346 Pankaj Gupta 2025-12-03 294 if (ret) { a9e23a74789346 Pankaj Gupta 2025-12-03 295 dev_err(priv->dev, "Failed to get info from ELE."); a9e23a74789346 Pankaj Gupta 2025-12-03 296 return ret; a9e23a74789346 Pankaj Gupta 2025-12-03 297 } a9e23a74789346 Pankaj Gupta 2025-12-03 298 imem->state = s_info.d_addn_info.imem_state; a9e23a74789346 Pankaj Gupta 2025-12-03 299 a9e23a74789346 Pankaj Gupta 2025-12-03 300 /* Get IMEM state, if 0xFE then import IMEM if imem size is non-zero. */ I really can't understand this comment at all. :( a9e23a74789346 Pankaj Gupta 2025-12-03 301 if (s_info.d_addn_info.imem_state != ELE_IMEM_STATE_BAD || !imem->size) a9e23a74789346 Pankaj Gupta 2025-12-03 @302 return ret; This feels like returning zero is intentional, but please return a literal zero. s/return ret;/return 0;/. -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki