From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB083168E3; Wed, 7 Jan 2026 14:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767794886; cv=none; b=D1PzziYAOEn1hztvHWDmozJeDryhJbULzmKfIvLuSUoq4zsyuGCHZiWThmTIuae1tc0IHRxi2uXBpY2FqU3odaNgItawVvVWxCK6g7A9I6fq/lbP9EQ9IY/DFPFBvPrDW07vBpW7jXtIxMOIZlsKsJ8JviKPKjUCbNsRqVVu9aM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767794886; c=relaxed/simple; bh=tixylDIwkfMzESf8/JELPILstX0GopnvIR6u5lHwaKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ICdHV53S74ClurxN0mEwLEKcDQBf/lx9seJbAV4yvftuKMa2JM77UC5g04jyd7JO+nyM+gqVHPJWjX7SXng1nuER9Mj5P3T3qdf30UHpCWTJRN27H306LjyWJ0Ueyr64BNZoOSA0HfP3NvkQy2TkMw0YlF6ZC1ggiH89Q/C0O38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d+yKW82N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d+yKW82N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9210C4CEF1; Wed, 7 Jan 2026 14:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767794885; bh=tixylDIwkfMzESf8/JELPILstX0GopnvIR6u5lHwaKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d+yKW82NNNJx2vwiMYS/bjv0OXWpntcMb8wDjG09HZnubqTCbaqj+8kpP90FLjKlZ RDxkRBwLEpn+rnHZ/prOfonmw61IcVqCKKa0kFCJA7PQi0zVRjzu1HEA8XQC7t3vf8 AeUgLYHGtc5ZxJm+m1b12TIuNRSGZFN9sB27rL1MeXdz9zWJDR/3fw0T/NyYqPKYFy SMwdLpHO4EFEwusImIAIZkIYBeIhkDzZRyC7ofsTkfJ9C/9ENFdLftj+HMgprXWwWC VyxpGtJ8WBNM8CAjpmc64bFSQ2hdxU5ZhZ10rsar79OuzK5b2qoXW//ACFMqHR4eCb Pu81Om00rpliA== Date: Wed, 7 Jan 2026 15:08:03 +0100 From: Maxime Ripard To: Luca Ceresoli Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Philippe Cornu , benjamin.gaignard@linaro.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Adrien Grassein , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Inki Dae , Jagan Teki , Marek Szyprowski , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 09/12] drm/bridge: imx8qxp-ldb: convert to of_drm_find_and_get_bridge() Message-ID: <20260107-weightless-adaptable-wildebeest-a3ed6f@houat> References: <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-2-v1-0-283d7bba061a@bootlin.com> <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-2-v1-9-283d7bba061a@bootlin.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="ljhomylig6poh7z3" Content-Disposition: inline In-Reply-To: <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-2-v1-9-283d7bba061a@bootlin.com> --ljhomylig6poh7z3 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 09/12] drm/bridge: imx8qxp-ldb: convert to of_drm_find_and_get_bridge() MIME-Version: 1.0 Hi, On Wed, Jan 07, 2026 at 02:13:00PM +0100, Luca Ceresoli wrote: > of_drm_find_bridge() is deprecated. Move to its replacement > of_drm_find_and_get_bridge() which gets a bridge reference, and ensure it > is put when done. >=20 > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c b/drivers/gpu/drm/b= ridge/imx/imx8qxp-ldb.c > index 122502968927..6b80d798b27a 100644 > --- a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c > +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c > @@ -552,7 +552,7 @@ static int imx8qxp_ldb_parse_dt_companion(struct imx8= qxp_ldb *imx8qxp_ldb) > goto out; > } > =20 > - imx8qxp_ldb->companion =3D of_drm_find_bridge(companion_port); > + imx8qxp_ldb->companion =3D of_drm_find_and_get_bridge(companion_port); > if (!imx8qxp_ldb->companion) { > ret =3D -EPROBE_DEFER; > DRM_DEV_DEBUG_DRIVER(dev, > @@ -679,6 +679,7 @@ static void imx8qxp_ldb_remove(struct platform_device= *pdev) > struct ldb *ldb =3D &imx8qxp_ldb->base; > =20 > ldb_remove_bridge_helper(ldb); > + drm_bridge_put(imx8qxp_ldb->companion); the companion bridge is used in pretty much every KMS hook, we need to put the reference in destroy. Maxime --ljhomylig6poh7z3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaV5ovQAKCRAnX84Zoj2+ dv4yAYC/18PKdVreCA8vF+oCiv+rArQOQdluKaPY7WyntK608MdJYBnbhVlGWFt3 m/w0WAkBgIx7i5jlphIWLhPUgfA0LxoI4W9QLV2N3AymAfzRp7rmhJPGXGDZ03P/ Q3gPy/78sg== =3oDC -----END PGP SIGNATURE----- --ljhomylig6poh7z3--