From: Frank Li <Frank.Li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
imx@lists.linux.dev, joy.zou@nxp.com,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH RFC 03/12] dmaengine: fsl-edma: Remove redundant echan from struct fsl_edma_desc
Date: Wed, 28 Jan 2026 13:05:22 -0500 [thread overview]
Message-ID: <20260128-dma_ll_comlib-v1-3-1b1fa2c671f9@nxp.com> (raw)
In-Reply-To: <20260128-dma_ll_comlib-v1-0-1b1fa2c671f9@nxp.com>
The echan pointer can be obtained from the dma_async_tx_descriptor embedded
in struct virt_dma_desc. So remove echan from struct fsl_edma_desc.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/dma/fsl-edma-common.c | 4 ++--
drivers/dma/fsl-edma-common.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
index 396ff6dfa99a150f9ce34effd64534e3d8e8576b..61387c4edc910c8a806cc2c6f0fee2e690424bac 100644
--- a/drivers/dma/fsl-edma-common.c
+++ b/drivers/dma/fsl-edma-common.c
@@ -228,7 +228,8 @@ void fsl_edma_free_desc(struct virt_dma_desc *vdesc)
fsl_desc = to_fsl_edma_desc(vdesc);
for (i = 0; i < fsl_desc->n_tcds; i++)
- dma_pool_free(fsl_desc->echan->tcd_pool, fsl_desc->tcd[i].vtcd,
+ dma_pool_free(to_fsl_edma_chan(vdesc->tx.chan)->tcd_pool,
+ fsl_desc->tcd[i].vtcd,
fsl_desc->tcd[i].ptcd);
kfree(fsl_desc);
}
@@ -555,7 +556,6 @@ static struct fsl_edma_desc *fsl_edma_alloc_desc(struct fsl_edma_chan *fsl_chan,
if (!fsl_desc)
return NULL;
- fsl_desc->echan = fsl_chan;
fsl_desc->n_tcds = sg_len;
for (i = 0; i < sg_len; i++) {
fsl_desc->tcd[i].vtcd = dma_pool_alloc(fsl_chan->tcd_pool,
diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
index 8e45770a0d3960ee34361fe5884a169de64e14a7..a0d83ad783f7a53caab93d280c6e40f63b8e9e5c 100644
--- a/drivers/dma/fsl-edma-common.h
+++ b/drivers/dma/fsl-edma-common.h
@@ -196,7 +196,6 @@ struct fsl_edma_chan {
struct fsl_edma_desc {
struct virt_dma_desc vdesc;
- struct fsl_edma_chan *echan;
bool iscyclic;
enum dma_transfer_direction dirn;
unsigned int n_tcds;
--
2.34.1
next prev parent reply other threads:[~2026-01-28 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 18:05 [PATCH RFC 00/12] dmaengine: introduce common linked-list DMA controller framework Frank Li
2026-01-28 18:05 ` [PATCH RFC 01/12] dmaengine: Extend virt_chan for link list based DMA engines Frank Li
2026-01-28 18:05 ` [PATCH RFC 02/12] dmaengine: Add common dma_ll_desc and dma_linklist_item for link-list controllers Frank Li
2026-01-28 18:05 ` Frank Li [this message]
2026-01-28 18:05 ` [PATCH RFC 04/12] dmaengine: fsl-edma: Use common dma_ll_desc in vchan Frank Li
2026-01-28 18:05 ` [PATCH RFC 05/12] dmaengine: Add DMA pool allocation in vchan_dma_ll_init() and API vchan_dma_ll_free() Frank Li
2026-01-28 18:05 ` [PATCH RFC 06/12] dmaengine: Move fsl_edma_(alloc|free)_desc() to common library Frank Li
2026-01-28 18:05 ` [PATCH RFC 07/12] dmaengine: virt-dma: split vchan_tx_prep() into init and internal helpers Frank Li
2026-01-28 18:05 ` [PATCH RFC 08/12] dmaengine: Factor out fsl-edma prep_memcpy into common vchan helper Frank Li
2026-01-28 18:05 ` [PATCH RFC 09/12] dmaengine: ll-dma: support multi-descriptor memcpy for large transfers Frank Li
2026-01-28 18:05 ` [PATCH RFC 10/12] dmaengine: move fsl-edma dma_[un]map_resource() to linked list library Frank Li
2026-01-28 18:05 ` [PATCH RFC 11/12] dmaengine: fsl-edma: use local soff/doff variables Frank Li
2026-01-28 18:05 ` [PATCH RFC 12/12] dmaengine: add vchan_dma_ll_prep_slave_{sg,cyclic} API Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128-dma_ll_comlib-v1-3-1b1fa2c671f9@nxp.com \
--to=frank.li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox