From: Sherry Sun <sherry.sun@nxp.com>
To: hongxing.zhu@nxp.com, l.stach@pengutronix.de, Frank.Li@nxp.com,
bhelgaas@google.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com
Cc: imx@lists.linux.dev, kernel@pengutronix.de,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V5 00/12] pci-imx6: Add support for parsing the reset property in new Root Port binding
Date: Fri, 13 Feb 2026 12:08:40 +0800 [thread overview]
Message-ID: <20260213040852.3340547-1-sherry.sun@nxp.com> (raw)
This patch set adds support for parsing the reset property in new Root Port
binding in pci-imx6 driver, similar to the implementation in the qcom pcie
driver[1].
Also introduce generic helper functions to parse Root Port device tree
nodes and extract common properties like reset GPIOs. This allows multiple
PCI host controller drivers to share the same parsing logic.
Define struct pci_host_port to hold common Root Port properties
(currently only reset GPIO descriptor) and add
pci_host_common_parse_ports() to parse Root Port nodes from device tree.
Also add the 'ports' list to struct pci_host_bridge for better maintain
parsed Root Port information.
The plan is to add the wake-gpio property to the root port in subsequent
patches. Also, the vpcie-supply property will be moved to the root port
node later based on the refactoring patch set for the PCI pwrctrl
framework[2].
The initial idea is to adopt the Manivannan’s recent PCIe M.2 KeyE
connector support patch set[3] and PCI power control framework patches[2],
and extend them to the pcie-imx6 driver. Since the new M.2/pwrctrl model is
implemented based on Root Ports and requires the pwrctrl driver to bind to
a Root Port device, we need to introduce a Root Port child node on i.MX
boards that provide an M.2 connector.
To follow a more standardized DT structure, it also makes sense to move
the reset-gpios and wake-gpios properties into the Root Port node. These
signals logically belong to the Root Port rather than the host bridge,
and placing them there aligns with the new M.2/pwrctrl model.
Regarding backward compatibility, as Frank suggested, I will not remove
the old reset-gpio property from existing DTS files to avoid function
break.
For new i.MX platforms — such as the upcoming i.MX952-evk will add
vpcie-supply, reset-gpios, and wake-gpios directly under the Root Port
node.
Therefore, driver updates are needed to support both the legacy
properties and the new standardized Root Port based layout.
[1] https://lore.kernel.org/linux-pci/20250702-perst-v5-0-920b3d1f6ee1@qti.qualcomm.com/
[2] https://lore.kernel.org/linux-pci/20260115-pci-pwrctrl-rework-v5-0-9d26da3ce903@oss.qualcomm.com/
[3] https://lore.kernel.org/linux-pci/20260112-pci-m2-e-v4-0-eff84d2c6d26@oss.qualcomm.com/
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
Changes in V5:
1. Add the Root Port list(pci_host_port) to struct pci_host_bridge for better
maintain parsed Root Port information.
2. Delete the pci_host_common_delete_ports() as now the Root Port list in
pci_host_bridge can be cleared by pci_release_host_bridge_dev().
3. Change the common API pci_host_common_parse_ports() pass down struct
pci_host_bridge *.
4. Modify dw_pcie_host_init() to allow drivers to pre-allocate pci_host_bridge
struct when needed.
5. Allocate bridge early in imx_pcie_probe() to parse Root Ports.
Changes in V4:
1. Add common helpers for parsing Root Port properties in pci-host-common.c in
patch#2.
2. Call common pci_host_common_parse_ports() and pci_host_common_delete_ports()
in pci-imx6 driver.
3. Use PCIE_T_PVPERL_MS and PCIE_RESET_CONFIG_WAIT_MS instead of magic number
100 in patch#3 as Manivannan suggested.
4. Use "PERST#" instead of "PCIe reset" for the reset gpio lable in patch#3.
Changes in V3:
1. Improve the patch#2 commit message as Frank suggested.
2. Add Reviewed-by tag for patch#1.
Changes in V2:
1. Improve the patch#1 commit message as Frank suggested.
2. Also mark the reset-gpio-active-high property as deprecated in
imx6q-pcie DT binding as Rob suggested.
3. The imx_pcie_delete_ports() has been moved up so that the
imx_pcie_parse_ports() can call this helper function in error handling.
4. Keep the old reset-gpio property in the host bridge node for the
existing dts files and add comments to avoid confusion.
---
Sherry Sun (12):
dt-bindings: PCI: fsl,imx6q-pcie: Add reset GPIO in Root Port node
PCI: host-generic: Add common helpers for parsing Root Port properties
PCI: dwc: Allow external allocation of pci_host_bridge
PCI: imx6: Add support for parsing the reset property in new Root Port
binding
arm: dts: imx6qdl: Add Root Port node and PERST property
arm: dts: imx6sx: Add Root Port node and PERST property
arm: dts: imx7d: Add Root Port node and PERST property
arm64: dts: imx8mm: Add Root Port node and PERST property
arm64: dts: imx8mp: Add Root Port node and PERST property
arm64: dts: imx8mq: Add Root Port node and PERST property
arm64: dts: imx8dxl/qm/qxp: Add Root Port node and PERST property
arm64: dts: imx95: Add Root Port node and PERST property
.../bindings/pci/fsl,imx6q-pcie.yaml | 32 ++++++++
.../arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi | 5 ++
arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 11 +++
.../arm/boot/dts/nxp/imx/imx6qp-sabreauto.dts | 5 ++
arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi | 5 ++
arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 11 +++
arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 5 ++
arch/arm/boot/dts/nxp/imx/imx7d.dtsi | 11 +++
.../boot/dts/freescale/imx8-ss-hsio.dtsi | 11 +++
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 5 ++
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 5 ++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 11 +++
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 5 ++
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 11 +++
arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 10 +++
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 +++++
arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 10 +++
.../boot/dts/freescale/imx8qm-ss-hsio.dtsi | 22 +++++
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ++
.../boot/dts/freescale/imx95-15x15-evk.dts | 5 ++
.../boot/dts/freescale/imx95-19x19-evk.dts | 10 +++
arch/arm64/boot/dts/freescale/imx95.dtsi | 22 +++++
drivers/pci/controller/dwc/pci-imx6.c | 81 +++++++++++++++----
.../pci/controller/dwc/pcie-designware-host.c | 12 ++-
drivers/pci/controller/pci-host-common.c | 58 +++++++++++++
drivers/pci/controller/pci-host-common.h | 15 ++++
drivers/pci/probe.c | 2 +
include/linux/pci.h | 1 +
28 files changed, 390 insertions(+), 18 deletions(-)
--
2.37.1
next reply other threads:[~2026-02-13 4:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 4:08 Sherry Sun [this message]
2026-02-13 4:08 ` [PATCH V5 01/12] dt-bindings: PCI: fsl,imx6q-pcie: Add reset GPIO in Root Port node Sherry Sun
2026-02-13 4:08 ` [PATCH V5 02/12] PCI: host-generic: Add common helpers for parsing Root Port properties Sherry Sun
2026-02-16 16:21 ` Manivannan Sadhasivam
2026-02-24 10:24 ` Sherry Sun
2026-02-25 13:15 ` Manivannan Sadhasivam
2026-02-26 3:40 ` Sherry Sun
2026-02-28 1:58 ` Hongxing Zhu
2026-02-28 15:05 ` Manivannan Sadhasivam
2026-02-13 4:08 ` [PATCH V5 03/12] PCI: dwc: Allow external allocation of pci_host_bridge Sherry Sun
2026-02-13 15:29 ` Frank Li
2026-02-16 16:25 ` Manivannan Sadhasivam
2026-02-24 10:34 ` Sherry Sun
2026-02-13 4:08 ` [PATCH V5 04/12] PCI: imx6: Add support for parsing the reset property in new Root Port binding Sherry Sun
2026-02-13 15:32 ` Frank Li
2026-02-13 4:08 ` [PATCH V5 05/12] arm: dts: imx6qdl: Add Root Port node and PERST property Sherry Sun
2026-02-13 4:08 ` [PATCH V5 06/12] arm: dts: imx6sx: " Sherry Sun
2026-02-13 4:08 ` [PATCH V5 07/12] arm: dts: imx7d: " Sherry Sun
2026-02-13 4:08 ` [PATCH V5 08/12] arm64: dts: imx8mm: " Sherry Sun
2026-02-13 4:08 ` [PATCH V5 09/12] arm64: dts: imx8mp: " Sherry Sun
2026-02-13 4:08 ` [PATCH V5 10/12] arm64: dts: imx8mq: " Sherry Sun
2026-02-13 4:08 ` [PATCH V5 11/12] arm64: dts: imx8dxl/qm/qxp: " Sherry Sun
2026-02-13 4:08 ` [PATCH V5 12/12] arm64: dts: imx95: " Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260213040852.3340547-1-sherry.sun@nxp.com \
--to=sherry.sun@nxp.com \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox