From: Larisa Grigore <larisa.grigore@oss.nxp.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
sumit.semwal@linaro.org, christian.koenig@amd.com,
chester62515@gmail.com, cosmin.stoica@nxp.com,
adrian.nitu@freescale.com, stefan-gabriel.mirea@nxp.com,
Mihaela.Martinas@freescale.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
s32@nxp.com, imx@lists.linux.dev, clizzi@redhat.com,
aruizrui@redhat.com, eballetb@redhat.com, echanude@redhat.com,
jkangas@redhat.com, Larisa Grigore <larisa.grigore@oss.nxp.com>
Subject: [PATCH 11/13] serial: linflexuart: Add support for configurable stop bits
Date: Mon, 16 Feb 2026 16:02:03 +0100 [thread overview]
Message-ID: <20260216150205.212318-12-larisa.grigore@oss.nxp.com> (raw)
In-Reply-To: <20260216150205.212318-1-larisa.grigore@oss.nxp.com>
Updated linflex_set_termios to set the number of stop bits based on
termios->c_cflag.
Signed-off-by: Larisa Grigore <larisa.grigore@oss.nxp.com>
---
drivers/tty/serial/fsl_linflexuart.c | 31 +++++++++++++++++++++++++---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
index 36c8f90d975d..a5a34fd81bcf 100644
--- a/drivers/tty/serial/fsl_linflexuart.c
+++ b/drivers/tty/serial/fsl_linflexuart.c
@@ -75,6 +75,10 @@
#define LINFLEXD_UARTCR_ROSE BIT(23)
+#define LINFLEXD_UARTCR_SBUR_MASK GENMASK(18, 17)
+#define LINFLEXD_UARTCR_SBUR_1SBITS (0x0 << 17)
+#define LINFLEXD_UARTCR_SBUR_2SBITS (0x1 << 17)
+
#define LINFLEXD_UARTCR_RDFLRFC_OFFSET 10
#define LINFLEXD_UARTCR_RDFLRFC_MASK (0x7 << LINFLEXD_UARTCR_RDFLRFC_OFFSET)
#define LINFLEXD_UARTCR_RDFLRFC(uartcr) (((uartcr) \
@@ -124,6 +128,10 @@
#define LINFLEX_LDIV_MULTIPLIER (16)
+#define LINFLEXD_GCR_STOP_MASK BIT(1)
+#define LINFLEXD_GCR_STOP_1SBITS (0 << 1)
+#define LINFLEXD_GCR_STOP_2SBITS BIT(1)
+
#define DRIVER_NAME "fsl-linflexuart"
#define DEV_NAME "ttyLF"
#define UART_NR 4
@@ -456,7 +464,7 @@ linflex_set_termios(struct uart_port *port, struct ktermios *termios,
const struct ktermios *old)
{
unsigned long flags;
- unsigned long cr, old_cr, cr1;
+ unsigned long cr, old_cr, cr1, gcr;
unsigned int old_csize = old ? old->c_cflag & CSIZE : CS8;
unsigned long ibr, fbr, divisr, dividr;
unsigned char ldiv_mul;
@@ -521,8 +529,25 @@ linflex_set_termios(struct uart_port *port, struct ktermios *termios,
cr |= LINFLEXD_UARTCR_WL0;
}
- if (termios->c_cflag & CSTOPB)
- termios->c_cflag &= ~CSTOPB;
+ gcr = readl(port->membase + GCR);
+
+ if (termios->c_cflag & CSTOPB) {
+ /* Use 2 stop bits. */
+ cr = (cr & ~LINFLEXD_UARTCR_SBUR_MASK) |
+ LINFLEXD_UARTCR_SBUR_2SBITS;
+ /* Set STOP in GCR field for 2 stop bits. */
+ gcr = (gcr & ~LINFLEXD_GCR_STOP_MASK) |
+ LINFLEXD_GCR_STOP_2SBITS;
+ } else {
+ /* Use 1 stop bit. */
+ cr = (cr & ~LINFLEXD_UARTCR_SBUR_MASK) |
+ LINFLEXD_UARTCR_SBUR_1SBITS;
+ /* Set STOP in GCR field for 1 stop bit. */
+ gcr = (gcr & ~LINFLEXD_GCR_STOP_MASK) |
+ LINFLEXD_GCR_STOP_1SBITS;
+ }
+ /* Update GCR register. */
+ writel(gcr, port->membase + GCR);
/* parity must be enabled when CS7 to match 8-bits format */
if ((termios->c_cflag & CSIZE) == CS7)
--
2.47.0
next prev parent reply other threads:[~2026-02-16 15:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 15:01 [PATCH 00/13] Add DMA support for LINFlexD UART driver Larisa Grigore
2026-02-16 15:01 ` [PATCH 01/13] serial: linflexuart: Fix locking in set_termios Larisa Grigore
2026-02-16 20:16 ` Frank Li
2026-02-18 11:58 ` Larisa Ileana Grigore
2026-02-16 15:01 ` [PATCH 02/13] serial: linflexuart: Clean SLEEP bit in LINCR1 after suspend Larisa Grigore
2026-02-16 20:22 ` Frank Li
2026-02-18 12:09 ` Larisa Ileana Grigore
2026-02-16 15:01 ` [PATCH 03/13] serial: linflexuart: Check FIFO full before writing Larisa Grigore
2026-02-16 15:01 ` [PATCH 04/13] serial: linflexuart: Correctly clear UARTSR in buffer mode Larisa Grigore
2026-02-16 15:01 ` [PATCH 05/13] serial: linflexuart: Update RXEN/TXEN outside INITM mode Larisa Grigore
2026-02-16 15:01 ` [PATCH 06/13] serial: linflexuart: Ensure FIFO is empty when entering INITM Larisa Grigore
2026-02-16 15:01 ` [PATCH 07/13] serial: linflexuart: Revert earlycon workaround Larisa Grigore
2026-02-16 15:02 ` [PATCH 08/13] dt-bindings: serial: fsl-linflexuart: add clock input properties Larisa Grigore
2026-02-16 15:10 ` Krzysztof Kozlowski
2026-02-18 13:26 ` Larisa Ileana Grigore
2026-02-18 13:29 ` Krzysztof Kozlowski
2026-02-18 13:57 ` Larisa Ileana Grigore
2026-02-18 19:48 ` Krzysztof Kozlowski
2026-02-16 15:02 ` [PATCH 09/13] dt-bindings: serial: fsl-linflexuart: add dma properties Larisa Grigore
2026-02-16 15:10 ` Krzysztof Kozlowski
2026-02-18 14:44 ` Larisa Ileana Grigore
2026-02-18 19:49 ` Krzysztof Kozlowski
2026-02-16 15:29 ` Daniel Baluta
2026-02-17 8:10 ` Krzysztof Kozlowski
2026-02-17 8:39 ` Daniel Baluta
2026-02-16 15:02 ` [PATCH 10/13] serial: linflexuart: Add support for changing baudrate Larisa Grigore
2026-02-16 15:02 ` Larisa Grigore [this message]
2026-02-16 15:02 ` [PATCH 12/13] serial: linflexuart: Add DMA support Larisa Grigore
2026-02-16 15:11 ` Krzysztof Kozlowski
2026-02-16 20:48 ` kernel test robot
2026-02-17 3:26 ` kernel test robot
2026-02-19 8:22 ` Dan Carpenter
2026-02-16 15:02 ` [PATCH 13/13] serial: linflexuart: Avoid stopping DMA during receive operations Larisa Grigore
2026-02-27 14:03 ` [PATCH 00/13] Add DMA support for LINFlexD UART driver Jared Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260216150205.212318-12-larisa.grigore@oss.nxp.com \
--to=larisa.grigore@oss.nxp.com \
--cc=Mihaela.Martinas@freescale.com \
--cc=adrian.nitu@freescale.com \
--cc=aruizrui@redhat.com \
--cc=chester62515@gmail.com \
--cc=christian.koenig@amd.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=cosmin.stoica@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eballetb@redhat.com \
--cc=echanude@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=jkangas@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
--cc=stefan-gabriel.mirea@nxp.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox