From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 119B22C326C for ; Mon, 16 Feb 2026 18:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265483; cv=none; b=cmzv3ND9z0oJZDH3GGNXDoRjbveGhk59W7FvpU3jjbSiCazeoprvOGdOxEuFRtvg1B/tPLZe4UltGKiTElczbMQlWB+gpwZgz61Um+jQQfg84A7UpVblJkrxkl21dB3BS4ysIswwQlRihr2z5r3HolZ3+18wXLUp6T4Av1HGN7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265483; c=relaxed/simple; bh=cSCEF3PytEUhtrqx1ZL9yZAsXNXSd/VJdHuArUNHrik=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iItUKWd8P+7wN9sCtzGXHpj6RIJ14sKcM9Rvf+pDU5xqPkjHvfUU1UC7kJkaT6187H3eQA520JGfurfCLIEysxfk7myzD+R2SzMltAq2m9yWyugPJ/dUQNPAwliKxX7YMIMWuS9h/AQo0tvu+3ACOVxvTUNwJ2+RXvjlUhfPaZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iJYG9Xdy; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iJYG9Xdy" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-124afd03fd1so5024747c88.0 for ; Mon, 16 Feb 2026 10:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265481; x=1771870281; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7qPeoOZLMpDPHLvXRZ2UOWF72e8RnmNaQnfGaf4d8jU=; b=iJYG9XdydIsCsguXqa4m540LqZbozYOXNXsbcTSWFy3x+YBwoHvqhx93vfFl06TRqf pHt1QmqRdrLGBnEAvfgm9QTWNGyYJEv8AQLdwoaYgQt+T042bmsJBcuTAj38u2R6s5bn gi/HIt2fIppGdcJ6ajUlPBPd3RrI8sakHwNHI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265481; x=1771870281; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7qPeoOZLMpDPHLvXRZ2UOWF72e8RnmNaQnfGaf4d8jU=; b=rGlHW+vAISc1Fu5TpXcMdfSlPOVO+JCOwJq9vUwjYjH7nGT4NLSlZooPrUr7NoDD8J CTzSl3zrtDia6upuBtLW9t8EAS8Np2cWBuaCdFAAKLJHclFO/zg8xIPRVe0iO3n7QpeZ 95cMYuwet7qYWuG6BnYRAcyzl5F6x0ma6ve+e29Z1DGi6gyeleyF56rMCH+CWFxCvytf uoLMnNmwEUlzsUzpjK6HdrVtSsr3NILiQJz86dCNzo24Er5oM3sBH5E4HJ+vnbkWwoSa sCy9NssTVrxRxHQmvK6/66umw/W+dQKo+TWFqiZke/CEBRskGy/obKKAKRpglACKAFSK vVeA== X-Forwarded-Encrypted: i=1; AJvYcCWjHAUcITJsNIyZXZjoS9++2aTk0m+4ARwxY2yMq4oJYO2CZWMwlADXtf4jVkoD8eIzDp8=@lists.linux.dev X-Gm-Message-State: AOJu0YyBnE3qF0wzNMMT2eLq1/UfbT0GgB+RwSOYI/TNZjQMpJGxon4u PQYVCVloiOjD/U9SkYPDbo2FKZ2XIGpq2K6XoA5EJ1jKHkDFIt+B13EQGi3Mhi2C0A== X-Gm-Gg: AZuq6aKopd65J6rNCOG4NjSM+IcRPvNFDZYX4r5RbAY5iZReQ7x4425Spl7wnihAJAt 8WewVJSdw+PYh4DZxbFOYcNqhCSlvXC/XecNEHylEWo9x00GMHckgzhDPyNwGKh4Y6i3Di8MghA pH+s0Ca8PbRcbDCdbiS+hbCMbDKH/HMJ146pxhzP0sEp/V1QMPgYzebpaxZGOxBP979i5hx3Rho Ud3Qh7H1KI3oZVkGceA6OE/xWMcpJeBFARhArG08+3FYKXSbSNNi/YiBas1Q6UGl/qxtajavl3t NQmgmn+2ya4TxuotfdeRzIiND4Z+WBYoF4E9qFeUESrVlv5Ui+aHPqWTArDVQb8gRVfixsiN7ur HbpFQ53HZ69k337AMliIXxAxnlfOpd0LbZ/Z6hXR5hmqBAn7VRnRr29j8dr4rWfkih6pbYUWCsI G3Z8ztjVBSJb/DZbuM037rmY68FjxyiW6P3p4E7VeGtGoDhKRGPVl/7WhD2ngaKHF3KZBCZ7lte 8vQauix4d0= X-Received: by 2002:a05:7022:aa1:b0:119:e56b:91f6 with SMTP id a92af1059eb24-12741bd1202mr3136852c88.39.1771265481071; Mon, 16 Feb 2026 10:11:21 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:20 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Frank.Li@nxp.com, Santosh Shilimkar , Sascha Hauer , andersson@kernel.org, arm-scmi@vger.kernel.org, cristian.marussi@arm.com, daniel.baluta@nxp.com, festevam@gmail.com, imx@lists.linux.dev, jay.buddhabhatti@amd.com, jonathanh@nvidia.com, kernel@pengutronix.de, konradybcio@kernel.org, krzk@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-tegra@vger.kernel.org, lucaswei@google.com, marco.crivellari@suse.com, mathieu.poirier@linaro.org, michal.simek@amd.com, nm@ti.com, rafael@kernel.org, robh@kernel.org, shawn.guo@linaro.org, sudeep.holla@kernel.org, tglx@kernel.org, thierry.reding@gmail.com Subject: [PATCH v3 00/15] mailbox: Stop sending NULL mailbox messages Date: Mon, 16 Feb 2026 10:09:37 -0800 Message-ID: <20260216181002.3475421-1-dianders@chromium.org> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As talked about in the first patch in this series, passing NULL as the 'mssg' argument to mbox_send_message() ends up causing confusion and quirky behavior inside the mailbox core. Despite this, there are a number of drivers that pass NULL. It is plausible that some of the drivers passing NULL may have been taking advantage of the quirks of the mailbox core. Specifically, they may have been taking advantage that calling "tx_done" wasn't truly necessary for NULL messages (it was a noop) or that NULL messages were passed onto the mailbox controller right away without queuing. This series introduces a new API call: mbox_ring_doorbell(). The new API call tries to mimic the specific quirks that were helpful in the old behavior and it's expected to be a nearly drop-in replacement. There are some subtle differences between the new call and the old behavior, but it's expected that all of these differences are only for cases where the old behavior made little sense. The description of the first patch details these differences. The series attempts to convert all in-tree users to stop passing NULL for mssg. As per above, there are some slight differences in behavior. If any of the patches are causing problems, they can safely be reverted while debugging the problems. Eventually, all code should be converted over to stop passing NULL mssg. Changes in v3: - Suggest mbox_ring_doorbell in the warning message - Updated patch description based on Cristian's response. Changes in v2: - Instead of just documenting NULL, introduce a new function Douglas Anderson (15): mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell() ACPI: PCC: Use mbox_ring_doorbell() instead of NULL message firmware: arm_scmi: Use mbox_ring_doorbell() instead of NULL message firmware: imx-dsp: Use mbox_ring_doorbell() instead of NULL message firmware: tegra: bpmp: Use mbox_ring_doorbell() instead of NULL message irqchip/qcom-mpm: Use mbox_ring_doorbell() instead of NULL message remoteproc: xlnx: Use mbox_ring_doorbell() instead of NULL message rpmsg: qcom_glink_rpm: Use mbox_ring_doorbell() instead of NULL message rpmsg: glink: smem: Use mbox_ring_doorbell() instead of NULL message rpmsg: qcom_smd: Use mbox_ring_doorbell() instead of NULL message soc: qcom: aoss: Use mbox_ring_doorbell() instead of NULL message soc: qcom: smp2p: Use mbox_ring_doorbell() instead of NULL message soc: qcom: smsm: Use mbox_ring_doorbell() instead of NULL message soc: ti: wkup_m3_ipc: Use mbox_ring_doorbell() instead of NULL message drivers: firmware: xilinx: Use mbox_ring_doorbell() instead of NULL message drivers/acpi/acpi_pcc.c | 4 +- .../firmware/arm_scmi/transports/mailbox.c | 8 +- drivers/firmware/imx/imx-dsp.c | 2 +- drivers/firmware/tegra/bpmp-tegra186.c | 4 +- drivers/irqchip/irq-qcom-mpm.c | 2 +- drivers/mailbox/mailbox.c | 82 ++++++++++++++++++- drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +- drivers/rpmsg/qcom_glink_rpm.c | 3 +- drivers/rpmsg/qcom_glink_smem.c | 3 +- drivers/rpmsg/qcom_smd.c | 13 +-- drivers/soc/qcom/qcom_aoss.c | 3 +- drivers/soc/qcom/smp2p.c | 8 +- drivers/soc/qcom/smsm.c | 8 +- drivers/soc/ti/wkup_m3_ipc.c | 10 +-- drivers/soc/xilinx/zynqmp_power.c | 2 +- include/linux/mailbox_client.h | 1 + include/linux/mailbox_controller.h | 4 +- 17 files changed, 108 insertions(+), 51 deletions(-) -- 2.53.0.273.g2a3d683680-goog