From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Francesco Lavra" <flavra@baylibre.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Lucas Stankus" <lucas.p.stankus@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Puranjay Mohan" <puranjay@kernel.org>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Ramona Gradinariu" <ramona.gradinariu@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Petre Rodan" <petre.rodan@subdimension.ro>,
"Dan Robertson" <dan@dlrobertson.com>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Jiri Kosina" <jikos@kernel.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Esteban Blanc" <eblanc@baylibre.com>,
"Jorge Marques" <jorge.marques@analog.com>,
"Sergiu Cuciurean" <sergiu.cuciurean@analog.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
"Alisa-Dariana Roman" <alisa.roman@analog.com>,
"Trevor Gamblin" <tgamblin@baylibre.com>,
"Renato Lui Geh" <renatogeh@gmail.com>,
"Eugen Hristev" <eugen.hristev@linaro.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Andreas Klinger" <ak@it-klinger.de>,
"Paul Cercueil" <paul@crapouillou.net>,
"Ramona Bolboaca" <ramona.bolboaca@analog.com>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Kent Gustavsson" <kent@minoris.se>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Matteo Martelli" <matteomartelli3@gmail.com>,
"Marius Cristea" <marius.cristea@microchip.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Francesco Dolcini" <francesco@dolcini.it>,
"João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Salih Erim" <salih.erim@amd.com>,
"Conall O'Griofa" <conall.ogriofa@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
"Gustavo Silva" <gustavograzs@gmail.com>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"Roan van Dijk" <roan@protonic.nl>,
"Jyoti Bhayana" <jbhayana@google.com>,
"Mariel Tinaco" <Mariel.Tinaco@analog.com>,
"Nishant Malpani" <nish.malpani25@gmail.com>,
"Rui Miguel Silva" <rmfrfs@gmail.com>,
"Linus Walleij" <linusw@kernel.org>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Alex Lanzano" <lanzano.alex@gmail.com>,
"Jagath Jog J" <jagathjog1996@gmail.com>,
"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"Remi Buisson" <remi.buisson@tdk.com>,
"Christian Eggers" <ceggers@arri.de>,
"Mudit Sharma" <muditsharma.info@gmail.com>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Ondřej Jirman" <megi@xff.cz>,
"Song Qiang" <songqiang1304521@gmail.com>,
"Dixit Parmar" <dixitparmar19@gmail.com>,
"Gerald Loacker" <gerald.loacker@wolfvision.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-mediatek@lists.infradead.org, imx@lists.linux.dev,
linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v6 4/7] iio: Rename 'sign' field to `format` in struct iio_scan_type
Date: Sat, 28 Feb 2026 17:59:54 +0000 [thread overview]
Message-ID: <20260228175954.1f0950a1@jic23-huawei> (raw)
In-Reply-To: <120c7f33-4ca1-4d35-ac1b-b65362f1adfc@baylibre.com>
On Wed, 25 Feb 2026 15:27:01 -0600
David Lechner <dlechner@baylibre.com> wrote:
> On 2/25/26 4:17 AM, Francesco Lavra wrote:
> > This field is used to differentiate between signed and unsigned integers.
> > A following commit will extend its use to in order to add support for non-
> > integer scan elements; therefore, change its name from 'sign' to a more
> > generic 'format'.
> >
>
> Maybe Jonathan is OK with doing this all at once, but another alternative
> could be to introduce a union to allow both names at the same time, then
> we could make the change more gradually.
Please do the union for v7. Not so much because I mind a global change, but
more because the chances of merge conflicts are too high.
Perhaps for this series just introduce the union and use it in the driver
here. We can then chase it through the rest of the tree as a separate step.
Alternatively leave it with a misleading name for now (so allow 'f' to be a
magic sign value) and we can do the rename as a follow up.
Jonathan
prev parent reply other threads:[~2026-02-28 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260225100421.2366864-1-flavra@baylibre.com>
2026-02-25 10:17 ` [PATCH v6 4/7] iio: Rename 'sign' field to `format` in struct iio_scan_type Francesco Lavra
2026-02-25 21:27 ` David Lechner
2026-02-28 17:59 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228175954.1f0950a1@jic23-huawei \
--to=jic23@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Mariel.Tinaco@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=ak@it-klinger.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alisa.roman@analog.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=antoniu.miclaus@analog.com \
--cc=bleung@chromium.org \
--cc=ceggers@arri.de \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@tuxon.dev \
--cc=conall.ogriofa@amd.com \
--cc=corbet@lwn.net \
--cc=cosmin.tanislav@analog.com \
--cc=dan@dlrobertson.com \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=dragos.bogdan@analog.com \
--cc=eblanc@baylibre.com \
--cc=eugen.hristev@linaro.org \
--cc=festevam@gmail.com \
--cc=flavra@baylibre.com \
--cc=francesco@dolcini.it \
--cc=gerald.loacker@wolfvision.net \
--cc=groeck@chromium.org \
--cc=gustavograzs@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=jagathjog1996@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jbhayana@google.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jikos@kernel.org \
--cc=jorge.marques@analog.com \
--cc=jpaulo.silvagoncalves@gmail.com \
--cc=kent@minoris.se \
--cc=kernel@pengutronix.de \
--cc=kuurtb@gmail.com \
--cc=l.goehrs@pengutronix.de \
--cc=lanzano.alex@gmail.com \
--cc=lars@metafoo.de \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo@kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=marius.cristea@microchip.com \
--cc=matteomartelli3@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=megi@xff.cz \
--cc=michal.simek@amd.com \
--cc=muditsharma.info@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=nish.malpani25@gmail.com \
--cc=nuno.sa@analog.com \
--cc=o.rempel@pengutronix.de \
--cc=paul@crapouillou.net \
--cc=petre.rodan@subdimension.ro \
--cc=puranjay@kernel.org \
--cc=ramona.bolboaca@analog.com \
--cc=ramona.gradinariu@analog.com \
--cc=remi.buisson@tdk.com \
--cc=renatogeh@gmail.com \
--cc=rmfrfs@gmail.com \
--cc=roan@protonic.nl \
--cc=s.hauer@pengutronix.de \
--cc=salih.erim@amd.com \
--cc=sergiu.cuciurean@analog.com \
--cc=skhan@linuxfoundation.org \
--cc=songqiang1304521@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tduszyns@gmail.com \
--cc=tgamblin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox