From: Frank Li <Frank.Li@nxp.com>
To: gregkh@linuxfoundation.org, rafael@kernel.org,
hanguidong02@gmail.com, ysato@users.sourceforge.jp,
dalias@libc.org, glaubitz@physik.fu-berlin.de,
abelvesa@kernel.org, srini@kernel.org, s.nawrocki@samsung.com,
nuno.sa@analog.com
Cc: Frank Li <frank.li@nxp.com>,
driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-hwmon@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
linux-sh@vger.kernel.org, Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v2 3/4] hwmon: axi-fan: don't use driver_override as IRQ name
Date: Tue, 3 Mar 2026 16:01:07 -0500 [thread overview]
Message-ID: <20260303210131.2966214-12-Frank.Li@nxp.com> (raw)
In-Reply-To: <20260303115720.48783-4-dakr@kernel.org>
From: Frank Li (AI-BOT) <frank.li@nxp.com>
> ret = devm_request_threaded_irq(&pdev->dev, ctl->irq, NULL,
> axi_fan_control_irq_handler,
> IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> - pdev->driver_override, ctl);
> + NULL, ctl);
Good catch. Using driver_override as IRQ name is indeed unsafe since it's
not guaranteed to be a valid string. Passing NULL is correct here; the
devm IRQ helpers will fall back to dev_name() which is always valid.
The fix is minimal and addresses the root cause. The error handling path
below looks fine—dev_err_probe() will still work correctly with the NULL
name.
Looks good to me.
AI bot review and may be useless.
next prev parent reply other threads:[~2026-03-03 21:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 11:53 [PATCH v2 0/4] driver core: generalize driver_override infrastructure Danilo Krummrich
2026-03-03 11:53 ` [PATCH v2 1/4] driver core: generalize driver_override in struct device Danilo Krummrich
2026-03-03 21:01 ` Frank Li
2026-03-04 2:27 ` Gui-Dong Han
2026-03-03 11:53 ` [PATCH v2 2/4] docs: driver-model: document driver_override Danilo Krummrich
2026-03-03 21:01 ` Frank Li
2026-03-03 11:53 ` [PATCH v2 3/4] hwmon: axi-fan: don't use driver_override as IRQ name Danilo Krummrich
2026-03-03 14:53 ` Nuno Sá
2026-03-03 16:23 ` Guenter Roeck
2026-03-03 16:25 ` Danilo Krummrich
2026-03-03 16:57 ` Guenter Roeck
2026-03-03 19:18 ` Danilo Krummrich
2026-03-03 21:01 ` Frank Li [this message]
2026-03-03 11:53 ` [PATCH v2 4/4] driver core: platform: use generic driver_override infrastructure Danilo Krummrich
2026-03-03 21:01 ` Frank Li
2026-03-05 12:42 ` Danilo Krummrich
2026-03-12 20:15 ` Danilo Krummrich
2026-03-16 23:56 ` Danilo Krummrich
2026-03-17 5:06 ` Greg KH
2026-03-17 8:36 ` Geert Uytterhoeven
2026-03-03 13:03 ` [PATCH v2 0/4] driver core: generalize " Gui-Dong Han
2026-03-12 15:21 ` Greg KH
2026-03-17 20:17 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303210131.2966214-12-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=abelvesa@kernel.org \
--cc=dakr@kernel.org \
--cc=dalias@libc.org \
--cc=driver-core@lists.linux.dev \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregkh@linuxfoundation.org \
--cc=hanguidong02@gmail.com \
--cc=imx@lists.linux.dev \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rafael@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=srini@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox