From: Frank Li <Frank.Li@nxp.com>
To: Frank Li <Frank.Li@nxp.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev
Cc: Frank Li <frank.li@nxp.com>,
pierluigi.p@variscite.com,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Markus Niebel <Markus.Niebel@tq-group.com>,
Matthias Schiffer <matthias.schiffer@tq-group.com>,
Yannic Moog <y.moog@phytec.de>, Josua Mayer <josua@solid-run.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Primoz Fiser <primoz.fiser@norik.com>,
linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: fsl: add Variscite DART-MX91 Boards
Date: Tue, 3 Mar 2026 16:01:02 -0500 [thread overview]
Message-ID: <20260303210131.2966214-7-Frank.Li@nxp.com> (raw)
In-Reply-To: <3b6984f4cf47f98fe6aa69705b771e7aaf787f79.1772534362.git.stefano.r@variscite.com>
From: Frank Li (AI-BOT) <frank.li@nxp.com>
This is a device tree bindings patch adding compatible strings for
Variscite DART-MX91 boards. Review follows:
> + - description: Variscite DART-MX91 based boards
> + items:
> + - const: variscite,var-dart-mx91-sonata # Variscite DART-MX91 on Sonata Development Board
Line exceeds 80 characters; wrap the inline comment or move to description.
> + - const: variscite,var-dart-mx91 # Variscite DART-MX91 SOM
Line exceeds 80 characters; same issue.
The patch itself is minimal and correct in structure. The YAML ordering
(hex then node name) is consistent with the changelog note. The compatible
strings follow the established pattern: board-specific variant, then SoM,
then fallback to fsl,imx91.
Suggestion: Move the inline comments to the description field or shorten
them to fit within 80 columns per coding-style.rst.
AI bot review and may be useless.
next prev parent reply other threads:[~2026-03-03 21:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 10:50 [PATCH v3 0/3] Add support for Variscite DART-MX91 and Sonata board Stefano Radaelli
2026-03-03 10:50 ` [PATCH v3 1/3] dt-bindings: arm: fsl: add Variscite DART-MX91 Boards Stefano Radaelli
2026-03-03 21:01 ` Frank Li [this message]
2026-03-03 10:50 ` [PATCH v3 2/3] arm64: dts: freescale: Add support for Variscite DART-MX91 Stefano Radaelli
2026-03-03 21:01 ` Frank Li
2026-03-04 15:55 ` Krzysztof Kozlowski
2026-03-03 10:50 ` [PATCH v3 3/3] arm64: dts: imx91-var-dart: Add support for Variscite Sonata board Stefano Radaelli
2026-03-03 21:01 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303210131.2966214-7-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=Markus.Niebel@tq-group.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=imx@lists.linux.dev \
--cc=josua@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@tq-group.com \
--cc=pierluigi.p@variscite.com \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefano.r@variscite.com \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox