From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013047.outbound.protection.outlook.com [40.107.162.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F26B023FC41 for ; Thu, 5 Mar 2026 15:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.47 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772723372; cv=fail; b=TuZlwx9H2S91ohQr0kgvEdF+rdxbliOsxC8m8NZVTM+ToALOoBlZo9qUrijYS9qk1xwiDr8Xl+d1JZJNAIoqH47Fd/5x2PssDyHVXpwsu70oSjl2IeLVGe/VsKhA1/7enWbMbUtqvJHvDzICClq56+m0NBPsHrCD4sh74B3dQ/U= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772723372; c=relaxed/simple; bh=qNYkHoMe2YgkzN9JWms5w3zJ3Ggd1RU8nSRgLvaz9xA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=rIjFWX8UYFhNaxeg3wvmSxuNUP8aEJPNMwk3Prtn73L6Z5QTJZ8NFLD4O3YpOFlkhXXbPQXhILsg/S4DyJseDs0XGaO3RGt+L7Z/DrYOuwGQFTP4buKYCAxbHIIQ4ntc8qbToohlWiFJYLjlo8J3jxwdVVBA7RN3hr4h/ronDAg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ClPGH7og; arc=fail smtp.client-ip=40.107.162.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ClPGH7og" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xky7/AV14awUan7E/CPk7lJ0MU54VmL1/talTB4eWQaGONTU55jxbnoq2IqLNdN8Y/HVGGcm30auI1EQaJN3wufPLmREJNbo0cYHz/KWBbwW2dCnUhCvwDAr+Pm2tUorQTOuZiVz+SJGVXeCulknjJsnrSv950b+u3vJCDhKvk1+CScNG10a3r4v9aw+Z0pQgrX+2xbFn7y6bEeLqU4T4Y79bkhkBYDSSWhGetK+f22YkaXoqt8TAKiyufTp2eg11RWUJpT3XjfmguQFFDyOINKl347/GjW7Kv8ApptjNrszys5ZIRfpAcIv7KgglNAy2aaVIdYxZ/rysikiYTssbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xYrbe9JwLaxyBIOCausiiQ2WE9g4C2fiaIkarIPgLto=; b=f1CZKpDpE/lXoyu44s1iqO4Gub0+D7Eq2Dn4YOUPx1zPz8ezWBfDBsBpfJiD86MolprakyQ7uG2unro1KeGEYDX5m+t0TRO3XyoXOZel81r3xbRPcQ84nvgD5vXRZOXLdmZQ0b2Vf1eVJiGzWNUHk2s8EcvRYjfAKEt5Iad23R1wp7zDSMn2gMt8ssl0KrAUfS4rFg46ktmUTCRaLx1ebEOH+9R+jZAcwRBx8s0QoKZ5YBihKBZpcmz0BAdlwrFuTy72rnfDmJgyT9vo/IoEejYrmeMRZjOFc2GPmvVhZFJugER9oY/h3eYIrfmnVpmTfmCLcYf47RprgQM/1SAxTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYrbe9JwLaxyBIOCausiiQ2WE9g4C2fiaIkarIPgLto=; b=ClPGH7ogqkUQpoOhBjFxScU3jcTQSUcjL9xnxu70grWqJVgHR60voAOqzOxVs0ZYFVHbvFwoDISj+klfijSiM/KZ+sfds4gW1OusvXD0cYjaeZgFDReo2pqA0qU8ffjdngYwL33yEUzvRqV6pDCA6ob4s6rrHMNklbbc9YcdD1jjsJ/OFpBV/qabCpEa5+Lsc4O6r6u0AFvznLmqIZlzUzbE8VBAZFU2ERAvY3aWwh++y6hwug1dtsGOpifc9S0PjLDhmYtgchMFPOejM1+3VkPyN1M4P5OboqbKiEMhqvxwIqnHLdi03TZfYXojAezFMaJApNV7Xc7jn9yNFvqYmw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8) by GVXPR04MB10563.eurprd04.prod.outlook.com (2603:10a6:150:221::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Thu, 5 Mar 2026 15:09:26 +0000 Received: from PA4PR04MB9366.eurprd04.prod.outlook.com ([fe80::75e4:8143:ddbc:6588]) by PA4PR04MB9366.eurprd04.prod.outlook.com ([fe80::75e4:8143:ddbc:6588%6]) with mapi id 15.20.9654.020; Thu, 5 Mar 2026 15:09:25 +0000 From: Frank Li To: netdev@vger.kernel.org, bpf@vger.kernel.org, Jakub Kicinski Cc: Frank Li , Larysa Zaremba , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Tony Nguyen , Przemek Kitszel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Simon Horman , Shuah Khan , Alexander Lobakin , Maciej Fijalkowski , "Bastien Curutchet (eBPF Foundation)" , Tushar Vyavahare , Jason Xing , =?UTF-8?q?Ricardo=20B=20=2E=20Marli=C3=A8re?= , Eelco Chaudron , Lorenzo Bianconi , Toke Hoiland-Jorgensen , imx@lists.linux.dev, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kselftest@vger.kernel.org, Aleksandr Loktionov , Dragos Tatulea , Magnus Karlsson Subject: Re: [PATCH net v5 4/9] ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz Date: Thu, 5 Mar 2026 10:08:56 -0500 Message-ID: <20260305150858.3910822-1-Frank.Li@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260305111253.2317394-5-larysa.zaremba@intel.com> References: <20260305111253.2317394-5-larysa.zaremba@intel.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SA9PR10CA0001.namprd10.prod.outlook.com (2603:10b6:806:a7::6) To PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR04MB9366:EE_|GVXPR04MB10563:EE_ X-MS-Office365-Filtering-Correlation-Id: ba478947-745d-452c-d5f0-08de7ac93023 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|52116014|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: fGNTZp2H4dIf8+v9ScEmN1XWDWOHlXO4+1i8SYoTVZOuZ/SkUsC6iDg2OhSpUnMv+PdC31RwBB/iSzYEDsK79qOhC9OiZvppJnyXTyTPtNi7kmFzfA3NCpGB7amhCpX1qloAGT5ax1O+9t2xxafbz0WPbAd8OhtrgV2xYwbVPdVPCObStbIC4ePlaEQpB748ZOmc5mlD/RfrdtXotkmlWPUOGOt3WfnXbLq5bHVwzUGXRnoQOwL0C4AaPBYMcH/BBQo5lCHr3Aw875UbJlAJPc8r/CHhz1O/on46GSLrXE5Dn2PotLBMQQHAkWGmbnVZ1uPkI6vEdlamPByeC88dmHgxG3QqKzuCVP4Nsyr0gVmCXh7ewrguna6xP4+bDnq98J8HyvaqDvuxB90tddnQ8WccLxi0H7EfDU8hXGjdVEj71xwFyE/4LrToTGBA3YbAKG0YQoutBmBmgxNyhm0seCleG1HAunkxINnvbHEK7wPqHf4iijq0qEVH0YgCgP/P2BBcCV0GNV8mB0VjT3jSNVAJtm0hGemGVCEgInQIoEw6W0YyyJYyb2t3eoVUGCeDNaw1rlQJqLsv6QLV37VujFCgCaLa2cd7MxAX07BllHSALdi3AnxJ4ZI7zzK12PAAJDq3BRWzuj7SXauT+JA2DJLvz8ZUsuPOWzE2ivG9EBryBC3O7QWROWVPwrHLtNFlGgrNW0N8Ia4U+ujunyHdMgT6suzGuNN2JTWQhMnqwNMWhR/Y0l2x+HV+DTNCeL7Fgx7DAWbsV5QrTJmJ9Q9eKnqQAKV5DtQL9g5EKLEPF04= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB9366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(52116014)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KIb9JUbFBMocWYasXygHlNjr9nQEPuh18VD4j8Huaio2GMmlz23YJSDBSpeD?= =?us-ascii?Q?M8FjTEF/s4YS8BHTCPgB0r9IS82h4HtG9rnns9kDVBJCNLFAbwYmTTGeYHnv?= =?us-ascii?Q?r08fwe51boAfinhljZlRRowCuoy8HzfTLMVXkohFXeVx+yXajSizlimf1csd?= =?us-ascii?Q?G7drVOw0F90nbYOKXcpghoKXZLiAPhio8mx9LkKaMSLU3SaKQs7V9hNvRyk9?= =?us-ascii?Q?QRvhOCxZ120HTuywCJ2PWM7k+KXQoK0W8JnH2JG4jTYi/ZdHNytWdZzfWsUW?= =?us-ascii?Q?499FxxhWmiZAlGAHA7WqZJDFRHIA2shoOLVURQp7frbErWYUXsyO1iqc0vPX?= =?us-ascii?Q?+tPVY9l3nETcYJklxwrqteKBiZ+N28SKPwbCyRatRltQetXSREUMIkaocn/s?= =?us-ascii?Q?qw706OMYhKJMwdBOdE1BsMqKTdoyyQ+aLyGcWDajkC1lcvurz26OpPLxH73s?= =?us-ascii?Q?Kkn5FtCUKR0yHlfVqqaBMy9iex1/8VB88K6H4zXB2ZO7xm4vcGRRLONWfmad?= =?us-ascii?Q?rsQCLp2vTaSwSl6czgYAlYA+dmlByuYWm7a7i71KbAU2uLgBAswIbZ04nL0P?= =?us-ascii?Q?2TRRea1Zcugdkft2iXedOh3B2iANH+g9F6r4jTkd99pHDFmXvuaFZxkUeP3k?= =?us-ascii?Q?63hZ5rJuj8C6SuIuflLDk1SRh+5nzb4hpT2auiOBvNY37YaLcAdNXOyFMpZC?= =?us-ascii?Q?QJ6Hkksyt6b83zen3knt/dN/F6cCXk9ZfqT+ida4zniVoWBBBL51zz2SBXRx?= =?us-ascii?Q?+03U/5vqPORmpbMMoW2yaXlCW5qeyP5W7y+aqh3yn/rX9G0Aer8icRTdTQVN?= =?us-ascii?Q?s3W5HM9P+DpmK3AIYS3fkB55urO9Ugj0pWLhbathaRID4pSN+3A3+xNvkXOa?= =?us-ascii?Q?k/2LAjEmiOQS0r3DydgAnqxvnq8LsqtKxf6RUQUh3ygCqMZmmSzDqRtAFeKW?= =?us-ascii?Q?G1HbJ8iD+xm66KqoOwMwvnuyP8jJ1Mg+cked3h533xL2qgjSkqspGgRsPG5/?= =?us-ascii?Q?e31C4vFwz/pcoF6jf1dVGIZXYjXYov7fyp7oECSNJiO02EeGf5qvQdEvQPjh?= =?us-ascii?Q?TaP3ldYajBjlv4V1TMm2FxiLvBGLyukBPAEbpIb+6gV4j9vPIE9bt+uDU6lr?= =?us-ascii?Q?srch9VzeN3YDAwV+a/E3WEC6UvL5O6Kz/NOdU+Igk0X++VMYzJrJMeqsR0eq?= =?us-ascii?Q?1eIRJv/PGSC4j4rmd2RFSJixjtIx5LYazL6HT3ZrFX+isQdM2/wk19VUzeYs?= =?us-ascii?Q?lQWjtgmhKWCH2qrHhsE+5iIpSeHhADRxk3DNU67+MJnKqZf26mhj/46FJCrm?= =?us-ascii?Q?8VMchpqx6EkQkCyAbYAzzDPM5g4eYoTj4qtyXjol4i8PHe1BO8W7ESfYGhyb?= =?us-ascii?Q?zJ5H393lkO52EECVzeA35vuu682WjtXEuWrAmBuUQvn2tXFdJByJS/G86xY5?= =?us-ascii?Q?ZVtftgXNmcSOv02uuxkcwYO6m602jkCgzFbmkEzVcbF4imqTQPX2TYVAv+1c?= =?us-ascii?Q?ROL3/+/Yco78GKmemRMx0yrDlBscMj5QNOWd3QtC1jGZxAT4taw2vW00Sdu5?= =?us-ascii?Q?bwkxVq45XTth2egOU/nQ/rAcznGFq9NRdPIBVQ9asCfwIvzC6fHVkUr7gTPa?= =?us-ascii?Q?uVfHk2/2NZCkzXdJUy7GYjwzRUqZH/d757TI2dWgCszA1GpNOSrEMONz+oTe?= =?us-ascii?Q?3Cylw0sOlub+A3v3S6vz1b9oKw3lSL8LMW9+ySAPUbYjN5+AELIlyVYY1ntb?= =?us-ascii?Q?Oa+AkhYdvQ=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba478947-745d-452c-d5f0-08de7ac93023 X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2026 15:09:25.5166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KN0h1fTucAuGnrTZIXiV11M3jkSxQQ4q3OUKOcsyArllUSRgqbeFZ11BJU2r0gNcwzNiB2hpMJipiCQccZAmXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10563 From: Frank Li (AI-BOT) > if (ring->xsk_pool) { > - rx_buf_len = > - xsk_pool_get_rx_frame_size(ring->xsk_pool); > + u32 frag_size = > + xsk_pool_get_rx_frag_step(ring->xsk_pool); AI: Variable declaration should be at the start of the block, not inline. Move `u32 frag_size;` to the top with other declarations. Although it allow declear varible at any place now, still perfer AI's suggest here. Frank > err = __xdp_rxq_info_reg(&ring->xdp_rxq, ring->netdev, > ring->q_index, > ring->q_vector->napi.napi_id, > - rx_buf_len); > + frag_size);