From: Frank Li <Frank.Li@nxp.com>
To: badhri@google.com, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, arnaud.ferraris@collabora.com,
dsimic@manjaro.org
Cc: Frank Li <frank.li@nxp.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, jun.li@nxp.com
Subject: Re: [PATCH v2 2/2] usb: roles: get usb role switch from parent only for usb-b-connector
Date: Mon, 9 Mar 2026 15:48:59 -0400 [thread overview]
Message-ID: <20260309194902.1785552-1-Frank.Li@nxp.com> (raw)
In-Reply-To: <20260309074313.2809867-3-xu.yang_2@nxp.com>
From: Frank Li (AI-BOT) <frank.li@nxp.com>
> if (!fwnode_device_is_compatible(fwnode, "usb-b-connector"))
> return NULL;
AI: Nit: inconsistent indentation. Should use a single tab, not two spaces.
Use '\t' for the return statement to match kernel style.
> parent = fwnode_get_parent(fwnode);
>
> if (!fwnode_property_present(parent, "usb-role-switch")) {
AI: Missing NULL check on parent before passing to fwnode_property_present().
If fwnode_get_parent() returns NULL, the next call will dereference it.
Add: if (!parent) return NULL;
Frank
next prev parent reply other threads:[~2026-03-09 19:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 7:43 [PATCH v2 0/2] improve usb_role_switch_is_parent() Xu Yang
2026-03-09 7:43 ` [PATCH v2 1/2] Revert "tcpm: allow looking for role_sw device in the main node" Xu Yang
2026-03-09 9:12 ` Arnaud Ferraris
2026-03-09 7:43 ` [PATCH v2 2/2] usb: roles: get usb role switch from parent only for usb-b-connector Xu Yang
2026-03-09 9:12 ` Arnaud Ferraris
2026-03-09 19:48 ` Frank Li [this message]
2026-03-10 2:47 ` Xu Yang
2026-03-09 11:32 ` [PATCH v2 0/2] improve usb_role_switch_is_parent() Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309194902.1785552-1-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=arnaud.ferraris@collabora.com \
--cc=badhri@google.com \
--cc=dsimic@manjaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox