From: Shenwei Wang <shenwei.wang@nxp.com>
To: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
arnaud.pouliquen@foss.st.com
Cc: Shuah Khan <skhan@linuxfoundation.org>,
linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shenwei Wang <shenwei.wang@nxp.com>, Peng Fan <peng.fan@nxp.com>,
devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com
Subject: [PATCH v10 4/5] gpio: rpmsg: add support for NXP legacy firmware protocol
Date: Mon, 9 Mar 2026 15:55:31 -0500 [thread overview]
Message-ID: <20260309205532.1794202-5-shenwei.wang@nxp.com> (raw)
In-Reply-To: <20260309205532.1794202-1-shenwei.wang@nxp.com>
Implement fixed-up message handlers to maintain compatibility with
existing i.MX devices that rely on the NXP legacy RPMSG firmware and
its transport protocol. This ensures backward compatibility and preserves
functionality for deployed NXP systems.
Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
---
drivers/gpio/Kconfig | 15 ++++
drivers/gpio/gpio-rpmsg.c | 147 ++++++++++++++++++++++++++++++++++++++
2 files changed, 162 insertions(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index cff0fda8a283..cd0ac5bf4443 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1907,6 +1907,21 @@ config GPIO_RPMSG
If unsure, say N.
+if GPIO_RPMSG
+
+config GPIO_RPMSG_NXP_LEGACY
+ bool "Support for the NXP legacy firmware"
+ depends on GPIO_RPMSG && ARCH_MXC
+ default y
+ help
+ Enable support for the legacy NXP firmware protocol used by older
+ i.MX products. This option provides compatibility for systems
+ that still rely on the nxp legacy message format and allows
+ existing deployments to continue functioning without requiring
+ firmware changes.
+
+endif
+
endmenu
menu "SPI GPIO expanders"
diff --git a/drivers/gpio/gpio-rpmsg.c b/drivers/gpio/gpio-rpmsg.c
index 9c609b55bc14..be263c09a1f0 100644
--- a/drivers/gpio/gpio-rpmsg.c
+++ b/drivers/gpio/gpio-rpmsg.c
@@ -84,6 +84,147 @@ struct rpdev_drvdata {
void *channel_devices[MAX_PORT_PER_CHANNEL];
};
+#ifdef CONFIG_GPIO_RPMSG_NXP_LEGACY
+/* NXP I.MX Legacy GPIO RPMSG protocol */
+#define IMX_RPMSG_CONFIG_INPUT 0
+#define IMX_RPMSG_CONFIG_OUTPUT 1
+#define IMX_RPMSG_GET_LEVEL 2
+#define IMX_RPMSG_GET_DIRECTION 3
+#define IMX_RPMSG_CMD_UNKNOWN 0x7F
+
+#define IMX_RPMSG_TRI_LOW_LEVEL 4
+#define IMX_RPMSG_TRI_HIGH_LEVEL 5
+
+#define IMX_RPMSG_ID 5
+#define IMX_RPMSG_VENDOR 1
+#define IMX_RPMSG_VERSION 0
+
+struct rpmsg_gpio_nxp_packet {
+ u8 id; /* Message ID Code */
+ u8 vendor; /* Vendor ID number */
+ u8 version; /* Protocol version number */
+ u8 type; /* Message type */
+ u8 cmd; /* Command code */
+ u8 reserved[5];
+ u8 line;
+ u8 port_idx;
+ u8 val1;
+ u8 val2;
+};
+
+static struct rpmsg_gpio_packet *
+rpmsg_gpio_imx_recv_fixed_up(struct rpmsg_device *rpdev, void *data)
+{
+ struct rpmsg_gpio_nxp_packet *imx_msg = data;
+ struct rpmsg_gpio_packet *msg;
+ struct rpdev_drvdata *drvdata;
+
+ if (!imx_msg)
+ return NULL;
+
+ drvdata = dev_get_drvdata(&rpdev->dev);
+ if (!drvdata->recv_pkt)
+ drvdata->recv_pkt = devm_kzalloc(&rpdev->dev, sizeof(*msg), GFP_ATOMIC);
+
+ if (!drvdata->recv_pkt)
+ return NULL;
+
+ msg = drvdata->recv_pkt;
+
+ msg->type = imx_msg->type;
+ msg->cmd = imx_msg->cmd;
+ msg->port_idx = imx_msg->port_idx;
+ msg->line = imx_msg->line;
+ msg->val1 = imx_msg->val1;
+ msg->val2 = imx_msg->val2;
+
+ switch (imx_msg->cmd) {
+ case IMX_RPMSG_GET_LEVEL:
+ msg->cmd = VIRTIO_GPIO_MSG_GET_VALUE;
+ break;
+
+ case IMX_RPMSG_GET_DIRECTION:
+ msg->cmd = VIRTIO_GPIO_MSG_GET_DIRECTION;
+ break;
+
+ case IMX_RPMSG_CONFIG_OUTPUT:
+ msg->cmd = VIRTIO_GPIO_MSG_SET_DIRECTION;
+ msg->val2 = VIRTIO_GPIO_DIRECTION_OUT;
+ break;
+
+ case IMX_RPMSG_CONFIG_INPUT:
+ msg->cmd = VIRTIO_GPIO_MSG_SET_DIRECTION;
+ msg->val2 = VIRTIO_GPIO_DIRECTION_IN;
+ break;
+
+ default:
+ break;
+ }
+
+ return msg;
+}
+
+static const int imx_std_cmd_map[] = {
+ IMX_RPMSG_CMD_UNKNOWN,
+ IMX_RPMSG_CMD_UNKNOWN, /* VIRTIO_GPIO_MSG_GET_NAMES */
+ IMX_RPMSG_GET_DIRECTION, /* VIRTIO_GPIO_MSG_GET_DIRECTION */
+ IMX_RPMSG_CONFIG_INPUT, /* VIRTIO_GPIO_MSG_SET_DIRECTION */
+ IMX_RPMSG_GET_LEVEL, /* VIRTIO_GPIO_MSG_GET_VALUE */
+ IMX_RPMSG_CONFIG_OUTPUT, /* VIRTIO_GPIO_MSG_SET_VALUE */
+ IMX_RPMSG_CONFIG_INPUT /* VIRTIO_GPIO_MSG_IRQ_TYPE */
+};
+
+static int rpmsg_gpio_imx_send_fixed_up(struct rpmsg_gpio_info *info,
+ struct rpmsg_gpio_packet *msg)
+{
+ struct rpmsg_gpio_nxp_packet imx_msg;
+
+ if (msg->cmd >= ARRAY_SIZE(imx_std_cmd_map))
+ return -EINVAL;
+
+ imx_msg.id = IMX_RPMSG_ID;
+ imx_msg.vendor = IMX_RPMSG_VENDOR;
+ imx_msg.version = IMX_RPMSG_VERSION;
+ imx_msg.type = msg->type;
+ imx_msg.cmd = imx_std_cmd_map[msg->cmd];
+ imx_msg.port_idx = msg->port_idx;
+ imx_msg.line = msg->line;
+ imx_msg.val1 = msg->val1;
+ imx_msg.val2 = msg->val2;
+
+ switch (msg->cmd) {
+ case VIRTIO_GPIO_MSG_IRQ_TYPE:
+ switch (msg->val1) {
+ case VIRTIO_GPIO_IRQ_TYPE_LEVEL_HIGH:
+ imx_msg.val1 = IMX_RPMSG_TRI_HIGH_LEVEL;
+ break;
+ case VIRTIO_GPIO_IRQ_TYPE_LEVEL_LOW:
+ imx_msg.val1 = IMX_RPMSG_TRI_LOW_LEVEL;
+ break;
+ default:
+ break;
+ }
+ break;
+
+ case VIRTIO_GPIO_MSG_SET_DIRECTION:
+ imx_msg.val1 = 0;
+ if (msg->val1 == VIRTIO_GPIO_DIRECTION_OUT)
+ imx_msg.cmd = IMX_RPMSG_CONFIG_OUTPUT;
+ break;
+
+ default:
+ break;
+ }
+
+ return rpmsg_send(info->rpdev->ept, &imx_msg, sizeof(imx_msg));
+}
+
+static const struct rpmsg_gpio_fixed_up imx_fixed_up_data = {
+ .recv_fixed_up = rpmsg_gpio_imx_recv_fixed_up,
+ .send_fixed_up = rpmsg_gpio_imx_send_fixed_up,
+};
+#endif
+
static int rpmsg_gpio_send_message(struct rpmsg_gpio_port *port,
struct rpmsg_gpio_packet *msg,
bool sync)
@@ -576,6 +717,12 @@ static const struct of_device_id rpmsg_gpio_dt_ids[] = {
static struct rpmsg_device_id rpmsg_gpio_channel_id_table[] = {
{ .name = "rpmsg-io" },
+#ifdef CONFIG_GPIO_RPMSG_NXP_LEGACY
+ {
+ .name = "rpmsg-io-channel",
+ .driver_data = (kernel_ulong_t)&imx_fixed_up_data
+ },
+#endif
{ },
};
MODULE_DEVICE_TABLE(rpmsg, rpmsg_gpio_channel_id_table);
--
2.43.0
next prev parent reply other threads:[~2026-03-09 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 20:55 [PATCH v10 0/5] Enable Remote GPIO over RPMSG on i.MX Platform Shenwei Wang
2026-03-09 20:55 ` [PATCH v10 1/5] docs: driver-api: gpio: rpmsg gpio driver over rpmsg bus Shenwei Wang
2026-03-09 22:24 ` Shuah Khan
2026-03-09 20:55 ` [PATCH v10 2/5] dt-bindings: remoteproc: imx_rproc: Add "rpmsg" subnode support Shenwei Wang
2026-03-09 20:55 ` [PATCH v10 3/5] gpio: rpmsg: add generic rpmsg GPIO driver Shenwei Wang
2026-03-09 20:55 ` Shenwei Wang [this message]
2026-03-09 20:55 ` [PATCH v10 5/5] arm64: dts: imx8ulp: Add rpmsg node under imx_rproc Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309205532.1794202-5-shenwei.wang@nxp.com \
--to=shenwei.wang@nxp.com \
--cc=Frank.Li@nxp.com \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox