From: Mark Adamenko <marusik.adamenko@gmail.com>
To: linux-staging@lists.linux.dev
Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de,
gregkh@linuxfoundation.org, imx@lists.linux.dev,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Adamenko <marusik.adamenko@gmail.com>
Subject: [PATCH v3] staging: media: imx: fix parenthesis ending checks
Date: Mon, 9 Mar 2026 17:26:43 -0700 [thread overview]
Message-ID: <20260310002643.27465-1-marusik.adamenko@gmail.com> (raw)
Remove 4 checks for ending with a parenthesis by removing unnecessary
line breaks, and forward declare a variable for a function call that
would otherwise remain over 80 columns.
Signed-off-by: Mark Adamenko <marusik.adamenko@gmail.com>
---
v3: fix commit message
---
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c
index 77360bfe081a..2339b59af7b0 100644
--- a/drivers/staging/media/imx/imx-ic-prpencvf.c
+++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
@@ -315,8 +315,7 @@ static void prp_setup_vb2_buf(struct prp_priv *priv, dma_addr_t *phys)
buf = imx_media_capture_device_next_buf(vdev);
if (buf) {
priv->active_vb2_buf[i] = buf;
- phys[i] = vb2_dma_contig_plane_dma_addr(
- &buf->vbuf.vb2_buf, 0);
+ phys[i] = vb2_dma_contig_plane_dma_addr(&buf->vbuf.vb2_buf, 0);
} else {
priv->active_vb2_buf[i] = NULL;
phys[i] = priv->underrun_buf.phys;
@@ -704,11 +703,9 @@ static int prp_start(struct prp_priv *priv)
}
if (ipu_rot_mode_is_irt(priv->rot_mode))
- priv->eof_irq = ipu_idmac_channel_irq(
- ic_priv->ipu, priv->rot_out_ch, IPU_IRQ_EOF);
+ priv->eof_irq = ipu_idmac_channel_irq(ic_priv->ipu, priv->rot_out_ch, IPU_IRQ_EOF);
else
- priv->eof_irq = ipu_idmac_channel_irq(
- ic_priv->ipu, priv->out_ch, IPU_IRQ_EOF);
+ priv->eof_irq = ipu_idmac_channel_irq(ic_priv->ipu, priv->out_ch, IPU_IRQ_EOF);
ret = devm_request_irq(ic_priv->ipu_dev, priv->eof_irq,
prp_eof_interrupt, 0,
@@ -750,7 +747,7 @@ static int prp_start(struct prp_priv *priv)
static void prp_stop(struct prp_priv *priv)
{
struct imx_ic_priv *ic_priv = priv->ic_priv;
- unsigned long flags;
+ unsigned long flags, timeout_in_jiffies;
int ret;
/* mark next EOF interrupt as the last before stream off */
@@ -761,9 +758,8 @@ static void prp_stop(struct prp_priv *priv)
/*
* and then wait for interrupt handler to mark completion.
*/
- ret = wait_for_completion_timeout(
- &priv->last_eof_comp,
- msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT));
+ timeout_in_jiffies = msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT);
+ ret = wait_for_completion_timeout(&priv->last_eof_comp, timeout_in_jiffies);
if (ret == 0)
v4l2_warn(&ic_priv->sd, "wait last EOF timeout\n");
--
2.53.0
next reply other threads:[~2026-03-10 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 0:26 Mark Adamenko [this message]
2026-03-10 15:24 ` [PATCH v3] staging: media: imx: fix parenthesis ending checks Frank Li
2026-05-04 21:03 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310002643.27465-1-marusik.adamenko@gmail.com \
--to=marusik.adamenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox