Re: [PATCH v2 net-next 13/14] net: dsa: netc: initialize buffer bool table and implement flow-control

Russell King (Oracle)
2026-03-23T09:20:22Z

On Mon, Mar 23, 2026 at 02:07:51PM +0800, Wei Fang wrote:
> @@ -1288,7 +1411,17 @@ static void netc_mac_link_up(struct phylink_config *config,
> netc_port_set_rmii_mii_mac(np, speed, duplex);
> }
>
> + if (duplex == DUPLEX_HALF) {
> + /* As per 802.3 annex 31B, PAUSE frames are only supported
> + * when the link is configured for full duplex operation.
> + */
> + tx_pause = false;
> + rx_pause = false;
> + }

I keep seeing this totally unnecessary code in reviews of mac_link_up()
methods. See phylink_resolve_an_pause().

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!