Re: [PATCH 1/2] dt-bindings: watchdog: Convert TS-4800 to DT schema

Rob Herring
2026-03-23T18:10:09Z

On Mon, Mar 23, 2026 at 12:59:34PM -0400, Frank Li wrote:
> On Mon, Mar 23, 2026 at 10:46:12AM +0200, Eduard Bostina wrote:
> > Convert the Technologic Systems TS-4800 watchdog timer bindings
> > to DT schema.
> >
> > Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> > ---
> > Note:
> > * This patch is part of the GSoC2026 application process for device tree bindings conversions
> > * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> >
> > .../watchdog/technologic,ts4800-wdt.yaml | 46 +++++++++++++++++++
> > .../bindings/watchdog/ts4800-wdt.txt | 25 ----------
> > 2 files changed, 46 insertions(+), 25 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml b/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
> > new file mode 100644
> > index 000000000..cb2066b4b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/technologic,ts4800-wdt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Technologic Systems TS-4800 Watchdog
> > +
> > +maintainers:
> > + - Eduard Bostina <egbostina@gmail.com>
> > +
> > +allOf:
> > + - $ref: watchdog.yaml#
>
> Move allOf after required incase add if-else branch later.
>
> > +
> > +properties:
> > + compatible:
> > + const: technologic,ts4800-wdt
> > +
> > + syscon:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + items:
> > + - items:
> > + - description: Phandle to the FPGA's syscon
> > + - description: Offset to the watchdog register
> > + description: Phandle / integers array that points to the syscon node which
> > + describes the FPGA's syscon registers.
> > +
> > +required:
> > + - compatible
> > + - syscon
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + syscon: syscon@b0010000 {
> > + compatible = "syscon", "simple-mfd";
> > + reg = <0xb0010000 0x3d>;
> > + reg-io-width = <2>;
> > +
>
> Needn't this part. just keep below watchdog node should be enough.

Well, the next thing to fix is going to be that this node needs a
specific compatible. It doesn't look like there's any other child nodes,
so probably want just one schema that defines both nodes.

Rob