Re: [PATCH 3/4] remoteproc: add helper for optional ELF resource tables

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The helper rproc_elf_load_rsc_table_optional() silently ignores firmware corruption errors by incorrectly assuming all -EINVAL returns mean a missing table.
--

commit 0067d38d8bcda280b1137f92af4ffd133bfa24fe
Author: Ben Levinsky <ben.levinsky@amd.com>
remoteproc: add helper for optional ELF resource tables

This commit adds a wrapper around rproc_elf_load_rsc_table() to treat a
missing ELF resource table as optional. It does this by converting an
-EINVAL return code into a success code.

> diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h
> --- a/drivers/remoteproc/remoteproc_internal.h
> +++ b/drivers/remoteproc/remoteproc_internal.h
[ ... ]
> @@ -146,6 +146,18 @@ static inline int rproc_mem_entry_iounmap(struct rproc *rproc,
>  	return 0;
>  }
>  
> +static inline int rproc_elf_load_rsc_table_optional(struct rproc *rproc,
> +						    const struct firmware *fw)
> +{
> +	int ret;
> +
> +	ret = rproc_elf_load_rsc_table(rproc, fw);
> +	if (ret == -EINVAL)
> +		dev_dbg(&rproc->dev, "no resource table found\n");
> +
> +	return ret == -EINVAL ? 0 : ret;

Does this inadvertently mask actual firmware corruption?

Looking at rproc_elf_load_rsc_table(), it returns -EINVAL when find_table()
fails:

drivers/remoteproc/remoteproc_elf_loader.c:rproc_elf_load_rsc_table() {
	...
	shdr = find_table(dev, fw);
	if (!shdr)
		return -EINVAL;
	...
}

However, find_table() returns NULL not only when the .resource_table section
is missing, but also when it is explicitly malformed (e.g., truncated,
missing header, unsupported version, or non-zero reserved bytes).

Since this helper converts all -EINVAL returns to success, will it allow
driver initialization to proceed with an invalid or corrupted resource table?

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511211841.284809-1-ben.levinsky@amd.com?part=3