Re: [PATCH RESEND] clocksource: move NXP timer selection to drivers/clocksource

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The patch incorrectly broadens the dependency for `VF_USE_ARM_GLOBAL_TIMER` from `ARCH_MULTI_V7` to `ARM && SOC_VF610`, which breaks the default clocksource selection for Cortex-M4 builds of the Vybrid SoC.
--

commit cb813057e5be52d91a25b9ef118dc8090d04e9c6
Author: Enric Balletbo i Serra <eballetb@redhat.com>

clocksource: move NXP timer selection to drivers/clocksource

This commit relocates the NXP clocksource selection from the mach-imx Kconfig
to drivers/clocksource/Kconfig to allow sharing across architectures. It also
updates the selection to support ARCH_S32 and adds an option to fall back to
the standard ARM Architected Timer.

> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index fd91127065454..b5c88ec658025 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
[ ... ]
> +choice
> +	prompt "NXP clocksource for scheduler clock"
> +	depends on SOC_VF610 || ARCH_S32
> +	# Default to Global Timer for Vybrid (32-bit)
> +	default VF_USE_ARM_GLOBAL_TIMER if SOC_VF610
> +	# Default to None for S32 (64-bit)
> +	default VF_TIMER_NONE if ARCH_S32
> +
> +	config VF_USE_ARM_GLOBAL_TIMER
> +		bool "Use NXP Vybrid Global Timer"
> +		# This option is ONLY visible if we are on 32-bit ARM
> +		depends on ARM && SOC_VF610

Does this dependency change break Cortex-M4 builds for the Vybrid SoC?

The Freescale Vybrid SoC supports both Cortex-A5 (ARCH_MULTI_V7) and
Cortex-M4 (ARM_SINGLE_ARMV7M) configurations. Previously,
VF_USE_ARM_GLOBAL_TIMER explicitly depended on ARCH_MULTI_V7. This correctly
hid the option on M4 builds, allowing Kconfig to fall back to the PIT timer
by default.

Since ARM evaluates to true for all 32-bit ARM architectures, including
ARM_SINGLE_ARMV7M, this option is now visible on Cortex-M4 builds. Because
the choice block defaults to VF_USE_ARM_GLOBAL_TIMER for SOC_VF610, Kconfig
will select the Cortex-A Global Timer by default for the Cortex-M4.

Will the M4 core fail to boot since it lacks the ARM Global Timer and the
required NXP_PIT_TIMER driver is no longer selected?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-fix-nxp-timer-v1-1-565e13ef3e46@redhat.com?part=1