Re: [PATCH 6/7] firmware: imx: ele: Use dev_err for error report

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The introduced dev_err() lacks a trailing newline, contains a typo, and introduces redundant OOM logging.
--

commit c914c76ccf6cf2fdb05859267c584040fec1d7b6
Author: Peng Fan <peng.fan@nxp.com>

firmware: imx: ele: Use dev_err for error report

This commit replaces a dev_dbg() call with dev_err() for reporting a
memory allocation failure in ele_get_info().

> diff --git a/drivers/firmware/imx/ele_base_msg.c b/drivers/firmware/imx/ele_base_msg.c
> index 05a518df38cd6..2f0046cd5ad06 100644
> --- a/drivers/firmware/imx/ele_base_msg.c
> +++ b/drivers/firmware/imx/ele_base_msg.c
> @@ -74,7 +74,7 @@ int ele_get_info(struct se_if_priv *priv, struct ele_dev_info *s_info)
>  						   &get_info_addr,
>  						   GFP_KERNEL);
>  	if (!get_info_data) {
> -		dev_dbg(priv->dev,
> +		dev_err(priv->dev,
>  			"%s: Failed to allocate get_info_addr.", __func__);

[Severity: Low]
Is it possible to add a trailing newline (\n) to this error message?
Without it, the kernel log output could be mangled or concatenated with
subsequent messages.

Also, does this message contain a typo? It mentions failing to allocate
get_info_addr, but the actual buffer being allocated is get_info_data.

Finally, since dma_alloc_coherent() already natively dumps a stack trace on
allocation failure, is this custom out-of-memory error message partially
redundant? While these string contents existed prior to this patch, promoting
it to dev_err() makes these formatting and style issues unconditionally
visible.

>  		return -ENOMEM;
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525-ele-v1-v1-0-a9570c4bffc9@nxp.com?part=6