Re: [PATCH v3 2/5] remoteproc: switch exact-match drivers to wc-ioremap callbacks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The error logging in the `rproc_mem_entry_ioremap_wc` helper uses the `%pa` format specifier for a `dma_addr_t` pointer instead of `%pad`.
--

commit 06feb3b32004ed7bd1d29e99430abd615d6b4449
Author: Ben Levinsky <ben.levinsky@amd.com>

remoteproc: switch exact-match drivers to wc-ioremap callbacks

Replace the exact-match carveout map and unmap callbacks in the
existing remoteproc drivers with the common wc-ioremap helpers. This
covers xlnx_r5_remoteproc, rcar_rproc, st_remoteproc, stm32_rproc,
imx_rproc, and imx_dsp_rproc.

Leave the zynqmp R5 TCM callbacks alone because they also clear the
mapped memory and are therefore not exact matches for the shared
helpers.

> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 632614013dc65..a6e36a11627d7 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
[ ... ]
> @@ -237,8 +208,8 @@ static int stm32_rproc_prepare(struct rproc *rproc)
>  			mem = rproc_mem_entry_init(dev, NULL,
>  						   (dma_addr_t)res.start,
>  						   resource_size(&res), da,
> -						   stm32_rproc_mem_alloc,
> -						   stm32_rproc_mem_release,
> +						   rproc_mem_entry_ioremap_wc,

[Severity: Medium]
Does replacing the stm32 callback with the common helper regress its error
logging?

The original stm32_rproc_mem_alloc() function correctly used %pad for
mem->dma:

    dev_err(dev, "Unable to map memory region: %pad+0x%zx\n",
            &mem->dma, mem->len);

However, the new rproc_mem_entry_ioremap_wc() helper uses %pa:

    dev_err(&rproc->dev, "Unable to map memory region: %pa+%zx\n",
            &mem->dma, mem->len);

Since mem->dma is a dma_addr_t, and %pa expects a phys_addr_t *, could this
result in reading the wrong number of bytes on platforms where
sizeof(dma_addr_t) != sizeof(phys_addr_t)?

This could combine the dma and adjacent len fields, printing a garbage
address in the log.

> +						   rproc_mem_entry_iounmap,
>  						   "%.*s", strchrnul(res.name, '@') - res.name,
>  						   res.name);
>  			if (mem)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529021637.2077602-1-ben.levinsky@amd.com?part=2