Re: [PATCH v2 net-next 12/12] net: enetc: dynamically allocate rxmsg based on VF count

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

Pre-existing issues:
- [High] VLAN promiscuous mode is silently broken for Virtual Functions beyond the first two due to a hardcoded 3-bit mask.
- [High] Potential division by zero when allocating hardware rings to VFs if the device supports 0 VFs and has more than 8 rings.
--

commit 03bc9cb8ddeec88c130b193926ea03b84b9d152b
Author: Wei Fang <wei.fang@nxp.com>

net: enetc: dynamically allocate rxmsg based on VF count

This commit updates the ENETC driver to dynamically allocate the rxmsg array
based on the actual number of Virtual Functions supported by the hardware.
It removes the fixed allocation size to prevent memory over-allocation on
hardware variants with fewer or zero VFs.

>     i.MX94 standalone ENETC: 0 VFs

[Severity: High]
This is a pre-existing issue, but if a device supports 0 VFs and reports
more than 8 hardware rings during probe, will this result in a division by
zero?

In enetc_port_si_configure(), the driver reserves 8 rings for the PF and
distributes the rest to the VFs:

drivers/net/ethernet/freescale/enetc/enetc_pf.c:enetc_port_si_configure() {
	...
	if (num_rings)
		num_rings -= ENETC_PF_NUM_RINGS;
	...
	if (num_rings) {
		num_rings /= pf->total_vfs;
		val |= ENETC_PSICFGR0_SET_TXBDR(num_rings);
		val |= ENETC_PSICFGR0_SET_RXBDR(num_rings);
	}
	...
}

If pf->total_vfs is 0 and there are remaining rings, the division by zero
will cause a kernel panic.


>     i.MX94 internal ENETC:   3 VFs

[Severity: High]
This isn't a bug introduced by this patch, but since 3 VFs means there are
4 Station Interfaces (1 PF + 3 VFs) in total, will VLAN promiscuous mode
work for the 3rd VF?

The ENETC_PSIPVMR_SET_VP() macro uses a hardcoded 0x7 mask (3 bits), which
covers only the first 3 Station Interfaces:

drivers/net/ethernet/freescale/enetc/enetc_hw.h:
#define ENETC_PSIPVMR_SET_VP(simap)	((simap) & 0x7)

Because of this mask, the 4th Station Interface (the 3rd VF mapped to bit 3)
is silently dropped from the VLAN promiscuous mode configuration.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522092438.1264020-1-wei.fang@nxp.com?part=12