From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C85B3F8231 for ; Fri, 26 Jun 2026 14:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782484213; cv=none; b=lKB2jLiobJ70DfVwpCU8idambciYbNM9t0rIGzdKJUEc7NlqnxtUn8zS5vzHynRab1sJL6ZiaF55GSjTHHqJB8C/AifgHkt7oJY9E7ftu5u53wpHaew8SFsSoVWKSyjlu4g07NEDMAOY5tCsV69v/Z729SxiteqDO3Eb5xO6V2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782484213; c=relaxed/simple; bh=62WGItH/nKsA4jiLztr8BealNzEavczRY+wH5drktQo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pzmx2zAj18ZUdxTAxcKTNey4NEzoKi8I7ir4+yeom/uY/zcbHJto/EEUBqSFP/nVY7PAe4QnsnjP5o0w/PA/B0nal+MQT4S613QgVbZnXPn6E3R7g6RdR+pKtZsmAuotFPSNG2xtGP0LPj8djMksexLPVjibCeCSyuhMoiSUO7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=JxLk6gzy; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JxLk6gzy" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B2106174; Fri, 26 Jun 2026 16:29:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782484165; bh=62WGItH/nKsA4jiLztr8BealNzEavczRY+wH5drktQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JxLk6gzym/QGytAkBH6IOdj4e4dK7npLijt1RCGCdtCWFmDs5lTRPIow0tPH+AScd plWks+NGQn7YO1NeORSXTtRh62/fwLX7qtfOaJA2E+a9YAuI0haNN/uOAModZ4Hca7 Q4izlUBS4mmnbjMsCoN2AaZx9pLUorY9Rnu8AHpM= Date: Fri, 26 Jun 2026 17:30:05 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jacopo Mondi , Sakari Ailus , Jimmy Su , Matthias Fend , Mikhail Rudenko , Daniel Scally , Jacopo Mondi , Michael Riesch , Benjamin Mugnier , Sylvain Petinot , Paul Elder , Martin Kepplinger , Quentin Schulz , Tommaso Merciai , Svyatoslav Ryhel , Richard Acayan , Thierry Reding , Jonathan Hunter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Bjorn Andersson , Konrad Dybcio , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux@ew.tq-group.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 2/8] media: dt-bindings: video-interface-devices: add video-interface-devices.h references Message-ID: <20260626143005.GD2363897@killaraus.ideasonboard.com> References: <20260626-kbingham-orientation-v2-0-47178be927b4@ideasonboard.com> <20260626-kbingham-orientation-v2-2-47178be927b4@ideasonboard.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260626-kbingham-orientation-v2-2-47178be927b4@ideasonboard.com> Hi Kieran, Thank you for the patch. On Fri, Jun 26, 2026 at 01:07:54PM +0100, Kieran Bingham wrote: > Expand the documentation of the video-interface-devices orientation to > reference the include/dt-bindings/media/video-interface-devices.h header > which provides human readable defines for the orientation enum, to help > avoid hardcoding values in dts. > > Signed-off-by: Kieran Bingham > --- > .../bindings/media/video-interface-devices.yaml | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/video-interface-devices.yaml b/Documentation/devicetree/bindings/media/video-interface-devices.yaml > index a81d2a155fe6..c9c3f4f16719 100644 > --- a/Documentation/devicetree/bindings/media/video-interface-devices.yaml > +++ b/Documentation/devicetree/bindings/media/video-interface-devices.yaml > @@ -392,17 +392,22 @@ properties: > The orientation of a device (typically an image sensor or a flash LED) > describing its mounting position relative to the usage orientation of the > system where the device is installed on. > + See include/dt-bindings/media/video-interface-devices.h. If you want this to be a separate paragraph, you need a blnk line on top. Otherwise, Move "See" to the previous line. Reviewed-by: Laurent Pinchart > + > $ref: /schemas/types.yaml#/definitions/uint32 > enum: > - # Front. The device is mounted on the front facing side of the system. For > - # mobile devices such as smartphones, tablets and laptops the front side > - # is the user facing side. > + # MEDIA_ORIENTATION_FRONT > + # The device is mounted on the front facing side of the system. For > + # mobile devices such as smartphones, tablets and laptops the front > + # side is the user facing side. > - 0 > - # Back. The device is mounted on the back side of the system, which is > + # MEDIA_ORIENTATION_BACK > + # The device is mounted on the back side of the system, which is > # defined as the opposite side of the front facing one. > - 1 > - # External. The device is not attached directly to the system but is > - # attached in a way that allows it to move freely. > + # MEDIA_ORIENTATION_EXTERNAL > + # The device is not attached directly to the system but is attached in > + # a way that allows it to move freely. > - 2 > > additionalProperties: true -- Regards, Laurent Pinchart