Re: [PATCH v26 6/7] arm64: dts: imx8ulp: add secure enclave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Inconsistent indentation within the `hsm0: secure-enclave` device tree node.
--

commit 4cec20d0cfb861451c94ac062d1b2fa257cda38b
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds support for the NXP secure enclave (EdgeLock Enclave
firmware) for the imx8ulp-evk. It adds the sram0 label to the existing
sram node and introduces the new secure-enclave hsm0 node.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf388..933127f870c6f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
[ ... ]
> @@ -185,6 +185,13 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			 compatible = "fsl,imx8ulp-se-ele-hsm";
> +			 mbox-names = "tx", "rx";
> +			 mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			 sram = <&sram0>;
> +		 };

[Severity: Low]
This isn't a bug, but there appears to be an extra space after the tab
indentation for the properties and the closing brace in the hsm0 node.
Should these lines use standard tab-only indentation to match the rest
of the device tree file?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-imx-se-if-v26-0-146446285744@nxp.com?part=6