Re: [PATCH v3 6/7] mmc: sdhci-esdhc-imx: make non-fatal errors non-blocking in suspend

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Early return in sdhci_esdhc_resume() upon pm_runtime_force_resume() failure leaves PM usage counter leaked and IRQ permanently disabled.
--

commit 61953c1fd047583f443719985f25bd317c4b2b1b
Author: Luke Wang <ziniu.wang_1@nxp.com>

mmc: sdhci-esdhc-imx: make non-fatal errors non-blocking in suspend
    
Make pinctrl_pm_select_sleep_state() and mmc_gpio_set_cd_wake() failures
non-fatal in the suspend path to ensure they do not block system suspend.

> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 97ee3f933bda7..abee3d7a07a36 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c

[ ... ]

> @@ -2107,7 +2109,7 @@ static int sdhci_esdhc_suspend(struct device *dev)
>  	 */
>  	pm_runtime_force_suspend(dev);
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static int sdhci_esdhc_resume(struct device *dev)

[Severity: High]
This is a pre-existing issue, but does the early return inside
sdhci_esdhc_resume() leave the IRQ permanently disabled and leak the PM
usage counter?

During sdhci_esdhc_suspend(), the driver increments the PM usage counter and
disables the IRQ:

    ret = pm_runtime_resume_and_get(dev);
    ...
    disable_irq(host->irq);

If pm_runtime_force_resume() fails later during sdhci_esdhc_resume(), the
function returns immediately:

    ret = pm_runtime_force_resume(dev);
    if (ret)
        return ret;

Does skipping the corresponding enable_irq() and pm_runtime_put_autosuspend()
calls leave the controller in an unusable state and prevent future runtime
PM transitions?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629091954.3227151-1-ziniu.wang_1@oss.nxp.com?part=6