Re: [PATCH net] net: phy: motorcomm: read EEE abilities in yt8521_get_features()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing early return on the error path allows execution to fall through, causing unnecessary MDIO reads during a failure state.
--

commit 4dca8ceeaa7210baaf997bd7af025147319f1c9b
Author: Clark Wang <xiaoning.wang@nxp.com>

net: phy: motorcomm: read EEE abilities in yt8521_get_features()

This patch updates yt8521_get_features() to call
genphy_c45_read_eee_abilities() so that EEE abilities are correctly
populated for YT8521/YT8531S devices.

> diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
> index 5071605a1a117..e69c453af574b 100644
> --- a/drivers/net/phy/motorcomm.c
> +++ b/drivers/net/phy/motorcomm.c
> @@ -2490,6 +2490,9 @@ static int yt8521_get_features(struct phy_device *phydev)
>  		/* add fiber's features to phydev->supported */
>  		yt8521_prepare_fiber_features(phydev, phydev->supported);
>  	}
> +
> +	genphy_c45_read_eee_abilities(phydev);

[Severity: Low]
If yt8521_get_features_paged() fails in the first branch of this function:

	if (priv->reg_page != YT8521_RSSR_TO_BE_ARBITRATED) {
		ret = yt8521_get_features_paged(phydev, priv->reg_page);
	} else {

ret will contain an error code, but there is no early return check before
falling through to this new call.

Could this cause genphy_c45_read_eee_abilities() to perform unnecessary
MDIO reads during a failure state?

> +
>  	return ret;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701075730.133707-1-xiaoning.wang@oss.nxp.com?part=1