Re: [PATCH v7 7/8] arm64: dts: imx8: add camera parallel interface (CPI) node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing required `ports` property in `parallel_cpi` devicetree node.
--

commit 1d4cc7458532cecd40b7f34cec88fcc17577ec4d
Author: Frank Li <Frank.Li@nxp.com>

arm64: dts: imx8: add camera parallel interface (CPI) node
    
This commit adds the camera parallel interface (CPI) node to the imx8-ss-img
device tree. It also wires up the corresponding endpoints in the imx8qxp
wrapper.

> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
> index a72b2f1c4a1b2..b504f99f6acdb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
[ ... ]
> @@ -222,6 +222,19 @@ irqsteer_parallel: irqsteer@58260000 {
>  		status = "disabled";
>  	};
>  
> +	parallel_cpi: cpi@58261000 {
> +		compatible = "fsl,imx8qxp-pcif";
> +		reg = <0x58261000 0x1000>;
> +		clocks = <&pi0_pxl_lpcg IMX_LPCG_CLK_0>,
> +			 <&pi0_ipg_lpcg IMX_LPCG_CLK_4>;
> +		clock-names = "pixel", "ipg";
> +		assigned-clocks = <&clk IMX_SC_R_PI_0 IMX_SC_PM_CLK_PER>;
> +		assigned-clock-parents = <&clk IMX_SC_R_PI_0_PLL IMX_SC_PM_CLK_PLL>;
> +		assigned-clock-rates = <160000000>;
> +		power-domains = <&pd IMX_SC_R_PI_0>;
> +		status = "disabled";
> +	};

[Severity: Low]
Does this node need a ports child property to pass dtbs_check validation?

The fsl,imx93-pcif.yaml binding strictly requires the ports property in the
fsl,imx8qxp-pcif compatible node. While the i.MX8QXP wrapper subsequently
appends the ports node, other platforms like i.MX8QM that include this shared
base dtsi do not. This will cause devicetree validation to fail for those
other platforms.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-imx8qxp_pcam-v7-0-b47d9e363400@nxp.com?part=7