From: sashiko-bot@kernel.org
To: "Stefano Radaelli" <stefano.radaelli21@gmail.com>
Cc: conor+dt@kernel.org, Frank.Li@kernel.org, imx@lists.linux.dev,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 05/15] arm64: dts: freescale: imx8mn-var-som: Add support for WM8904 audio codec
Date: Fri, 03 Jul 2026 08:55:46 +0000 [thread overview]
Message-ID: <20260703085546.EBFF41F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <126ae03f37ba587560ab8c94b7833236d97990de.1783067947.git.stefano.r@variscite.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add 'I3C' recovery GPIO properties, but the patch actually adds standard I2C recovery properties to an I2C bus.
--
commit 460d6d4855137d91e75cf4e76f05f397a7d5bb75
Author: Stefano Radaelli <stefano.r@variscite.com>
arm64: dts: freescale: imx8mn-var-som: Add support for WM8904 audio codec
This commit adds support for the WM8904 audio codec to the VAR-SOM-MX8MN board.
It enables the I2C device, the SAI peripheral, and exposes the sound node via
a simple-audio-card configuration. Additionally, it configures the I2C bus
recovery pins.
> Add I3C recovery gpio properties.
[Severity: Medium]
This isn't a bug in the code, but there appears to be a typo in the commit
message. The patch adds standard I2C recovery properties to the i2c3 node
rather than anything related to I3C. Could this be corrected to say "I2C3"
or "I2C" instead of "I3C"?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783067947.git.stefano.r@variscite.com?part=5
next prev parent reply other threads:[~2026-07-03 8:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 8:45 [PATCH v1 00/15] arm64: dts: freescale: imx8mn-var-som: Align SOM and Symphony DTSs Stefano Radaelli
2026-07-03 8:45 ` [PATCH v1 01/15] arm64: dts: freescale: imx8mn-var-som: Move UART4 description to Symphony Stefano Radaelli
2026-07-03 8:45 ` [PATCH v1 02/15] arm64: dts: freescale: imx8mn-var-som: move SD card support " Stefano Radaelli
2026-07-03 8:54 ` sashiko-bot
2026-07-03 8:45 ` [PATCH v1 03/15] arm64: dts: freescale: imx8mn-var-som: Align fsl,pins tables Stefano Radaelli
2026-07-03 8:45 ` [PATCH v1 04/15] arm64: dts: freescale: imx8mn-var-som: Update FEC support with MaxLinear PHY Stefano Radaelli
2026-07-03 9:01 ` sashiko-bot
2026-07-03 8:45 ` [PATCH v1 05/15] arm64: dts: freescale: imx8mn-var-som: Add support for WM8904 audio codec Stefano Radaelli
2026-07-03 8:55 ` sashiko-bot [this message]
2026-07-03 8:45 ` [PATCH v1 06/15] arm64: dts: freescale: imx8mn-var-som: Add MCP251xFD CAN controller Stefano Radaelli
2026-07-03 8:45 ` [PATCH v1 07/15] arm64: dts: freescale: imx8mn-var-som: Rework WiFi/BT and add legacy dts Stefano Radaelli
2026-07-03 8:57 ` sashiko-bot
2026-07-03 8:45 ` [PATCH v1 08/15] arm64: dts: freescale: imx8mn-var-som: drop duplicate USB OTG node Stefano Radaelli
2026-07-03 8:45 ` [PATCH v1 09/15] arm64: dts: freescale: imx8mn-var-som: enable FlexSPI interface Stefano Radaelli
2026-07-03 8:56 ` sashiko-bot
2026-07-03 8:45 ` [PATCH v1 10/15] arm64: dts: imx8mn-var-som-symphony: Add TPM2 support Stefano Radaelli
2026-07-03 9:00 ` sashiko-bot
2026-07-03 8:45 ` [PATCH v1 11/15] arm64: dts: imx8mn-var-som-symphony: Enable I2C4 Stefano Radaelli
2026-07-03 8:45 ` [PATCH v1 12/15] arm64: dts: imx8mn-var-som-symphony: add wakeup sources Stefano Radaelli
2026-07-03 8:46 ` [PATCH v1 13/15] arm64: dts: imx8mn-var-som-symphony: keep RGB_SEL low Stefano Radaelli
2026-07-03 8:46 ` [PATCH v1 14/15] arm64: dts: imx8mn-var-som-symphony: enable PWM1 Stefano Radaelli
2026-07-03 8:46 ` [PATCH v1 15/15] arm64: dts: imx8mn-var-som-symphony: Disable internal RTC Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703085546.EBFF41F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox