Re: [PATCH] clk: imx: imx8qxp: add missing MODULE_DEVICE_TABLE()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The driver lacks a `.remove` callback, which leaks CCF clocks on module unload and creates a use-after-free condition.
--

commit 61eb45335ff77dbb9e15e46999a551625f299716
Author: Pengpeng Hou <pengpeng@iscas.ac.cn>

clk: imx: imx8qxp: add missing MODULE_DEVICE_TABLE()

This commit adds the missing MODULE_DEVICE_TABLE() export for the driver's
match table. This ensures module alias information is generated, allowing
for automatic module loading.

> diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
> --- a/drivers/clk/imx/clk-imx8qxp.c
> +++ b/drivers/clk/imx/clk-imx8qxp.c
> @@ -337,6 +337,7 @@ static const struct of_device_id imx8qxp_match[] = {
>  	{ .compatible = "fsl,imx8qm-clk", &imx_clk_scu_rsrc_imx8qm, },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, imx8qxp_match);
>  
>  static struct platform_driver imx8qxp_clk_driver = {
>  	.driver = {
>  		.name = "imx8qxp-clk",
>  		.of_match_table = imx8qxp_match,
>  		.suppress_bind_attrs = true,
>  	},
>  	.probe = imx8qxp_clk_probe,
>  };

[Severity: High]
This is a pre-existing issue, but does unloading this module create a
use-after-free condition in the Common Clock Framework?

Because imx8qxp_clk_driver lacks a .remove callback, it does not seem to
call of_clk_del_provider() and imx_clk_scu_unregister() when the module
is unloaded. Since these clocks are not devm-managed, do they remain
active in the CCF?

If they stay active after the module is removed via rmmod, won't any
subsequent access to the clock tree trigger a panic, as the clock .ops
pointers will reference unloaded module memory?

Looking at drivers/clk/imx/clk-scu.c, the imx_clk_scu_driver sub-driver
also appears to lack a .remove callback to clean up CCF clocks and memory
when unregistered.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260705001705.70400-1-pengpeng@iscas.ac.cn?part=1