Re: [PATCH v7 1/1] arm64: dts: add tqma9596la-mba95xxca

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Conflicting GPIO assignments for M.2 Key-E SDIO Reset between the `wifi-connector` device node and a leftover `gpio-hog`.
- [High] The fan supply regulator `reg_pwm_fan` is never enabled, leaving the fan unpowered.
--

--- Patch [1]: [PATCH v7 1/1] arm64: dts: add tqma9596la-mba95xxca ---
commit c06cc8eb19eb4a69fc0547caa6773b503beae3a7
Author: Markus Niebel <Markus.Niebel@ew.tq-group.com>

arm64: dts: add tqma9596la-mba95xxca
    
This patch adds support for the TQMa95xxLA modules on the MBa95xxCA carrier
board. It introduces a common device tree include for the module and a specific
device tree for the carrier board.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
> new file mode 100644
> index 0000000000000..db2fd6991d112
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
[ ... ]
> +	wifi-connector {
> +		compatible = "pcie-m2-e-connector";
> +		vpcie3v3-supply = <&reg_v3v3_mb>;
> +		vpcie1v8-supply = <&reg_v1v8_mb>;
> +		i2c-parent = <&lpi2c2>;
> +		w-disable1-gpios = <&expander2 9 GPIO_ACTIVE_LOW>;
> +		w-disable2-gpios = <&expander2 10 GPIO_ACTIVE_LOW>;
> +		/* UART_WAKE is connected to SM */
> +		/* SDIO_WAKE is connected to SM */
> +		sdio-reset-gpios = <&expander3 2 GPIO_ACTIVE_LOW>;
> +	};

[Severity: High]
Does this sdio-reset-gpios assignment conflict with the gpio-hog on the same
line?

The wifi-connector node requests expander3 line 2 here, but later in the file,
m2-keye-sdio-rst-hog hogs the exact same GPIO line. Won't this conflict cause
the wifi-connector driver to fail probing with -EBUSY?

[ ... ]
> +	fan_controller: fan-controller@2f {
> +		compatible = "microchip,emc2301", "microchip,emc2305";
> +		reg = <0x2f>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		#pwm-cells = <3>;
> +		status = "okay";
> +
> +		fan: fan@0 {
> +			reg = <0x0>;
> +			pwms = <&fan_controller 40000 PWM_POLARITY_INVERTED 1>;
> +			#cooling-cells = <2>;
> +			fan-supply = <&reg_pwm_fan>;
> +		};
> +	};

[Severity: High]
Will the reg_pwm_fan regulator ever be enabled?

The emc2305 driver does not parse or request the fan-supply property from
child nodes. Since reg_pwm_fan is not marked regulator-always-on earlier in
this file, does this leave the fan unpowered?

[ ... ]
> +	/* D41 OUT 1V8 */
> +	expander3: gpio@76 {
> +		compatible = "ti,tca9539";
> +		reg = <0x76>;
> +		vcc-supply = <&reg_v1v8_mb>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +
> +		gpio-line-names =
> +			/* 00 */ "ENET1_RESET#", "ENET2_RESET#",
> +			/* 02 */ "M2_KEYE_SDIO_RST#", "M2_KEYE_DEV_WLAN_WAKE#",
> +			/* 04 */ "M2_KEYE_DEV_BT_WAKE", "M2_KEYB_W_DISABLE2#",
> +			/* 06 */ "M2_KEYB_RST#", "M2_KEYB_FULL_CARD_PWR_OFF#",
> +			/* 08 */ "M2_KEYB_DPR", "CAM0_PWR#",
> +			/* 10 */ "CAM1_PWR#", "CAM0_RST#",
> +			/* 12 */ "CAM1_RST#", "CAM0_TRIGGER",
> +			/* 14 */ "CAM1_TRIGGER", "FAN_PWR_EN";
> +
> +		m2-keye-sdio-rst-hog {
> +			gpio-hog;
> +			gpios = <2 GPIO_ACTIVE_LOW>;
> +			output-low;
> +			line-name = "M2_KEYE_SDIO_RST#";
> +		};

[Severity: High]
This appears to be the leftover hog that conflicts with the wifi-connector
node above. Should this hog be removed to allow the driver to request the
GPIO?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707062506.949806-1-alexander.stein@ew.tq-group.com?part=1