Re: [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `rsmu_i2c_id` array is missing its required null-terminating sentinel element.
--

--- Patch [13]: [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id ---
commit f026cb9dcb83c5116a80b49dec846447e0d9699f
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

mfd: Use named initializers for arrays of i2c_device_id

This patch updates arrays of i2c_device_id to use named initializers
instead of relying on positional initializers. This improves robustness
against future changes to the struct.

> --- a/drivers/mfd/rsmu_i2c.c
> +++ b/drivers/mfd/rsmu_i2c.c

[ ... ]

> @@ -328,14 +328,13 @@ static void rsmu_i2c_remove(struct i2c_client *client)
>  }
>  
>  static const struct i2c_device_id rsmu_i2c_id[] = {
> -	{ "8a34000",  RSMU_CM },
> -	{ "8a34001",  RSMU_CM },
> -	{ "8a34002",  RSMU_CM },
> -	{ "82p33810", RSMU_SABRE },
> -	{ "82p33811", RSMU_SABRE },
> -	{ "8v19n850", RSMU_SL },
> -	{ "8v19n851", RSMU_SL },
> -	{}
> +	{ .name = "8a34000",  .driver_data = RSMU_CM },
> +	{ .name = "8a34001",  .driver_data = RSMU_CM },
> +	{ .name = "8a34002",  .driver_data = RSMU_CM },
> +	{ .name = "82p33810", .driver_data = RSMU_SABRE },
> +	{ .name = "82p33811", .driver_data = RSMU_SABRE },
> +	{ .name = "8v19n850", .driver_data = RSMU_SL },
> +	{ .name = "8v19n851", .driver_data = RSMU_SL },
>  };

[Severity: High]
Will this lead to an out-of-bounds read during device matching? The
terminating null sentinel was inadvertently removed from the end of the
rsmu_i2c_id array. 

The I2C subsystem (specifically i2c_match_id()) loops over i2c_device_id
arrays until it encounters an element with an empty name string, so it will
now read past the end of the array.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783507945.git.u.kleine-koenig@baylibre.com?part=13