From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DF7B4C77AD; Wed, 8 Jul 2026 18:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783536285; cv=none; b=D5ba10mnJxEJA/ebWC2uR0uixcgw+adjojL6OHVzh+GhJe/Q21AZgv80voWQ4vGMoZTsDms3ltZYFc6n4koDDb8dM9CCcqJUgb76RODKSqvcq1n506iGVJjEtGeBS3UbOykC90ui6bA2QoYS//aZUtBoUvV970SoY0dfWoyeoBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783536285; c=relaxed/simple; bh=85Jp50UK8fj+Vc18nF+seRgtBiI6g18T70Jkg4yLu+o=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ojQ4Dcl3LOXUwISkHBjfiL1POY4XWtUvU6f85NuW77FY0NGfWBrnPC+jvkDcneaARH2ppu2rzUoEvYEFNX3bnxvy8xPBuFb6nw+VwZ4VEPjCIIwxYVv3McVxu+RkRX1j2q+uUeQOOBHdmhJLuITnHjn0I9GeymvcQFdqPAFmZ8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UTqXgGht; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UTqXgGht" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61E111F000E9; Wed, 8 Jul 2026 18:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783536283; bh=85Jp50UK8fj+Vc18nF+seRgtBiI6g18T70Jkg4yLu+o=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UTqXgGhtv71+2iMjEvPeqSwxP2/C81rSy4sUhvGiFJuljF/HbOm/xAqQcUqfq6BZb JfzaK6Fv5tF7CiMaksQKdQq7bzprxcMQMWxgaVVOrUagxC/02ZsE0gcr3WvOiHI6d9 Z6MtdzgAeG77P7VF2vLWxy1hc3ePEqBKJF/14qNY8JOf1526iCXnTwf1HalHAZdkOY c4UpF2qmk/5/tyUngOkTwRHeXZPsy9prapuYLTD3qO7ncIRHN5GTV01+9VjmMBOrEB +qZ0lhGBWKXbI+reO2YYBCdRozY0pQo1Y5ntXzDRlHChJ2vfrFuQH6Gd4NHYy1y5cD YcA4KTZH3SJPw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 04/10] dmaengine: dw-edma: Pass down dw_edma_chan to reduce one level of indirection Reply-To: sashiko-reviews@lists.linux.dev To: Frank.Li@oss.nxp.com Cc: Frank.Li@kernel.org, linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, vkoul@kernel.org, imx@lists.linux.dev In-Reply-To: <20260708-edma_ll-v4-4-cc128f0afb61@nxp.com> References: <20260708-edma_ll-v4-0-cc128f0afb61@nxp.com> <20260708-edma_ll-v4-4-cc128f0afb61@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 08 Jul 2026 18:44:42 +0000 Message-Id: <20260708184443.61E111F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: > From: Frank Li >=20 > Some helper functions do not use any information from dw_edma_chunk, so > passing a dw_edma_chan pointer directly avoids an unnecessary level of > pointer dereferencing and simplifies data access. >=20 > Tested-by: Koichiro Den > Signed-off-by: Frank Li Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260708-edma_ll-v4= -0-cc128f0afb61@nxp.com?part=3D4